Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX repeated game note #88

Closed
wants to merge 1 commit into from

Conversation

Yuya-Furusawa
Copy link
Contributor

Fix recursive repeated game notebook.
Original note is based on old version of Julia(ver0.X?).
I fix the note to be compatible with ver 1.3.

@oyamad
Copy link
Member

oyamad commented Apr 18, 2020

Great, thanks!
Can you briefly describe the major changes you made and the problems (regarding plots)?

@Yuya-Furusawa
Copy link
Contributor Author

Yuya-Furusawa commented Apr 18, 2020

Major changes are:

  • Change package dependencies
  • Use appropriate functions instead of old functions(such as linspace)
  • Fix some typos

There may be no problems in plotting graph(I will check later). There are some issues in Clp package and I opened the issue, but it is resolved.

@oyamad
Copy link
Member

oyamad commented Apr 18, 2020

@oyamad oyamad requested a review from cc7768 April 18, 2020 15:39
@Yuya-Furusawa
Copy link
Contributor Author

Yuya-Furusawa commented Apr 19, 2020

Oh,
There is no problem in my local environment, but the plots are not displayed properly once I pushed it to GitHub.
The message "Unable to load WebIO. Please make sure WebIO works for your Jupyter client. For troubleshooting, please see the WebIO/IJulia documentation." comes up.
I think this issue is due to my local environment and it is resolved by pushing from another environment.

@oyamad
Copy link
Member

oyamad commented Apr 20, 2020

The same for me: Plots are displayed on my local computer, but not on nbviewer: https://nbviewer.jupyter.org/github/QuantEcon/QuantEcon.notebooks/blob/Yuya-Furusawa-rgnote/recursive_repeated_games.ipynb

Has this issue JuliaGizmos/WebIO.jl#381 been addressed?

@cc7768 Do you have any thought? Would it be possible to replace PlotlyJS with something else?

@amit1rrr
Copy link

Sorry to intrude but I noticed this PR contains Jupyter notebook files that are hard to review on GitHub due to the JSON diffs.

You might want to checkout ReviewNB, code review tool for notebooks. Provides visual diffs & commenting for Jupyter notebooks on GitHub. Completely free for open source repositories.

Disclaimer: I built ReviewNB

diff_and_commenting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants