Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Add random_state option (issue #153) #329

Merged
merged 2 commits into from Aug 30, 2017

Conversation

QBatista
Copy link
Member

Address #153

As a first step, here are some changes adding a random_state option to arma.py (issue #153). If the approach is appropriate, I have already written the code for the other remaining files.

@oyamad
Copy link
Member

oyamad commented Aug 25, 2017

@QBatista Rebase this on master (or merge master).

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 93.543% when pulling 6706bb9 on QBatista:add_random_state_arma into 5095334 on QuantEcon:master.

@mmcky
Copy link
Contributor

mmcky commented Aug 29, 2017

@lbui01 is this random state feature going to interfere with any work you're doing on random seed (or is that primarily to support lecture site)?

@mmcky
Copy link
Contributor

mmcky commented Aug 29, 2017

thanks @QBatista this is a nice addition to arma

@jstac
Copy link
Contributor

jstac commented Aug 29, 2017

@lbui01 is focused on the lecture site.
@QBatista : many thanks

@mmcky mmcky merged commit c79d6ba into QuantEcon:master Aug 30, 2017
@QBatista QBatista deleted the add_random_state_arma branch September 23, 2017 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants