Refactor train_jax_model to use fori_loop and simplify return value #264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace jax.lax.scan with jax.lax.fori_loop in train_jax_model to match the implementation pattern used in train_jax_optax. The function now returns only the final parameter vector instead of including training and validation loss histories. Changes: - Modified train_jax_model to use fori_loop instead of scan - Simplified return value to only include final parameters - Updated calling code to match train_jax_optax pattern - Removed validation loss plotting (no longer tracked) - Consolidated initialization code into single cell This change improves consistency across the lecture and simplifies the training interface. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
✅ Deploy Preview for incomparable-parfait-2417f8 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactored
train_jax_modelto match the implementation pattern used intrain_jax_optaxby replacingjax.lax.scanwithjax.lax.fori_loopand simplifying the return value.Changes
train_jax_modelto usefori_loopinstead ofscantrain_jax_optaxpatternMotivation
Testing
🤖 Generated with Claude Code