Skip to content

Conversation

@blkboxeconomist
Copy link
Collaborator

@blkboxeconomist blkboxeconomist commented Dec 7, 2025

This PR removes unused validation data parameters (x_validate and y_validate) from the train_jax_model function signature. These parameters were never referenced in the function body, as validation is performed after training completes rather than during the training loop.

  • Removes unused x_validate and y_validate parameters from train_jax_model function signature
  • Updates both function calls (warmup and timed runs) to match the new signature

@netlify
Copy link

netlify bot commented Dec 7, 2025

Deploy Preview for incomparable-parfait-2417f8 ready!

Name Link
🔨 Latest commit a9b83d6
🔍 Latest deploy log https://app.netlify.com/projects/incomparable-parfait-2417f8/deploys/6934e78eb14e5800085447a3
😎 Deploy Preview https://deploy-preview-266--incomparable-parfait-2417f8.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link

github-actions bot commented Dec 7, 2025

@github-actions github-actions bot temporarily deployed to pull request December 7, 2025 02:41 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 7, 2025 02:45 Inactive
@mmcky mmcky requested a review from Copilot December 8, 2025 04:21
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes unused validation data parameters (x_validate and y_validate) from the train_jax_model function signature. These parameters were never referenced in the function body, as validation is performed after training completes rather than during the training loop.

  • Removes unused x_validate and y_validate parameters from train_jax_model function signature
  • Updates both function calls (warmup and timed runs) to match the new signature

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mmcky
Copy link
Contributor

mmcky commented Dec 8, 2025

thanks @blkboxeconomist

@mmcky mmcky merged commit 9dd8db0 into main Dec 8, 2025
13 checks passed
@mmcky mmcky deleted the imf_nn_fix branch December 8, 2025 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants