Skip to content

Conversation

@shlff
Copy link
Member

@shlff shlff commented May 13, 2023

Hi @jstac this PR fix #26 .

Looking forward to your comments.

@netlify
Copy link

netlify bot commented May 13, 2023

Deploy Preview for incomparable-parfait-2417f8 ready!

Name Link
🔨 Latest commit 0450279
🔍 Latest deploy log https://app.netlify.com/sites/incomparable-parfait-2417f8/deploys/646284305a4cfb0009b35584
😎 Deploy Preview https://deploy-preview-59--incomparable-parfait-2417f8.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented May 13, 2023

@github-actions github-actions bot temporarily deployed to pull request May 13, 2023 09:04 Inactive
@jstac
Copy link
Contributor

jstac commented May 14, 2023

Many thanks @shlff , this looks very good. Well done.

Just some small things for now:

  • Please hide output of installs.
  • egm -> EGM
  • Ifp -> IFP

Once you've done that I'll do a round of edits.

@github-actions github-actions bot temporarily deployed to pull request May 14, 2023 10:31 Inactive
@shlff
Copy link
Member Author

shlff commented May 14, 2023

Thanks for your comments @jstac .

I've made the changes you suggested. Also, I've included the file _admonition/gpu.md as we did for other JAX lectures.

Please find a preview here:

Looking forward to reading your edits.

@github-actions github-actions bot temporarily deployed to pull request May 14, 2023 21:18 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 15, 2023 01:15 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 15, 2023 10:57 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 15, 2023 18:54 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 15, 2023 19:21 Inactive
@jstac jstac merged commit 4cfa128 into main May 15, 2023
@jstac jstac deleted the ifp_egm branch May 15, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

IFP using endogenous grid method

3 participants