Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scipy: Return value in bisect(), replace deprecated normed kwarg with density, and set random seed #1

Closed
wants to merge 3 commits into from

Conversation

@MaxGhenis
Copy link

commented Mar 30, 2019

This makes three changes:

  1. Return the result in the bisect in the solution at the end. User pyanni noted that the current solution doesn't return anything in https://discourse.quantecon.org/t/scipy-lecture-question-1-recursive-function/528. In making this change and reviewing the diff I noticed two other things that could be improved, and made changes accordingly:
  2. Replace the deprecated normed kwarg in hist with density. This was throwing a warning.
  3. Set the random number seed. The results of random number generators are different this time, but this will reduce variability when making future changes.
@natashawatkins

This comment has been minimized.

Copy link
Member

commented Mar 31, 2019

Hi @MaxGhenis, actually to edit the lectures, you'll need to edit the rst file in /source/rst. We use this as it's easier to version control.

@natashawatkins

This comment has been minimized.

Copy link
Member

commented Mar 31, 2019

Sorry, the files are in another repo: https://github.com/QuantEcon/lecture-source-py

This repo is automatically generated from source files.

@natashawatkins

This comment has been minimized.

Copy link
Member

commented Mar 31, 2019

However the first change isn't needed. Please feel free to implement the second change. The third change is mitigated by the fact that we only edit the inputs in the rst file, and automatically generate the output.

@MaxGhenis

This comment has been minimized.

Copy link
Author

commented Mar 31, 2019

Thanks @natashawatkins, closing this to continue the three discussions elsewhere:

  1. In https://discourse.quantecon.org/t/scipy-lecture-question-1-recursive-function/528/4 (can be followed with a PR in lecture-source-py if you agree)
  2. PR QuantEcon/lecture-source-py#215
  3. Issue QuantEcon/lecture-source-py#216 (makes sense that it's mitigated by automatically generated output, but I think the consistency can still benefit users)

@MaxGhenis MaxGhenis closed this Mar 31, 2019

@MaxGhenis MaxGhenis deleted the MaxGhenis:bisect branch Apr 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.