[FIX] Fixes short_path image issues #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…put before saving png
Contributor
Author
|
Note: this issue won't come up locally unless you fully clear the cache and have the latest environment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was that
jupyter-cacheis executing all notebooks in the source repository, including those in_static/lecture_specificwhich was rebuilding the images forshort_pathvia the notebook included to build them. Howeverpylabwas used to show the figures in the notebook and the software must have changed to clear thematplotlib.figobject after showing it in the notebook causing the images to be written as empty images.cc: @AakashGfude @jstac