Skip to content

Conversation

@emilsavalan
Copy link

commiting changes from old repo

commiting changes from old repo
@jstac
Copy link
Contributor

jstac commented Jan 22, 2022

Thanks again @emilsavalan .

@mmcky , I can't see the netlify link. Sorry if I'm missing something obvious.

@mmcky
Copy link
Contributor

mmcky commented Jan 22, 2022

hey @jstac one key limitation of github actions is that it won't "naturally" build from forks due to security issues. However there is usually a button to click that says "run github actions after review" that doesn't seem present. I'll check the settings.

This should only be required once for first time contributors in the settings .. Hmm.

@mmcky
Copy link
Contributor

mmcky commented Jan 22, 2022

I think I see why I will need to update our ci configuration.
Currently it only runs on push and it needs to specify pull_request to work with fork contributions

https://github.com/quantecon/lecture-python.myst/blob/09b131dad91fa14cd1be2e716257ca5f97890ad7/.github/workflows/ci.yml#L2

I'll try and fix this up later today.

@mmcky
Copy link
Contributor

mmcky commented Mar 21, 2022

Closing as transferred this to a local branch. Thanks @emilsavalan -- #216

@mmcky mmcky closed this Mar 21, 2022
mmcky added a commit that referenced this pull request Aug 9, 2023
* updating iteration variable

commiting changes from old repo

* Empty-Commit

---------

Co-authored-by: Emil Savalanlı <emil@savalan.ml>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants