Skip to content

Few bug fixes on convergence conditions #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 1, 2022
Merged

Few bug fixes on convergence conditions #256

merged 3 commits into from
Sep 1, 2022

Conversation

@Smit-create
Copy link
Member

@Smit-create Smit-create commented Aug 31, 2022 •
edited
Loading

Fixes #175
Fixes #176

cc @jstac

@jstac
Copy link
Contributor

jstac commented Aug 31, 2022

Many thanks @Smit-create .

I think if verbose should be elif verbose --- we only want this print to be triggered if error <= tol (see #175)

@Smit-create
Copy link
Member Author

Smit-create commented Sep 1, 2022 •
edited
Loading

I think if verbose should be elif verbose

Yeah, you are right. Thanks for pointing this out!

@jstac
Copy link
Contributor

jstac commented Sep 1, 2022

Thanks @Smit-create , nice work.

@jstac jstac merged commit 411cd08 into QuantEcon:main Sep 1, 2022
@Smit-create Smit-create deleted the i-176 branch September 1, 2022 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BUG: Scope of index variable in for loop BUG: Correct convergence conditions in function iteration

2 participants

@Smit-create @jstac