Skip to content

Conversation

@mmcky
Copy link
Contributor

@mmcky mmcky commented Nov 24, 2025

Summary

This PR adds comprehensive execution report uploads for all build steps in both the CI and publish workflows to help diagnose execution failures.

Changes

CI Workflow ()

  • ✅ Updated LaTeX execution reports artifact name to execution-reports-latex
  • ✅ Updated HTML execution reports artifact name to execution-reports-html
  • ✅ Already had notebook execution reports as execution-reports-notebooks

Publish Workflow (publish.yml)

  • ✅ Added execution reports upload for LaTeX build step (execution-reports-latex)
  • ✅ Added execution reports upload for Download Notebooks build (execution-reports-notebooks)
  • ✅ Added execution reports upload for HTML build step (execution-reports-html)

Benefits

  • All three build steps (LaTeX PDF, Download Notebooks, HTML) now upload execution reports on failure
  • Unique artifact names prevent conflicts when multiple steps fail
  • Easier debugging of execution errors like the lagrangian_lqdp.md singular matrix error currently on main

Testing

This PR will trigger the CI workflow which will test the updated artifact upload configuration. We can verify:

  1. Execution reports are properly uploaded if any build step fails
  2. Artifact names are unique and don't conflict
  3. The existing execution error in lagrangian_lqdp.md is captured in reports

…rkflows

- Add execution reports upload for LaTeX build step in both ci.yml and publish.yml
- Add execution reports upload for HTML build step in both workflows
- Add execution reports upload for Download Notebooks build in publish.yml
- Use unique artifact names (execution-reports-latex, execution-reports-html, execution-reports-notebooks) to avoid conflicts
- All report uploads trigger on build failure to help diagnose execution errors
@github-actions
Copy link

📖 Netlify Preview Ready!

Preview URL: https://pr-737--sunny-cactus-210e3e.netlify.app (b1d0773)

@mmcky
Copy link
Contributor Author

mmcky commented Nov 24, 2025

@jstac this is reporting green so not entirely sure what the issue is.

This as it is just adding reports to .github workflows -- do you want me to hold off editing any main elements?

@jstac
Copy link
Contributor

jstac commented Nov 24, 2025

@mmcky

Please go ahead and edit files that i'm not touching in my refactor #735

i can rebase at the end

@mmcky mmcky merged commit 96662c4 into main Nov 24, 2025
1 check passed
@mmcky mmcky deleted the fix/execution-reports-upload branch November 24, 2025 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants