Skip to content

Conversation

@nisha617
Copy link
Collaborator

This PR updates the translation in lake_model.md.

@netlify
Copy link

netlify bot commented Oct 13, 2025

Deploy Preview for astonishing-narwhal-a8fc64 ready!

Name Link
🔨 Latest commit 43810d6
🔍 Latest deploy log https://app.netlify.com/projects/astonishing-narwhal-a8fc64/deploys/68ef1554f3882d00090102b1
😎 Deploy Preview https://deploy-preview-84--astonishing-narwhal-a8fc64.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link

github-actions bot commented Oct 13, 2025

@github-actions github-actions bot temporarily deployed to pull request October 13, 2025 12:23 Inactive
@nisha617
Copy link
Collaborator Author

@mmcky @HumphreyYang

There is a figure with English labels in Section 69.5.3, which cannot be changed to the Chinese version directly.

Does it matter?

@mmcky
Copy link
Contributor

mmcky commented Oct 15, 2025

Thanks @nisha617 - it looks like a static file.

If the code isn't readily available in _static/lecture_specific/lake_model then we should open an issue to track.

Otherwise if code is available let's regenerate with updated title.

Screenshot 2025-10-15 at 2 07 17 pm

@HumphreyYang
Copy link
Member

HumphreyYang commented Oct 15, 2025

Hi @nisha617 and @mmcky,

I converted this to be generating using code. I think there is a big change on this lecture in the intermediate series.

Once this is merged, I will try to ask copilot to migrate changes to this repository.

If the code isn't readily available in _static/lecture_specific/lake_model then we should open an issue to track.

Otherwise if code is available let's regenerate with updated title.

I think it's a great suggestions!

@github-actions github-actions bot temporarily deployed to pull request October 15, 2025 03:40 Inactive
@nisha617
Copy link
Collaborator Author

Thanks @mmcky and @HumphreyYang

It looks good and I'll merge it now.

@nisha617 nisha617 merged commit 8da6356 into main Oct 15, 2025
6 checks passed
@nisha617 nisha617 deleted the lake_model branch October 15, 2025 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants