Added accessors for xrange_adaptor members. Made internal methods static and private. #1401
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #1397.
The primary goal of the patch is to add accessors to the 3 members of xrange_adaptor.
A a collateral "damage", I also converted the normalize and get_stepped_range as static private methods. All tests passed:
[==========] 879 tests from 71 test cases ran. (88 ms total)
[ PASSED ] 879 tests.
xtensor-blas tested too.
This is the other possible replacement for PR #1399, whithout any const.
I'm letting you choose which version you prefer !!!