Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow copy text from a post main body. #637

Open
nathanernest opened this issue Dec 4, 2018 · 7 comments

Comments

@nathanernest
Copy link

@nathanernest nathanernest commented Dec 4, 2018

Comments can be coppied with a long press and selecting "copy text" but no such option is available for the main body of text from a post. Would be a great feature to have.

@Efreak

This comment has been minimized.

Copy link

@Efreak Efreak commented Aug 20, 2019

There's a confusingly-labeled 'copy' item when long-pressing the post title, but it only copies the post url, not the contents. This should be renamed 'Copy post URL', or should be configurable in options (choose from url, title, content, or some combination)

To copy text post, reply to post, then long-press the original text in the lower half of the screen to get a selection. This should be available in the main post view as well.

Should meaning these are things the app does not do, but seem like good ideas to me. Shoooood

@MichalFerencsik

This comment has been minimized.

Copy link
Contributor

@MichalFerencsik MichalFerencsik commented Sep 30, 2019

Hi @QuantumBadger , can I work on this issue?

@japanesephundroid

This comment has been minimized.

Copy link

@japanesephundroid japanesephundroid commented Sep 30, 2019

Hi @QuantumBadger , can I work on this issue?

Not QuantumBadger but he has said repeatedly that he welcomes pull requests as he does not have much time for the app now. He just pretty much only looks at pull requests and fixes critical bugs that break the app.

As this seems like a small fix and not a major feature that fundamentally changes the app, I doubt that he would have any objection to it.

@japanesephundroid

This comment has been minimized.

Copy link

@japanesephundroid japanesephundroid commented Oct 1, 2019

Thanks for your reply.
Pitty is that I already prepared change for this. 😌
Nevermind, I will take a look for something else. 🙂

Just submit your change, I don't know what you understood from my reply put he will look at it eventually.

Also, @japanesephundroid, do you think that Issue#667 would be worth to try?

Yes. It's a small change I think.

@QuantumBadger

This comment has been minimized.

Copy link
Owner

@QuantumBadger QuantumBadger commented Oct 1, 2019

@MichalFerencsik Yes, please do feel free to submit a pull request and I'll take a look at it.

@MichalFerencsik

This comment has been minimized.

Copy link
Contributor

@MichalFerencsik MichalFerencsik commented Oct 1, 2019

@japanesephundroid

Thanks for your reply.
Pitty is that I already prepared change for this. 😌
Nevermind, I will take a look for something else. 🙂

Just submit your change, I don't know what you understood from my reply put he will look at it eventually.

Also, @japanesephundroid, do you think that Issue#667 would be worth to try?

Yes. It's a small change I think.

I firstly misunderstood your reply and I thought this change will be missed/ignored.

After re-reading your reply I decided to delete comments, as it differs from what I thought.

Thanks,
Michal

@QuantumBadger

This comment has been minimized.

Copy link
Owner

@QuantumBadger QuantumBadger commented Oct 2, 2019

Thanks for the proposed change @MichalFerencsik, I've left a comment on the PR.

In the meantime, to copy self-text it's possible to long click the post title and select "properties". At the bottom of the properties dialog is the self text, which you can highlight and copy.

QuantumBadger added a commit that referenced this issue Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.