Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adaptive icon #675

Merged
merged 3 commits into from Oct 6, 2019

Conversation

@rileyinman
Copy link
Contributor

commented Aug 14, 2019

Resolves my suggestion in #583 to add the existing icon as an adaptive one barring a new design. I converted the existing "R" logo into an SVG and used that as the icon foreground, with the background being a static color. I also moved the existing icons to @mipmap to follow Android convention. Let me know if you want me to make any changes!

@QuantumBadger

This comment has been minimized.

Copy link
Owner

commented Oct 2, 2019

Hi @rileyinman, very sorry for the delayed response!

This looks good to me. Before I merge this in, please could you add copyright headers to the new XML files? Similar to the one at the top of here:

https://github.com/QuantumBadger/RedReader/blob/master/src/main/res/values/strings.xml

@rileyinman

This comment has been minimized.

Copy link
Contributor Author

commented Oct 4, 2019

Of course! No worries about the delay, I know everyone has a life to live outside code 🙂

@QuantumBadger QuantumBadger merged commit 1288bf8 into QuantumBadger:master Oct 6, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
QuantumBadger added a commit that referenced this pull request Oct 6, 2019
@QuantumBadger

This comment has been minimized.

Copy link
Owner

commented Oct 6, 2019

Thanks! I've merged this in now, and updated the changelog here: 41c0020

I'll also investigate if this has any implications for the alpha (which uses its own icon).

QuantumBadger added a commit that referenced this pull request Oct 6, 2019
@QuantumBadger

This comment has been minimized.

Copy link
Owner

commented Oct 6, 2019

Icon added for the alpha here: b64f4d5

QuantumBadger added a commit that referenced this pull request Oct 6, 2019
@rileyinman rileyinman deleted the rileyinman:adaptive-icon branch Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.