Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue#637: Implement copy to clip body of post #682

Merged
merged 9 commits into from Oct 12, 2019

Conversation

@MichalFerencsik
Copy link
Contributor

MichalFerencsik commented Oct 1, 2019

Issue: #637 Allow copy text from a post main body.

Description: Implement copy of post body to clipboard using OnLongClickListener in CommentListing
activity.

@QuantumBadger

This comment has been minimized.

Copy link
Owner

QuantumBadger commented Oct 2, 2019

Thanks!

Normally when long-clicking in RedReader you'd expect the long-click context menu to appear. I think it might be better to (1) show the context menu when long-clicking (which is what already happens if you long-click the post title, above the post body), and (2) add an item to the context menu called "Copy self-text". This would be more in line with what people expect.

Let me know what you think :)

@MichalFerencsik

This comment has been minimized.

Copy link
Contributor Author

MichalFerencsik commented Oct 5, 2019

Hi @QuantumBadger,

(1) show the context menu when long-clicking (which is what already happens if you long-click the post title, above the post body)
Can we resolve this by opening same dialog when user makes a long click on post itself?

(2) add an item to the context menu called "Copy self-text". This would be more in line with what people expect.
Done, yet it would require migration, and I'm not sure about manifest change

@QuantumBadger

This comment has been minimized.

Copy link
Owner

QuantumBadger commented Oct 6, 2019

Great work, thanks!

This basically looks ready to merge, although I think there's a minor bug -- both "Copy" and "Copy Self-Text" seem to copy the self text? The first one used to copy the URL:

https://github.com/QuantumBadger/RedReader/pull/682/files#diff-efdaf8c90823a78e85dc5c0bf0c4fcfcR471

Can we resolve this by opening same dialog when user makes a long click on post itself?

Yes I think that's the right approach.

Done, yet it would require migration, and I'm not sure about manifest change

Your change looks fine to me, if you have any questions please let me know :)

@MichalFerencsik

This comment has been minimized.

Copy link
Contributor Author

MichalFerencsik commented Oct 7, 2019

I reverted minor bug inserted by copying code due to update of Clipmanager.

Is it ok now?

Thanks,
Michal

@MichalFerencsik MichalFerencsik force-pushed the MichalFerencsik:wip/Issue-637 branch from 26e4931 to c83bee1 Oct 7, 2019
@MichalFerencsik

This comment has been minimized.

Copy link
Contributor Author

MichalFerencsik commented Oct 12, 2019

Hi @QuantumBadger,

have you had time to look at this?

Thanks,
Michal

@QuantumBadger

This comment has been minimized.

Copy link
Owner

QuantumBadger commented Oct 12, 2019

Thanks @MichalFerencsik, it looks fine. Merging in now!

@QuantumBadger QuantumBadger merged commit c5d49e2 into QuantumBadger:master Oct 12, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@QuantumBadger

This comment has been minimized.

Copy link
Owner

QuantumBadger commented Oct 12, 2019

Changelog updated: 3c4ff62 (correct commit this time :))

@MichalFerencsik MichalFerencsik deleted the MichalFerencsik:wip/Issue-637 branch Oct 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.