Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show error and stop loading NSFW subs if NSFW content is disabled #706

Closed

Conversation

@Cguy7777
Copy link
Contributor

Cguy7777 commented Feb 8, 2020

This should make it more obvious what's happening when RedReader won't load NSFW Subreddits. Since there's no point in downloading the data if every post is guaranteed to be blocked, this should also stop requests after getting the Subreddit's info.
Closes #691

@QuantumBadger

This comment has been minimized.

Copy link
Owner

QuantumBadger commented Feb 22, 2020

Thanks! The lack of information was intentional originally, due to Google banning reddit apps for allowing access to NSFW subs:

https://www.androidpolice.com/2012/03/19/reddit-is-fun-gets-banned-from-the-google-play-store-for-sexually-explicit-material-reddit-users-in-an-uproar/

I think that's less of an issue now, and in principle I'm happy to show more information to the user (not sure whether to mention the option in settings though).

@QuantumBadger

This comment has been minimized.

Copy link
Owner

QuantumBadger commented Feb 22, 2020

Now merged, after changing the text a bit. I decided that it's probably safe to mention the settings :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.