Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: QubesOS/qubes-core-admin
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v4.3.23
Choose a base ref
...
head repository: QubesOS/qubes-core-admin
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v4.3.25
Choose a head ref
  • 17 commits
  • 42 files changed
  • 3 contributors

Commits on Mar 16, 2025

  1. ext/pci: get PCI class from libvirt xml

    This goes further in the direction of d2d2ad8 "pci: get device class
    out of libvirt xml".
    marmarek committed Mar 16, 2025
    Configuration menu
    Copy the full SHA
    b06451a View commit details
    Browse the repository at this point in the history
  2. tests: fix invalid device BDF

    PCI device function is just one hex digit.
    marmarek committed Mar 16, 2025
    Configuration menu
    Copy the full SHA
    c020598 View commit details
    Browse the repository at this point in the history
  3. tests: adjust test for unsupported device

    The issue was about device with segment part exceeding 16 bits, which
    technically is not spec compliant. Adjust the test to be about a device
    that was problematic initially.
    
    QubesOS/qubes-issues#6932
    marmarek committed Mar 16, 2025
    Configuration menu
    Copy the full SHA
    f8ffb89 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2025

  1. Configuration menu
    Copy the full SHA
    a1778ad View commit details
    Browse the repository at this point in the history
  2. Introduce RemoteVM class

    fepitre committed Mar 17, 2025
    Configuration menu
    Copy the full SHA
    8e4b769 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2025

  1. tests: fix creating test qrexec services

    Qrexec service file is supposed to be a proper executable. If it's a
    script, it need a shebang. Lacking that, it sometimes will work (qrexec
    does call services via shell in some situations), but is unreliable.
    marmarek committed Apr 13, 2025
    Configuration menu
    Copy the full SHA
    aa6e363 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2025

  1. Configuration menu
    Copy the full SHA
    33c0521 View commit details
    Browse the repository at this point in the history
  2. ext/pci: implement PCI path for device identification

    PCI SBDF may change if _another_ device is added/removed from the
    system. Use PCI device path to avoid this issue. The PCI device path is
    more or less sysfs path, but with bus number behind bridges replaced
    with relative bus number to bridge's secondary bus number. Each
    component of the path is separated with '-', as that is allowed in
    qrexec arguments.
    
    For example device 0000:c1:00.0 behind bridge at 0000:00:08.1 will get
    path 0000_00_08.1-00_00.0 (assuming bridge 0000:00:08.1 has secondary
    bus at 0xc1). Resolving device path requires access to the system's
    sysfs.
    
    As a side effect, this adds also support for multi-segment systems, PCI
    segment is no longer hardcoded to 0000.
    
    PCIDevice object will automatically resolve old device identifiers,
    which partially covers migration path. The other part is converting BDF
    to device path when loading device assignments.
    
    Tests include subset of sysfs from a real system that has multiple
    bridges.
    
    TODO:
    - consider still allowing attaching via SBDF, or otherwise expose function
      to translate SBDF to PCI path (an Admin API call?)
    - fix salt listing/attaching devices to sys-net/sys-usb - depending on
      the above
    
    Fixes QubesOS/qubes-issues#8681
    marmarek committed Apr 14, 2025
    Configuration menu
    Copy the full SHA
    d0ce8a6 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2025

  1. Configuration menu
    Copy the full SHA
    20e3c20 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'pci-path'

    * pci-path:
      doc: document new PCI devices addressing
      ext/pci: implement PCI path for device identification
      Make black happy about qubes/utils.py
      tests: adjust test for unsupported device
      tests: fix invalid device BDF
      ext/pci: get PCI class from libvirt xml
    marmarek committed Apr 16, 2025
    Configuration menu
    Copy the full SHA
    3fe1e6c View commit details
    Browse the repository at this point in the history
  3. Merge remote-tracking branch 'origin/pr/675'

    * origin/pr/675:
      tests: fix creating test qrexec services
    marmarek committed Apr 16, 2025
    Configuration menu
    Copy the full SHA
    91f22f6 View commit details
    Browse the repository at this point in the history
  4. Merge remote-tracking branch 'origin/pr/674'

    * origin/pr/674:
      tests: only close watch fd for LocalVM
    
    Pull request description:
    
    ```
    ======================================================================
    ERROR: qubes.tests.integ.misc/TC_10_RemoteVM_fedora-41-xfce/test_000_full_connect
    ----------------------------------------------------------------------
    Traceback (most recent call last):
      File "/usr/lib/python3.13/site-packages/qubes/tests/__init__.py", line 891, in cleanup_app
        self.remove_test_vms()
        ~~~~~~~~~~~~~~~~~~~~^^
      File "/usr/lib/python3.13/site-packages/qubes/tests/__init__.py", line 1216, in remove_test_vms
        self.remove_vms(
        ~~~~~~~~~~~~~~~^
            [
            ^
        ...<9 lines>...
            ]
            ^
        )
        ^
      File "/usr/lib/python3.13/site-packages/qubes/tests/__init__.py", line 1187, in remove_vms
        self._remove_vm_qubes(vm)
        ~~~~~~~~~~~~~~~~~~~~~^^^^
      File "/usr/lib/python3.13/site-packages/qubes/tests/__init__.py", line 1029, in _remove_vm_qubes
        del app.domains[vm.qid]
            ~~~~~~~~~~~^^^^^^^^
      File "/usr/lib/python3.13/site-packages/qubes/app.py", line 568, in __delitem__
        self.app.fire_event("domain-delete", vm=vm)
        ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^
      File "/usr/lib/python3.13/site-packages/qubes/events.py", line 200, in fire_event
        sync_effects, async_effects = self._fire_event(
                                      ~~~~~~~~~~~~~~~~^
            event, kwargs, pre_event=pre_event
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        )
        ^
      File "/usr/lib/python3.13/site-packages/qubes/events.py", line 169, in _fire_event
        effect = func(self, event, **kwargs)
      File "/usr/lib/python3.13/site-packages/qubes/tests/__init__.py", line 883, in close_qdb_on_remove
        if vm._qdb_connection_watch is not None:
           ^^^^^^^^^^^^^^^^^^^^^^^^
    AttributeError: 'RemoteVM' object has no attribute '_qdb_connection_watch'
    ```
    
    Related to #669.
    marmarek committed Apr 16, 2025
    Configuration menu
    Copy the full SHA
    cb73414 View commit details
    Browse the repository at this point in the history
  5. version 4.3.24

    marmarek committed Apr 16, 2025
    Configuration menu
    Copy the full SHA
    055554e View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2025

  1. Configuration menu
    Copy the full SHA
    70dfcb4 View commit details
    Browse the repository at this point in the history
  2. doc: add qubes.vm.remotevm

    fepitre committed Apr 18, 2025
    Configuration menu
    Copy the full SHA
    3a62a74 View commit details
    Browse the repository at this point in the history
  3. Merge remote-tracking branch 'origin/pr/668'

    * origin/pr/668:
      doc: add qubes.vm.remotevm
      Introduce RelayVM property for RemoteVM
      Introduce RemoteVM class
    
    Pull request description:
    
    QubesOS/qubes-issues/issues/9015
    marmarek committed Apr 18, 2025
    Configuration menu
    Copy the full SHA
    9ba8b4c View commit details
    Browse the repository at this point in the history
  4. version 4.3.25

    marmarek committed Apr 18, 2025
    Configuration menu
    Copy the full SHA
    5644fc0 View commit details
    Browse the repository at this point in the history
Loading