-
-
Notifications
You must be signed in to change notification settings - Fork 116
Comparing changes
Open a pull request
base repository: QubesOS/qubes-core-admin
base: v4.3.23
head repository: QubesOS/qubes-core-admin
compare: v4.3.25
- 17 commits
- 42 files changed
- 3 contributors
Commits on Mar 16, 2025
-
ext/pci: get PCI class from libvirt xml
This goes further in the direction of d2d2ad8 "pci: get device class out of libvirt xml".
Configuration menu - View commit details
-
Copy full SHA for b06451a - Browse repository at this point
Copy the full SHA b06451aView commit details -
PCI device function is just one hex digit.
Configuration menu - View commit details
-
Copy full SHA for c020598 - Browse repository at this point
Copy the full SHA c020598View commit details -
tests: adjust test for unsupported device
The issue was about device with segment part exceeding 16 bits, which technically is not spec compliant. Adjust the test to be about a device that was problematic initially. QubesOS/qubes-issues#6932
Configuration menu - View commit details
-
Copy full SHA for f8ffb89 - Browse repository at this point
Copy the full SHA f8ffb89View commit details
Commits on Mar 17, 2025
-
Configuration menu - View commit details
-
Copy full SHA for a1778ad - Browse repository at this point
Copy the full SHA a1778adView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e4b769 - Browse repository at this point
Copy the full SHA 8e4b769View commit details
Commits on Apr 13, 2025
-
tests: fix creating test qrexec services
Qrexec service file is supposed to be a proper executable. If it's a script, it need a shebang. Lacking that, it sometimes will work (qrexec does call services via shell in some situations), but is unreliable.
Configuration menu - View commit details
-
Copy full SHA for aa6e363 - Browse repository at this point
Copy the full SHA aa6e363View commit details
Commits on Apr 14, 2025
-
Configuration menu - View commit details
-
Copy full SHA for 33c0521 - Browse repository at this point
Copy the full SHA 33c0521View commit details -
ext/pci: implement PCI path for device identification
PCI SBDF may change if _another_ device is added/removed from the system. Use PCI device path to avoid this issue. The PCI device path is more or less sysfs path, but with bus number behind bridges replaced with relative bus number to bridge's secondary bus number. Each component of the path is separated with '-', as that is allowed in qrexec arguments. For example device 0000:c1:00.0 behind bridge at 0000:00:08.1 will get path 0000_00_08.1-00_00.0 (assuming bridge 0000:00:08.1 has secondary bus at 0xc1). Resolving device path requires access to the system's sysfs. As a side effect, this adds also support for multi-segment systems, PCI segment is no longer hardcoded to 0000. PCIDevice object will automatically resolve old device identifiers, which partially covers migration path. The other part is converting BDF to device path when loading device assignments. Tests include subset of sysfs from a real system that has multiple bridges. TODO: - consider still allowing attaching via SBDF, or otherwise expose function to translate SBDF to PCI path (an Admin API call?) - fix salt listing/attaching devices to sys-net/sys-usb - depending on the above Fixes QubesOS/qubes-issues#8681
Configuration menu - View commit details
-
Copy full SHA for d0ce8a6 - Browse repository at this point
Copy the full SHA d0ce8a6View commit details
Commits on Apr 16, 2025
-
Configuration menu - View commit details
-
Copy full SHA for 20e3c20 - Browse repository at this point
Copy the full SHA 20e3c20View commit details -
* pci-path: doc: document new PCI devices addressing ext/pci: implement PCI path for device identification Make black happy about qubes/utils.py tests: adjust test for unsupported device tests: fix invalid device BDF ext/pci: get PCI class from libvirt xml
Configuration menu - View commit details
-
Copy full SHA for 3fe1e6c - Browse repository at this point
Copy the full SHA 3fe1e6cView commit details -
Merge remote-tracking branch 'origin/pr/675'
* origin/pr/675: tests: fix creating test qrexec services
Configuration menu - View commit details
-
Copy full SHA for 91f22f6 - Browse repository at this point
Copy the full SHA 91f22f6View commit details -
Merge remote-tracking branch 'origin/pr/674'
* origin/pr/674: tests: only close watch fd for LocalVM Pull request description: ``` ====================================================================== ERROR: qubes.tests.integ.misc/TC_10_RemoteVM_fedora-41-xfce/test_000_full_connect ---------------------------------------------------------------------- Traceback (most recent call last): File "/usr/lib/python3.13/site-packages/qubes/tests/__init__.py", line 891, in cleanup_app self.remove_test_vms() ~~~~~~~~~~~~~~~~~~~~^^ File "/usr/lib/python3.13/site-packages/qubes/tests/__init__.py", line 1216, in remove_test_vms self.remove_vms( ~~~~~~~~~~~~~~~^ [ ^ ...<9 lines>... ] ^ ) ^ File "/usr/lib/python3.13/site-packages/qubes/tests/__init__.py", line 1187, in remove_vms self._remove_vm_qubes(vm) ~~~~~~~~~~~~~~~~~~~~~^^^^ File "/usr/lib/python3.13/site-packages/qubes/tests/__init__.py", line 1029, in _remove_vm_qubes del app.domains[vm.qid] ~~~~~~~~~~~^^^^^^^^ File "/usr/lib/python3.13/site-packages/qubes/app.py", line 568, in __delitem__ self.app.fire_event("domain-delete", vm=vm) ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib/python3.13/site-packages/qubes/events.py", line 200, in fire_event sync_effects, async_effects = self._fire_event( ~~~~~~~~~~~~~~~~^ event, kwargs, pre_event=pre_event ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ) ^ File "/usr/lib/python3.13/site-packages/qubes/events.py", line 169, in _fire_event effect = func(self, event, **kwargs) File "/usr/lib/python3.13/site-packages/qubes/tests/__init__.py", line 883, in close_qdb_on_remove if vm._qdb_connection_watch is not None: ^^^^^^^^^^^^^^^^^^^^^^^^ AttributeError: 'RemoteVM' object has no attribute '_qdb_connection_watch' ``` Related to #669.Configuration menu - View commit details
-
Copy full SHA for cb73414 - Browse repository at this point
Copy the full SHA cb73414View commit details -
Configuration menu - View commit details
-
Copy full SHA for 055554e - Browse repository at this point
Copy the full SHA 055554eView commit details
Commits on Apr 18, 2025
-
Configuration menu - View commit details
-
Copy full SHA for 70dfcb4 - Browse repository at this point
Copy the full SHA 70dfcb4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a62a74 - Browse repository at this point
Copy the full SHA 3a62a74View commit details -
Merge remote-tracking branch 'origin/pr/668'
* origin/pr/668: doc: add qubes.vm.remotevm Introduce RelayVM property for RemoteVM Introduce RemoteVM class Pull request description: QubesOS/qubes-issues/issues/9015
Configuration menu - View commit details
-
Copy full SHA for 9ba8b4c - Browse repository at this point
Copy the full SHA 9ba8b4cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5644fc0 - Browse repository at this point
Copy the full SHA 5644fc0View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v4.3.23...v4.3.25