-
-
Notifications
You must be signed in to change notification settings - Fork 16
Comparing changes
Open a pull request
base repository: QubesOS/qubes-desktop-linux-menu
base: v1.2.2
head repository: QubesOS/qubes-desktop-linux-menu
compare: v1.2.3
- 10 commits
- 9 files changed
- 3 contributors
Commits on Nov 27, 2024
-
Escape application names for GMarkup
GLib provides a parser called GMarkup, which implements a subset of XML. Application names may contain XML metacharacters, such as "<" and "&". These must be escaped to prevent XML injection, but the app menu didn't do that. The GMarkup documentation explicitly states that GMarkup must not be used to parse untrusted input [1]. Therefore, parsing malicious markup may have undefined results. Fortunately, there is no security problem because the only allowed character with special meaning in XML is "&" and ";" is not allowed. Therefore, there is no way to create a valid XML entity or inject tags. The worst that can happen is the creation of ill-formed markup that that GLib rejects. This patch also addresses a URL construction bug: filenames need to be URL-encoded in file:// URLs. [1]: https://github.com/GNOME/glib/blob/3304a517d9a7bdbb52d60394fdae6f9903f0f4f3/glib/gmarkup.c#L50-L51
Configuration menu - View commit details
-
Copy full SHA for b2e036c - Browse repository at this point
Copy the full SHA b2e036cView commit details
Commits on Nov 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9586eda - Browse repository at this point
Copy the full SHA 9586edaView commit details
Commits on Dec 2, 2024
-
rpm: add explicit depenency on pyxdg
The 'xdg' module is imported, so add it also to dependencies.
Configuration menu - View commit details
-
Copy full SHA for 9ebf2b0 - Browse repository at this point
Copy the full SHA 9ebf2b0View commit details -
debian: add explicit dependency on python3-xdg
The 'xdg' module is imported, so add it also to dependencies.
Configuration menu - View commit details
-
Copy full SHA for fb90f9e - Browse repository at this point
Copy the full SHA fb90f9eView commit details -
ci: depend on python3-pyxdg explicitly
It used to be pulled by something else in the CI environment, but it seems it isn't anymore.
Configuration menu - View commit details
-
Copy full SHA for 745ad2c - Browse repository at this point
Copy the full SHA 745ad2cView commit details
Commits on Dec 7, 2024
-
Wayland support via wlr-layer-shell
This adds Wayland support on compositors that support the wlr-layer-shell protocol, which includes KWin, Sway, COSMIC, niri, Mir, GameScope, and Jay. The only major compositors without support for wlr-layer-shell are Mutter, which is generally only used by GNOME, and Weston, which is not a general-purpose desktop compositor.
Configuration menu - View commit details
-
Copy full SHA for 8d2ebd7 - Browse repository at this point
Copy the full SHA 8d2ebd7View commit details
Commits on Dec 10, 2024
-
Merge remote-tracking branch 'origin/pr/51'
* origin/pr/51: Escape application names for GMarkup
Configuration menu - View commit details
-
Copy full SHA for ce4ffa0 - Browse repository at this point
Copy the full SHA ce4ffa0View commit details
Commits on Dec 17, 2024
-
Merge remote-tracking branch 'origin/pr/54'
* origin/pr/54: ci: depend on python3-pyxdg explicitly debian: add explicit dependency on python3-xdg rpm: add explicit depenency on pyxdg
Configuration menu - View commit details
-
Copy full SHA for 0d50db0 - Browse repository at this point
Copy the full SHA 0d50db0View commit details -
Merge remote-tracking branch 'origin/pr/53'
* origin/pr/53: Wayland support via wlr-layer-shell Pull request description: This is almost completely working under Wayland. To test, use a compositor that supports Layer Shell, such as KWin. KWin can be spawned nested inside an X11 window, such as what Qubes OS provides. Issues: 1. [x] The window is too short: fixed by explicitly setting the menu size every time the window is opened. 2. [x] The configuration options that control where the app menu appears did not work: fixed by explicitly checking for them and anchoring the window to the correct corner 3. [x] Tests code was included in the production script: I moved the test code to my own local branch. 4. [ ] `mouse` mode is interpreted as `bottom-left` (KDE) or `top-left` (otherwise): will be fixed by providing mouse information via IPC. Fixes QubesOS/qubes-issues#9600
Configuration menu - View commit details
-
Copy full SHA for e5b0adc - Browse repository at this point
Copy the full SHA e5b0adcView commit details
Commits on Mar 17, 2025
-
Configuration menu - View commit details
-
Copy full SHA for 9acc13c - Browse repository at this point
Copy the full SHA 9acc13cView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v1.2.2...v1.2.3