New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Sub)sort VMs by name #1022

Closed
andrewdavidwong opened this Issue Jun 4, 2015 · 7 comments

Comments

@andrewdavidwong
Member

andrewdavidwong commented Jun 4, 2015

VMs in Qubes VM Manager should be subsorted alphabetically by VM name by default.

The lists of VMs shown when using qvm-backup should always be sorted alphabetically by VM name.

@andrewdavidwong

This comment has been minimized.

Show comment
Hide comment
@andrewdavidwong

andrewdavidwong Jan 27, 2017

Member

@marmarek: What do you think about dropping the "minor" label for this? Even with search in QM, lack of alphabetical subsorting makes it difficult to visually scan long lists of VMs. More importantly, lack of subsorting removes the user's control over how VMs are subsorted whenever sorting by a column other than "Name."

Member

andrewdavidwong commented Jan 27, 2017

@marmarek: What do you think about dropping the "minor" label for this? Even with search in QM, lack of alphabetical subsorting makes it difficult to visually scan long lists of VMs. More importantly, lack of subsorting removes the user's control over how VMs are subsorted whenever sorting by a column other than "Name."

@marmarek marmarek added P: major and removed P: minor labels Jan 27, 2017

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Jan 27, 2017

Member

👍

Member

marmarek commented Jan 27, 2017

👍

@unman

This comment has been minimized.

Show comment
Hide comment
@unman

unman Jan 29, 2017

Member

It's one of the stranger things in Qt that tables don't readily lend themselves to sorting by more than one key.

Member

unman commented Jan 29, 2017

It's one of the stranger things in Qt that tables don't readily lend themselves to sorting by more than one key.

@unman

This comment has been minimized.

Show comment
Hide comment
@unman

unman Jan 30, 2017

Member

There is a workaround I've used in the past in simple cases like this - populate a hidden column with concatenated strings (SortCol + Name), and sort by that hidden column. Not at all elegant, but trivial to implement and works in current framework.
@marmarek - what do you think?

Member

unman commented Jan 30, 2017

There is a workaround I've used in the past in simple cases like this - populate a hidden column with concatenated strings (SortCol + Name), and sort by that hidden column. Not at all elegant, but trivial to implement and works in current framework.
@marmarek - what do you think?

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Jan 30, 2017

Member

It would be better to have proper sub-sorting by name. For some columns it should be easy - see table_widgets.py - custom widgets do define __lt__ function, which currently fallback to qid comparision in case of values being equal. Actually, I can't find any column not listed there, so maybe adjusting all __lt__ functions there should be enough?

Member

marmarek commented Jan 30, 2017

It would be better to have proper sub-sorting by name. For some columns it should be easy - see table_widgets.py - custom widgets do define __lt__ function, which currently fallback to qid comparision in case of values being equal. Actually, I can't find any column not listed there, so maybe adjusting all __lt__ functions there should be enough?

@unman

This comment has been minimized.

Show comment
Hide comment
@unman

unman Apr 14, 2017

Member

@andrewdavidwong Confirmed issue still arises in 3.2 milestone

Member

unman commented Apr 14, 2017

@andrewdavidwong Confirmed issue still arises in 3.2 milestone

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Jul 18, 2018

Automated announcement from builder-github

The package qubes-manager-4.0.19-1.fc25 has been pushed to the r4.0 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

Automated announcement from builder-github

The package qubes-manager-4.0.19-1.fc25 has been pushed to the r4.0 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

@qubesos-bot qubesos-bot referenced this issue in QubesOS/updates-status Jul 18, 2018

Open

manager v4.0.19 (r4.0) #600

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment