Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upSplit-GPG is incompatible with Tor Birdy #1024
Comments
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
added
the
C: other
label
Jun 9, 2015
marmarek
added
the
help wanted
label
Jun 21, 2015
marmarek
added this to the Far in the future milestone
Oct 9, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Feb 29, 2016
Member
Since there is no much interest from Tor developers, maybe we can simply ignore --keyserver-options in qubes-gpg-client-wrapper? This might have some negative impact if GPG VM is not really offline, but that would be misuse of gpg-split anyway.
cc @adrelanos
|
Since there is no much interest from Tor developers, maybe we can simply ignore cc @adrelanos |
added a commit
to marmarek/qubes-app-linux-split-gpg
that referenced
this issue
Feb 29, 2016
marmarek
referenced this issue
in marmarek/qubes-app-linux-split-gpg
Feb 29, 2016
Merged
Ignore --keyserver-options #1
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
adrelanos
Feb 29, 2016
Member
Marek Marczykowski-Górecki:
Since there is no much interest from Tor developers, maybe we can simply ignore --keyserver-options in qubes-gpg-client-wrapper?
That would be good enough as workaround given current resources, I suppose.
[ The clean solution would be to run the keyserver fetches in the mail
VM since that is supposed to be online. And the
encrypt/decrypt/sign/verify inside the gpg VM. All automagically. So it
does not matter how other applications handle it. ]
|
Marek Marczykowski-Górecki:
That would be good enough as workaround given current resources, I suppose. [ The clean solution would be to run the keyserver fetches in the mail |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Can you look at linked patch, with your bash-expert hat on? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
adrelanos
Feb 29, 2016
Member
|
Probably would cause issues. I am referring to of the most famous bash
hackers. We need a mix of http://mywiki.wooledge.org/WrapperScript and
http://mywiki.wooledge.org/BashFAQ/035.
I can come up with some pseudo code to filter out that command line
parameter.
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
adrelanos
Feb 29, 2016
Member
The problem with args= is, that it can mess up quotes, double quotes and what not. The following has a problem but would be more canonical.
#!/bin/bash
while true; do
case $1 in
--keyserver-options) # Takes an option argument, ensuring it has been specified.
if [ -n "$2" ]; then
shift
else
shift 2
fi
;;
*) # Default case: If no more options then break out of the loop.
break
esac
shift
done
# Rest of the program here.
# If there are input files (for example) that follow the options, they
# will remain in the "$@" positional parameters.
exec qubes-gpg-client "$@"
The problem is, that is only filters out --keyserver-options if it is the first command line parameter. Not if it is somewhere in the middle of the parameters.
|
The problem with
The problem is, that is only filters out |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
adrelanos
Feb 29, 2016
Member
From http://wiki.bash-hackers.org/scripting/posparams please see chapter Filter unwanted options with a wrapper script seems better.
|
From http://wiki.bash-hackers.org/scripting/posparams please see chapter |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
adrelanos
Feb 29, 2016
Member
Based on above, the following is similar to what you came up originally. Pseudo code.
#!/bin/bash
options=() # the buffer array for the parameters
eoo=0 # end of options reached
while [[ $1 ]]
do
if ! ((eoo)); then
case "$1" in
--keyserver-options)
shift 2
;;
-[^-]*a*|-a?*)
options+=("${1//a}")
shift
;;
--)
eoo=1
options+=("$1")
shift
;;
*)
options+=("$1")
shift
;;
esac
else
options+=("$1")
# Another (worse) way of doing the same thing:
# options=("${options[@]}" "$1")
shift
fi
done
exec qubes-gpg-client "${options[@]}"
Can you make head or tail of it? Otherwise I could also a pull request. Obviously useful to run the test suite over it to see if this does not break something but I guess it should work.
|
Based on above, the following is similar to what you came up originally. Pseudo code.
Can you make head or tail of it? Otherwise I could also a pull request. Obviously useful to run the test suite over it to see if this does not break something but I guess it should work. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Feb 29, 2016
Member
Can you make head or tail of it?
Yes, thanks. Will improve the current patch.
Obviously useful to run the test suite over it
That's one reason why I've finally implemented #1368 - in the current shape it pass also on whonix-ws based AppVM. It's doing simple send + receive email.
Yes, thanks. Will improve the current patch.
That's one reason why I've finally implemented #1368 - in the current shape it pass also on whonix-ws based AppVM. It's doing simple send + receive email. |
added a commit
to marmarek/qubes-app-linux-split-gpg
that referenced
this issue
Feb 29, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Pushed updated version |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Looks good. |
marmarek
closed this
in
marmarek/qubes-app-linux-split-gpg#1
Feb 29, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Feb 29, 2016
Member
Automated announcement from builder-github
The package qubes-gpg-split_2.0.18-1+deb8u1 has been pushed to the r3.0 testing repository for the Debian jessie template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing jessie-testing, then use the standard update command:
sudo apt-get update && sudo apt-get dist-upgrade
|
Automated announcement from builder-github The package
|
marmarek
added
the
r3.0-jessie-testing
label
Feb 29, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Feb 29, 2016
Member
Automated announcement from builder-github
The package qubes-gpg-split_2.0.18-1+deb7u1 has been pushed to the r3.0 testing repository for the Debian wheezy template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing wheezy-testing, then use the standard update command:
sudo apt-get update && sudo apt-get dist-upgrade
|
Automated announcement from builder-github The package
|
marmarek
added
the
r3.0-wheezy-testing
label
Feb 29, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Feb 29, 2016
Member
Automated announcement from builder-github
The package qubes-gpg-split-2.0.18-1.fc20 has been pushed to the r3.0 testing repository for the Fedora fc20 template.
To test this update, please install it with the following command:
sudo yum update --enablerepo=qubes-vm-r3.0-current-testing
|
Automated announcement from builder-github The package
|
marmarek
added
the
r3.0-fc20-testing
label
Feb 29, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Feb 29, 2016
Member
Automated announcement from builder-github
The package qubes-gpg-split-2.0.18-1.fc21 has been pushed to the r3.0 testing repository for the Fedora fc21 template.
To test this update, please install it with the following command:
sudo yum update --enablerepo=qubes-vm-r3.0-current-testing
|
Automated announcement from builder-github The package
|
marmarek
added
the
r3.0-fc21-testing
label
Feb 29, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Feb 29, 2016
Member
Automated announcement from builder-github
The package qubes-gpg-split-2.0.18-1.fc22 has been pushed to the r3.0 testing repository for the Fedora fc22 template.
To test this update, please install it with the following command:
sudo yum update --enablerepo=qubes-vm-r3.0-current-testing
|
Automated announcement from builder-github The package
|
marmarek
added
the
r3.0-fc22-testing
label
Feb 29, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Feb 29, 2016
Member
Automated announcement from builder-github
The package qubes-gpg-split-2.0.18-1.fc23 has been pushed to the r3.0 testing repository for the Fedora fc23 template.
To test this update, please install it with the following command:
sudo yum update --enablerepo=qubes-vm-r3.0-current-testing
|
Automated announcement from builder-github The package
|
marmarek
added
the
r3.0-fc23-testing
label
Feb 29, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Feb 29, 2016
Member
Automated announcement from builder-github
The package qubes-gpg-split-dom0-2.0.18-1.fc20 has been pushed to the r3.0 testing repository for dom0.
To test this update, please install it with the following command:
sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing
|
Automated announcement from builder-github The package
|
marmarek
added
the
r3.0-dom0-testing
label
Feb 29, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Mar 7, 2016
Member
Automated announcement from builder-github
The package qubes-gpg-split-2.0.18-1.fc21 has been pushed to the r3.1 testing repository for the Fedora fc21 template.
To test this update, please install it with the following command:
sudo yum update --enablerepo=qubes-vm-r3.1-current-testing
|
Automated announcement from builder-github The package
|
marmarek
added
the
r3.1-fc21-cur-test
label
Mar 7, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Mar 7, 2016
Member
Automated announcement from builder-github
The package qubes-gpg-split-2.0.18-1.fc22 has been pushed to the r3.1 testing repository for the Fedora fc22 template.
To test this update, please install it with the following command:
sudo yum update --enablerepo=qubes-vm-r3.1-current-testing
|
Automated announcement from builder-github The package
|
marmarek
added
the
r3.1-fc22-cur-test
label
Mar 7, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Mar 7, 2016
Member
Automated announcement from builder-github
The package qubes-gpg-split-2.0.18-1.fc23 has been pushed to the r3.1 testing repository for the Fedora fc23 template.
To test this update, please install it with the following command:
sudo yum update --enablerepo=qubes-vm-r3.1-current-testing
|
Automated announcement from builder-github The package
|
marmarek
added
the
r3.1-fc23-cur-test
label
Mar 7, 2016
marmarek
added
the
r3.1-dom0-stable
label
Mar 13, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
andrewdavidwong
Mar 13, 2016
Member
I'm afraid this still doesn't appear to be working.
I've tried testing with a whonix-ws-based AppVM (with TorBirdy enabled), where the GPG backend domain is based on fedora-23 with the latest qubes-gpg-split-2.0.18-1.fc23 package.
- Opening a PGP-signed email does not visibly interact with GPG or Enigmail at all. It just shows the signature as plain text (for in-line signed messages).
- PGP-encrypted emails display as completely blank (not even the ciphertext is shown unless you view source).
- Attempting to send a PGP-signed email results in:
Enigmail Alert: Send operation aborted. Error - encryption command failed - Running
qubes-gpg-clientfrom the command line in thewhonix-ws-based AppVM works as before. For example, passing-Kstill lists private keys in the backed domain.
|
I'm afraid this still doesn't appear to be working. I've tried testing with a
|
andrewdavidwong
reopened this
Mar 13, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Mar 13, 2016
Member
Automated announcement from builder-github
The package qubes-gpg-split_2.0.18-1+deb8u1 has been pushed to the r3.1 stable repository for the Debian jessie template.
To install this update, please use the standard update command:
sudo apt-get update && sudo apt-get dist-upgrade
|
Automated announcement from builder-github The package
|
marmarek
added
r3.1-jessie-stable
and removed
r3.1-jessie-cur-test
labels
Mar 13, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Mar 13, 2016
Member
The fix is in frontend package, so you need to update package in whonix-ws. As you can see, package for Debian is still in testing repo (just pushed to stable for R3.1)
|
The fix is in frontend package, so you need to update package in whonix-ws. As you can see, package for Debian is still in testing repo (just pushed to stable for R3.1) |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Mar 13, 2016
Member
Automated announcement from builder-github
The package qubes-gpg-split_2.0.18-1+deb9u1 has been pushed to the r3.1 stable repository for the Debian stretch template.
To install this update, please use the standard update command:
sudo apt-get update && sudo apt-get dist-upgrade
|
Automated announcement from builder-github The package
|
marmarek
added
r3.1-stretch-stable
and removed
r3.1-stretch-cur-test
labels
Mar 13, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Mar 13, 2016
Member
Automated announcement from builder-github
The package qubes-gpg-split_2.0.18-1+deb7u1 has been pushed to the r3.1 stable repository for the Debian wheezy template.
To install this update, please use the standard update command:
sudo apt-get update && sudo apt-get dist-upgrade
|
Automated announcement from builder-github The package
|
marmarek
added
r3.1-wheezy-stable
and removed
r3.1-wheezy-cur-test
labels
Mar 13, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
andrewdavidwong
Mar 13, 2016
Member
Maybe it's just a problem with my key, but it keeps popping up a pinentry box (in the backend domain) to enter a passphrase for the key, even though the key has no passphrase. If I just hit enter, it fails to decrypt messages, claiming that no secret key is available.
|
Maybe it's just a problem with my key, but it keeps popping up a pinentry box (in the backend domain) to enter a passphrase for the key, even though the key has no passphrase. If I just hit enter, it fails to decrypt messages, claiming that no secret key is available. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
andrewdavidwong
Mar 13, 2016
Member
I did some further testing, making sure to use a full key with no passphrase in the backend. The pinentry popup still occurs on encryption/decryption attempts, so I'm pretty certain it's not just a problem with my key. (Verifying signed emails works fine now, though.) I also don't think it's a general GPG bug, since the same thing still does not happen with non-TorBirdy Thunderbird.
|
I did some further testing, making sure to use a full key with no passphrase in the backend. The pinentry popup still occurs on encryption/decryption attempts, so I'm pretty certain it's not just a problem with my key. (Verifying signed emails works fine now, though.) I also don't think it's a general GPG bug, since the same thing still does not happen with non-TorBirdy Thunderbird. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Mar 13, 2016
Member
Automated announcement from builder-github
The package qubes-gpg-split-2.0.18-1.fc20 has been pushed to the r3.0 stable repository for the Fedora fc20 template.
To install this update, please use the standard update command:
sudo yum update
|
Automated announcement from builder-github The package
|
marmarek
added
r3.0-fc20-stable
and removed
r3.0-fc20-testing
labels
Mar 13, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Mar 13, 2016
Member
Automated announcement from builder-github
The package qubes-gpg-split-2.0.18-1.fc21 has been pushed to the r3.0 stable repository for the Fedora fc21 template.
To install this update, please use the standard update command:
sudo yum update
|
Automated announcement from builder-github The package
|
marmarek
added
r3.0-fc21-stable
and removed
r3.0-fc21-testing
labels
Mar 13, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Mar 13, 2016
Member
Automated announcement from builder-github
The package qubes-gpg-split-2.0.18-1.fc22 has been pushed to the r3.0 stable repository for the Fedora fc22 template.
To install this update, please use the standard update command:
sudo yum update
|
Automated announcement from builder-github The package
|
marmarek
added
r3.0-fc22-stable
and removed
r3.0-fc22-testing
labels
Mar 13, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Mar 13, 2016
Member
Automated announcement from builder-github
The package qubes-gpg-split-2.0.18-1.fc23 has been pushed to the r3.0 stable repository for the Fedora fc23 template.
To install this update, please use the standard update command:
sudo yum update
|
Automated announcement from builder-github The package
|
marmarek
added
r3.0-fc23-stable
and removed
r3.0-fc23-testing
labels
Mar 13, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Mar 13, 2016
Member
Automated announcement from builder-github
The package qubes-gpg-split-dom0-2.0.18-1.fc20 has been pushed to the r3.0 stable repository for dom0.
To install this update, please use the standard update command:
sudo qubes-dom0-update
Or update dom0 via Qubes Manager.
|
Automated announcement from builder-github The package
Or update dom0 via Qubes Manager. |
marmarek
added
r3.0-dom0-stable
and removed
r3.0-dom0-testing
labels
Mar 13, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Mar 13, 2016
Member
Automated announcement from builder-github
The package qubes-gpg-split_2.0.18-1+deb8u1 has been pushed to the r3.0 stable repository for the Debian jessie template.
To install this update, please use the standard update command:
sudo apt-get update && sudo apt-get dist-upgrade
|
Automated announcement from builder-github The package
|
marmarek
added
r3.0-jessie-stable
and removed
r3.0-jessie-testing
labels
Mar 13, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Mar 13, 2016
Member
Automated announcement from builder-github
The package qubes-gpg-split_2.0.18-1+deb7u1 has been pushed to the r3.0 stable repository for the Debian wheezy template.
To install this update, please use the standard update command:
sudo apt-get update && sudo apt-get dist-upgrade
|
Automated announcement from builder-github The package
|
marmarek
added
r3.0-wheezy-stable
and removed
r3.0-wheezy-testing
labels
Mar 13, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Mar 14, 2016
Member
If the pinentry pops up in the backend domain, this is some different problem. This ticket is the one where the command doesn't even reach backend domain. Please open new one, and check enigmail logs for exact gpg command line.
|
If the pinentry pops up in the backend domain, this is some different problem. This ticket is the one where the command doesn't even reach backend domain. Please open new one, and check enigmail logs for exact gpg command line. |
marmarek
closed this
Mar 14, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
andrewdavidwong
Mar 14, 2016
Member
Ah, I figured out the problem. gpg2 keeps secret keys on a separate keyring from gpg. I had removed the passphrase using gpg, but since Split-GPG uses gpg2, I had to do it again.
|
Ah, I figured out the problem. |
andrewdavidwong commentedJun 4, 2015
Attempting to use Split-GPG and Tor Birdy at the same time results in no GPG notifications in Thunderbird at all when viewing signed or encrypted messages.