Split-GPG is incompatible with Tor Birdy

[andrewdavidwong]

Attempting to use Split-GPG and Tor Birdy at the same time results in no GPG notifications in Thunderbird at all when viewing signed or encrypted messages.

[qjoo]

see also:
https://groups.google.com/d/msg/qubes-users/64Pk_1U9FMU/-uj8qZ7787sJ
https://trac.torproject.org/projects/tor/ticket/14025

[mfc]

also: https://trac.torproject.org/projects/tor/ticket/16935

[marmarek]

Since there is no much interest from Tor developers, maybe we can simply ignore --keyserver-options in qubes-gpg-client-wrapper? This might have some negative impact if GPG VM is not really offline, but that would be misuse of gpg-split anyway.

cc @adrelanos

[adrelanos]

Marek Marczykowski-Górecki:

Since there is no much interest from Tor developers, maybe we can simply ignore --keyserver-options in qubes-gpg-client-wrapper?

That would be good enough as workaround given current resources, I suppose.

[ The clean solution would be to run the keyserver fetches in the mail
VM since that is supposed to be online. And the
encrypt/decrypt/sign/verify inside the gpg VM. All automagically. So it
does not matter how other applications handle it. ]

[marmarek]

Can you look at linked patch, with your bash-expert hat on?

[adrelanos]

Probably would cause issues. I am referring to of the most famous bash hackers. We need a mix of http://mywiki.wooledge.org/WrapperScript and http://mywiki.wooledge.org/BashFAQ/035. I can come up with some pseudo code to filter out that command line parameter.

[adrelanos]

The problem with args= is, that it can mess up quotes, double quotes and what not. The following has a problem but would be more canonical.

#!/bin/bash

while true; do
    case $1 in
        --keyserver-options)       # Takes an option argument, ensuring it has been specified.
            if [ -n "$2" ]; then
                shift
            else
                shift 2
            fi
            ;;
        *)               # Default case: If no more options then break out of the loop.
            break
    esac

    shift
done

# Rest of the program here.
# If there are input files (for example) that follow the options, they
# will remain in the "$@" positional parameters.

exec qubes-gpg-client "$@"

The problem is, that is only filters out --keyserver-options if it is the first command line parameter. Not if it is somewhere in the middle of the parameters.

[adrelanos]

From http://wiki.bash-hackers.org/scripting/posparams please see chapter Filter unwanted options with a wrapper script seems better.

[adrelanos]

Based on above, the following is similar to what you came up originally. Pseudo code.

#!/bin/bash

options=()  # the buffer array for the parameters
eoo=0       # end of options reached

while [[ $1 ]]
do
    if ! ((eoo)); then
    case "$1" in
          --keyserver-options)
            shift 2
            ;;
      -[^-]*a*|-a?*)
          options+=("${1//a}")
          shift
          ;;
      --)
          eoo=1
          options+=("$1")
          shift
          ;;
      *)
          options+=("$1")
          shift
          ;;
    esac
    else
    options+=("$1")

    # Another (worse) way of doing the same thing:
    # options=("${options[@]}" "$1")
    shift
    fi
done

exec qubes-gpg-client "${options[@]}"

Can you make head or tail of it? Otherwise I could also a pull request. Obviously useful to run the test suite over it to see if this does not break something but I guess it should work.

[marmarek]

Can you make head or tail of it?

Yes, thanks. Will improve the current patch.

Obviously useful to run the test suite over it

That's one reason why I've finally implemented #1368 - in the current shape it pass also on whonix-ws based AppVM. It's doing simple send + receive email.

[marmarek]

Pushed updated version

[adrelanos]

Looks good.

[marmarek]

Automated announcement from builder-github

The package qubes-gpg-split_2.0.18-1+deb8u1 has been pushed to the r3.0 testing repository for the Debian jessie template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing jessie-testing, then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

[marmarek]

Automated announcement from builder-github

The package qubes-gpg-split_2.0.18-1+deb7u1 has been pushed to the r3.0 testing repository for the Debian wheezy template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing wheezy-testing, then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

[marmarek]

Automated announcement from builder-github

The package qubes-gpg-split-2.0.18-1.fc20 has been pushed to the r3.0 testing repository for the Fedora fc20 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r3.0-current-testing

Changes included in this update

[marmarek]

Automated announcement from builder-github

The package qubes-gpg-split-2.0.18-1.fc21 has been pushed to the r3.0 testing repository for the Fedora fc21 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r3.0-current-testing

Changes included in this update

[marmarek]

Automated announcement from builder-github

The package qubes-gpg-split-2.0.18-1.fc22 has been pushed to the r3.0 testing repository for the Fedora fc22 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r3.0-current-testing

Changes included in this update

[marmarek]

Automated announcement from builder-github

The package qubes-gpg-split_2.0.18-1+deb7u1 has been pushed to the r3.1 stable repository for the Debian wheezy template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

[andrewdavidwong]

Maybe it's just a problem with my key, but it keeps popping up a pinentry box (in the backend domain) to enter a passphrase for the key, even though the key has no passphrase. If I just hit enter, it fails to decrypt messages, claiming that no secret key is available.

[andrewdavidwong]

I did some further testing, making sure to use a full key with no passphrase in the backend. The pinentry popup still occurs on encryption/decryption attempts, so I'm pretty certain it's not just a problem with my key. (Verifying signed emails works fine now, though.) I also don't think it's a general GPG bug, since the same thing still does not happen with non-TorBirdy Thunderbird.

[marmarek]

Automated announcement from builder-github

The package qubes-gpg-split-2.0.18-1.fc20 has been pushed to the r3.0 stable repository for the Fedora fc20 template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

[marmarek]

Automated announcement from builder-github

The package qubes-gpg-split-2.0.18-1.fc21 has been pushed to the r3.0 stable repository for the Fedora fc21 template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

[marmarek]

Automated announcement from builder-github

The package qubes-gpg-split-2.0.18-1.fc22 has been pushed to the r3.0 stable repository for the Fedora fc22 template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

[marmarek]

Automated announcement from builder-github

The package qubes-gpg-split-2.0.18-1.fc23 has been pushed to the r3.0 stable repository for the Fedora fc23 template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

[marmarek]

Automated announcement from builder-github

The package qubes-gpg-split-dom0-2.0.18-1.fc20 has been pushed to the r3.0 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

[marmarek]

Automated announcement from builder-github

The package qubes-gpg-split_2.0.18-1+deb8u1 has been pushed to the r3.0 stable repository for the Debian jessie template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

[marmarek]

Automated announcement from builder-github

The package qubes-gpg-split_2.0.18-1+deb7u1 has been pushed to the r3.0 stable repository for the Debian wheezy template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

[marmarek]

If the pinentry pops up in the backend domain, this is some different problem. This ticket is the one where the command doesn't even reach backend domain. Please open new one, and check enigmail logs for exact gpg command line.

[andrewdavidwong]

Ah, I figured out the problem. gpg2 keeps secret keys on a separate keyring from gpg. I had removed the passphrase using gpg, but since Split-GPG uses gpg2, I had to do it again.