New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debian Template: cannot add KDE Konsole to dom0 app menu #1062

Closed
adrelanos opened this Issue Jul 14, 2015 · 3 comments

Comments

Projects
None yet
2 participants
@adrelanos
Member

adrelanos commented Jul 14, 2015

Under "add more shortcuts", KDE konsole (https://packages.debian.org/jessie/konsole) is not offered for being added. Neither the term "Konsole" nor "terminal" is in that list.

Starting 'konsole' from 'Run command in VM' however is functional.

@adrelanos adrelanos changed the title from cannot add KDE Konsole to Debian template based VMs dom0 app menu to Debian Template: cannot add KDE Konsole to dom0 app menu Jul 14, 2015

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Jul 18, 2015

Member

It is available as "Open a New Window"...
This is because konsole.desktop defines additional actions and this one
is the last one, so its name is used. Our desktop file parser have
support for that using simple awk script, but apparently Debian mawk
does not support "nextfile" function, so additional actions are not
skipped. This is apparently GNU AWK extension.
Can we require gawk to be installed? It would be possible to have the
script compatible with mawk, but it will be much more complex.

Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?

Member

marmarek commented Jul 18, 2015

It is available as "Open a New Window"...
This is because konsole.desktop defines additional actions and this one
is the last one, so its name is used. Our desktop file parser have
support for that using simple awk script, but apparently Debian mawk
does not support "nextfile" function, so additional actions are not
skipped. This is apparently GNU AWK extension.
Can we require gawk to be installed? It would be possible to have the
script compatible with mawk, but it will be much more complex.

Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Jul 18, 2015

Member

Ok, maybe not "much more complex". We can simply process one file at a
time... This of course means somehow worse performance (multiple calls
to awk instead of just one), but probably negligible.

Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?

Member

marmarek commented Jul 18, 2015

Ok, maybe not "much more complex". We can simply process one file at a
time... This of course means somehow worse performance (multiple calls
to awk instead of just one), but probably negligible.

Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?

@adrelanos

This comment has been minimized.

Show comment
Hide comment
@adrelanos

adrelanos Jul 18, 2015

Member
Member

adrelanos commented Jul 18, 2015

@marmarek marmarek added this to the Release 3.0 milestone Aug 6, 2015

marmarek added a commit to marmarek/old-qubes-core-agent-linux that referenced this issue Sep 29, 2015

debian: depend on gawk
qubes.GetAppmenus uses "nextfile" which is gawk-specific.

Fixes QubesOS/qubes-issues#1062

(cherry picked from commit d491ade)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment