qubes-linux-template-builder: templates.spec - error handling issue

[adrelanos]

There might be an issue with error handling with qubes-linux-template-builder templates.spec. With the following code block:
https://github.com/QubesOS/qubes-linux-template-builder/blob/5a2b7a40003f839bcd67dd26011cda6828caaae7/templates.spec#L35-L39
(Likely a more general problem.)

See the relevant log.

+ tar --sparse --dereference -cf - root.img
+ split -d -b 1G - root.img.part.
split: root.img.part.00: No space left on device
error: Bad exit status from /home/user/qubes-builder/qubes-src/linux-template-builder/rpmbuild/tmp/rpm-tmp.DEy85g (%build)


RPM build errors:
    Bad exit status from /home/user/qubes-builder/qubes-src/linux-template-builder/rpmbuild/tmp/rpm-tmp.DEy85g (%build)
Use the following command in DOM0 to retreive this file:
qvm-run --pass-io qubes-build 'cat /home/user/qubes-builder/qubes-src/linux-template-builder/rpm/install-templates.sh' > install-templates.sh
[user@qubes-build qubes-builder]$ echo $?
0

In this very case, too low disk space. My mistake.

The code issue here is, that the build continued, didn't error and exited zero. Any idea how it could be fixed? (How is templates.spec called?)