New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do no restore (some of) the Dom0 home dir on backup restore #1106

Closed
rootkovska opened this Issue Aug 6, 2015 · 5 comments

Comments

3 participants
@rootkovska
Member

rootkovska commented Aug 6, 2015

When the user wants to restore only a subset of his or her VMs, but decides to restore also the Dom0 home dir (the default option suggested by the Qubes Manager and qvm-backup-restore), then this will also bring ~/.local/share/{applications,desktop-directories} content, which itself contains all the appmenus the user had while making the backup. This will result in creation of extra appmenus, not backed up by real AppVMs. Very annoying to remove them manually later on, which should be done using:

xdg-desktop-menu uninstall ~/.local/share/desktop-directories/xyz.directory ~/.local/share/applications/xyz*
@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Feb 26, 2016

Member

One problem with excluding those directories completely - it will also exclude user-created menu entries. For example I have additional entries for DispVMs (other browsers mostly). Some people create entries for applications without proper desktop file, etc.
Maybe it should be some smart exclude to still include user-created entries? Or simply optional feature (enabled by default) to exclude those entries during restore (but keep then in the backup). Then if user want to restore any custom entries, he/she would also need to possibly delete unwanted ones manually (as you've done).

Member

marmarek commented Feb 26, 2016

One problem with excluding those directories completely - it will also exclude user-created menu entries. For example I have additional entries for DispVMs (other browsers mostly). Some people create entries for applications without proper desktop file, etc.
Maybe it should be some smart exclude to still include user-created entries? Or simply optional feature (enabled by default) to exclude those entries during restore (but keep then in the backup). Then if user want to restore any custom entries, he/she would also need to possibly delete unwanted ones manually (as you've done).

@rootkovska

This comment has been minimized.

Show comment
Hide comment
@rootkovska

rootkovska Feb 26, 2016

Member

Given how the appmenu restore process has always left me with broken appmenus, I would consider this a big advantage, actually. Seriously.

Member

rootkovska commented Feb 26, 2016

Given how the appmenu restore process has always left me with broken appmenus, I would consider this a big advantage, actually. Seriously.

@rootkovska

This comment has been minimized.

Show comment
Hide comment
@rootkovska

rootkovska Jun 27, 2016

Member

I vote for just excluding the .local/share/{applications,desktop-directories} by default. Given that majority of users would not make custom menu entries, this seems like a reasonable decision, to make sure that the majority of the users would not get screwed appmenus after restore.

Member

rootkovska commented Jun 27, 2016

I vote for just excluding the .local/share/{applications,desktop-directories} by default. Given that majority of users would not make custom menu entries, this seems like a reasonable decision, to make sure that the majority of the users would not get screwed appmenus after restore.

@andrewdavidwong

This comment has been minimized.

Show comment
Hide comment
Member

andrewdavidwong commented Jan 14, 2017

Related: #2271

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Feb 27, 2018

Member

Since #2271 is implemented, this is fixed too.

Member

marmarek commented Feb 27, 2018

Since #2271 is implemented, this is fixed too.

@marmarek marmarek closed this Feb 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment