Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do no restore (some of) the Dom0 home dir on backup restore #1106

Closed
rootkovska opened this issue Aug 6, 2015 · 5 comments
Closed

Do no restore (some of) the Dom0 home dir on backup restore #1106

rootkovska opened this issue Aug 6, 2015 · 5 comments
Labels
C: core C: manager/widget P: major Priority: major. Between "default" and "critical" in severity. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.

Comments

@rootkovska
Copy link
Member

When the user wants to restore only a subset of his or her VMs, but decides to restore also the Dom0 home dir (the default option suggested by the Qubes Manager and qvm-backup-restore), then this will also bring ~/.local/share/{applications,desktop-directories} content, which itself contains all the appmenus the user had while making the backup. This will result in creation of extra appmenus, not backed up by real AppVMs. Very annoying to remove them manually later on, which should be done using:

xdg-desktop-menu uninstall ~/.local/share/desktop-directories/xyz.directory ~/.local/share/applications/xyz*
@rootkovska rootkovska added T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists. C: core C: manager/widget P: minor Priority: minor. The lowest priority, below "default." labels Aug 6, 2015
@rootkovska rootkovska added this to the Release 3.0 milestone Aug 6, 2015
@marmarek marmarek modified the milestones: Release 3.1, Release 3.0 Sep 2, 2015
@rootkovska rootkovska added P: major Priority: major. Between "default" and "critical" in severity. and removed P: minor Priority: minor. The lowest priority, below "default." labels Jan 15, 2016
@marmarek
Copy link
Member

One problem with excluding those directories completely - it will also exclude user-created menu entries. For example I have additional entries for DispVMs (other browsers mostly). Some people create entries for applications without proper desktop file, etc.
Maybe it should be some smart exclude to still include user-created entries? Or simply optional feature (enabled by default) to exclude those entries during restore (but keep then in the backup). Then if user want to restore any custom entries, he/she would also need to possibly delete unwanted ones manually (as you've done).

@rootkovska
Copy link
Member Author

Given how the appmenu restore process has always left me with broken appmenus, I would consider this a big advantage, actually. Seriously.

@rootkovska
Copy link
Member Author

I vote for just excluding the .local/share/{applications,desktop-directories} by default. Given that majority of users would not make custom menu entries, this seems like a reasonable decision, to make sure that the majority of the users would not get screwed appmenus after restore.

@andrewdavidwong
Copy link
Member

Related: #2271

@marmarek
Copy link
Member

Since #2271 is implemented, this is fixed too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: core C: manager/widget P: major Priority: major. Between "default" and "critical" in severity. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.
Projects
Development

No branches or pull requests

3 participants