New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn Auto File Previews off by default in Debian / Whonix templates #1108

Closed
powerpeep opened this Issue Aug 7, 2015 · 17 comments

Comments

Projects
None yet
6 participants
@powerpeep

https://www.whonix.org/forum/index.php/topic,1492.0.html

Qubes Fedora templates has auto file preview off by default in the file manager to stop random files or downloads from being able to exploit parsing vulnerabilities here.

The Debian / Whonix templates have this on by default. So it shows thumbnails of images and more in the file manager's icons.

For security, could this preview feature please be turned off by default in future releases?

@adrelanos

This comment has been minimized.

Show comment
Hide comment
@adrelanos

adrelanos Aug 7, 2015

Member

I guess Qubes does not influence Debian's defaults at present. Would speculate, that Fedora has just different defaults. Just now checked, in a jessie template and dolphin, preview is not enabled by default. In nautilus however I can confirm it is enabled by default. This undermines the security benefit by the right click action "Open in DisposableVM".

Member

adrelanos commented Aug 7, 2015

I guess Qubes does not influence Debian's defaults at present. Would speculate, that Fedora has just different defaults. Just now checked, in a jessie template and dolphin, preview is not enabled by default. In nautilus however I can confirm it is enabled by default. This undermines the security benefit by the right click action "Open in DisposableVM".

@adrelanos

This comment has been minimized.

Show comment
Hide comment
@adrelanos

adrelanos Aug 7, 2015

Member

Correction, it's also enabled in dolphin. Quote powerpeep.

Settings => Configure Dolphin => General => Previews
Directories: Checked
Images (GIF, PNG, BMP, ...): Checked
JPEG Images: Checked
JPEG: Rotate the image automatically: Checked

Member

adrelanos commented Aug 7, 2015

Correction, it's also enabled in dolphin. Quote powerpeep.

Settings => Configure Dolphin => General => Previews
Directories: Checked
Images (GIF, PNG, BMP, ...): Checked
JPEG Images: Checked
JPEG: Rotate the image automatically: Checked

@adrelanos

This comment has been minimized.

Show comment
Hide comment
@adrelanos

adrelanos Aug 7, 2015

Member

I have some experience with changing distribution defaults for KDE applications. There is a number of packages, where we at Whonix change these settings:
https://github.com/Whonix?utf8=%E2%9C%93&query=kde-

If you want, I could create a kde-dolphin-security-settings package.

Dunno about nautilus. Configuration of Gnome packages is more cumbersome. I could try this as well. Would be a more time intense task.

Member

adrelanos commented Aug 7, 2015

I have some experience with changing distribution defaults for KDE applications. There is a number of packages, where we at Whonix change these settings:
https://github.com/Whonix?utf8=%E2%9C%93&query=kde-

If you want, I could create a kde-dolphin-security-settings package.

Dunno about nautilus. Configuration of Gnome packages is more cumbersome. I could try this as well. Would be a more time intense task.

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Sep 2, 2015

Member

Generally good idea. @adrelanos if you know how to do it, feel free to take this ticket :)

Member

marmarek commented Sep 2, 2015

Generally good idea. @adrelanos if you know how to do it, feel free to take this ticket :)

@adrelanos

This comment has been minimized.

Show comment
Hide comment
@adrelanos

adrelanos Sep 2, 2015

Member

Will do. Start with configuration of dolphin. Will call that package security-misc where we can aggregate similar settings.

Are you okay with the packages implemented in the following style:
https://github.com/Whonix?utf8=%E2%9C%93&query=kde- ? As a specific example you could take for example https://github.com/Whonix/kde-sounds-off. I.e. a simple genmkfile based settings package.

Member

adrelanos commented Sep 2, 2015

Will do. Start with configuration of dolphin. Will call that package security-misc where we can aggregate similar settings.

Are you okay with the packages implemented in the following style:
https://github.com/Whonix?utf8=%E2%9C%93&query=kde- ? As a specific example you could take for example https://github.com/Whonix/kde-sounds-off. I.e. a simple genmkfile based settings package.

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Sep 2, 2015

Member

On Wed, Sep 02, 2015 at 02:41:30AM -0700, Patrick Schleizer wrote:

Will do. Start with configuration of dolphin. Will call that package security-misc where we can aggregate similar settings.

Are you okay with the packages implemented in the following style:
https://github.com/Whonix?utf8=%E2%9C%93&query=kde- ? As a specific example you could take for example https://github.com/Whonix/kde-sounds-off. I.e. a simple genmkfile based settings package.

Currently we place such things (configuration of template stuff) in
core-agent-linux package, but I'm ok with creating new one.

Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?

Member

marmarek commented Sep 2, 2015

On Wed, Sep 02, 2015 at 02:41:30AM -0700, Patrick Schleizer wrote:

Will do. Start with configuration of dolphin. Will call that package security-misc where we can aggregate similar settings.

Are you okay with the packages implemented in the following style:
https://github.com/Whonix?utf8=%E2%9C%93&query=kde- ? As a specific example you could take for example https://github.com/Whonix/kde-sounds-off. I.e. a simple genmkfile based settings package.

Currently we place such things (configuration of template stuff) in
core-agent-linux package, but I'm ok with creating new one.

Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?

@adrelanos

This comment has been minimized.

Show comment
Hide comment
Member

adrelanos commented Oct 15, 2015

@adrelanos

This comment has been minimized.

Show comment
Hide comment
@adrelanos

adrelanos Nov 22, 2016

Member

I still intent another try figuring this out for nautilus... https://phabricator.whonix.org/T500

But if someone else wanted to help out, please do.

Member

adrelanos commented Nov 22, 2016

I still intent another try figuring this out for nautilus... https://phabricator.whonix.org/T500

But if someone else wanted to help out, please do.

@adrelanos

This comment has been minimized.

Show comment
Hide comment
@adrelanos

adrelanos Nov 27, 2016

Member

@andrewdavidwong:

File previews in the Fedora templates have been disabled for a long time now.

Is this a Fedora or Qubes feature? Where is that implemented?

(I am asking, because then implementing this ticket would be a lot simpler.)

Member

adrelanos commented Nov 27, 2016

@andrewdavidwong:

File previews in the Fedora templates have been disabled for a long time now.

Is this a Fedora or Qubes feature? Where is that implemented?

(I am asking, because then implementing this ticket would be a lot simpler.)

@andrewdavidwong

This comment has been minimized.

Show comment
Hide comment
@andrewdavidwong

andrewdavidwong Nov 28, 2016

Member

I figured @marmarek simply changed that setting in Nautilus before packaging the standard Fedora template.

Member

andrewdavidwong commented Nov 28, 2016

I figured @marmarek simply changed that setting in Nautilus before packaging the standard Fedora template.

@marmarek

This comment has been minimized.

Show comment
Hide comment
Member

marmarek commented Nov 28, 2016

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Nov 28, 2016

Member

If not working on Debian, it may require to call glib-compile-schemas. From rpm spec:

%posttrans
/usr/bin/glib-compile-schemas %{_datadir}/glib-2.0/schemas &> /dev/null || :
Member

marmarek commented Nov 28, 2016

If not working on Debian, it may require to call glib-compile-schemas. From rpm spec:

%posttrans
/usr/bin/glib-compile-schemas %{_datadir}/glib-2.0/schemas &> /dev/null || :
@andrewdavidwong

This comment has been minimized.

Show comment
Hide comment
@andrewdavidwong

andrewdavidwong Nov 28, 2016

Member

It wasn't me, anyway: QubesOS/qubes-core-agent-linux@40fcbde

Oh, sorry!

@adrelanos: BTW, here's the issue that was closed by the above commit: #813

Member

andrewdavidwong commented Nov 28, 2016

It wasn't me, anyway: QubesOS/qubes-core-agent-linux@40fcbde

Oh, sorry!

@adrelanos: BTW, here's the issue that was closed by the above commit: #813

@unman unman referenced this issue in QubesOS/qubes-core-agent-linux Feb 12, 2017

Merged

Apply gschema override preventing previews in nautilus in Debian #39

@unman

This comment has been minimized.

Show comment
Hide comment
@unman

unman Feb 12, 2017

Member

I believe that file previews are turned off in dolphin by default. At least in jessie and stretch it appears to be so.

Member

unman commented Feb 12, 2017

I believe that file previews are turned off in dolphin by default. At least in jessie and stretch it appears to be so.

@unman

This comment has been minimized.

Show comment
Hide comment
@unman

unman Feb 19, 2017

Member

@andrewdavidwong The merging of QubesOS/qubes-core-agent-linux#39 closes this in Debian.
Whonix has its own solution.

Member

unman commented Feb 19, 2017

@andrewdavidwong The merging of QubesOS/qubes-core-agent-linux#39 closes this in Debian.
Whonix has its own solution.

@adrelanos

This comment has been minimized.

Show comment
Hide comment
@adrelanos

adrelanos Feb 19, 2017

Member
Member

adrelanos commented Feb 19, 2017

@unman

This comment has been minimized.

Show comment
Hide comment
@unman

unman Feb 19, 2017

Member
Member

unman commented Feb 19, 2017

adrelanos added a commit to adrelanos/security-misc that referenced this issue Feb 19, 2017

marmarek added a commit to marmarek/old-qubes-core-agent-linux that referenced this issue May 20, 2017

Apply gschema overrides also to debian, rename according to guidelines
glib-compile-schemas recommend naming override files with nn_ prefix,
where nn is a number. Lets use 20, to allow both higher and lower
priority files.

QubesOS/qubes-issues#1108

marmarek added a commit to marmarek/old-qubes-core-agent-linux that referenced this issue May 20, 2017

Apply gschema overrides also to debian, rename according to guidelines
glib-compile-schemas recommend naming override files with nn_ prefix,
where nn is a number. Lets use 20, to allow both higher and lower
priority files.

QubesOS/qubes-issues#1108

@qubesos-bot qubesos-bot referenced this issue in QubesOS/updates-status Jun 9, 2017

Closed

core-agent-linux v4.0.0 (r4.0) #68

@adrelanos adrelanos referenced this issue in freedomofpress/securedrop-workstation Jul 12, 2018

Open

Disable thumbnail previews in Nautilus in `sd-svs` VM #13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment