Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upDebian Templates: Why change systemd default runlevel? #1111
Comments
adrelanos
referenced this issue
Aug 11, 2015
Closed
Debian Templates: fix / refactor 02_install_groups.sh #1112
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
nrgaway
Aug 11, 2015
I believe the purpose was to ensure a proper state upon installation. Many of these scripts were written before Debian included systemd as default and are also used for other distros.
Most likely the 02_install_groups_jessie.sh can be completely removed and those lines can be removed from 02_install_groups_wheezy.sh since they are now present in core-agent-linux.postinst. Note, that within core-agent-linux.postinst the target is only ever modified on the initial installation of the package, which happens during the template build process and not on further updates to the package.
nrgaway
commented
Aug 11, 2015
|
I believe the purpose was to ensure a proper state upon installation. Many of these scripts were written before Debian included systemd as default and are also used for other distros. Most likely the |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
adrelanos
Aug 11, 2015
Member
Most likely the 02_install_groups_jessie.sh can be completely removed and those lines can be removed from 02_install_groups_wheezy.sh since they are now present in core-agent-linux.postinst.
Yes, exactly my thoughts. Created #1112 seconds before you wrote that. :)
Yes, exactly my thoughts. Created #1112 seconds before you wrote that. :) |
added a commit
to adrelanos/qubes-builder-debian
that referenced
this issue
Aug 11, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Aug 26, 2015
Member
I think this code was Fedora-specific (copied from there). On Fedora
default systemd target was "graphical.target", which tries to start
kdm/gdm/lightdm, so X server without qubes gui agent.
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
|
I think this code was Fedora-specific (copied from there). On Fedora Best Regards, |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
adrelanos
Sep 6, 2015
Member
The following pull request also solves this ticket:
marmarek/qubes-builder-debian#20
|
The following pull request also solves this ticket: |
adrelanos commentedAug 11, 2015
Could you please explain the rationale behind modifying the systemd default runlevel? What would happen if that would be left untouched?
https://github.com/marmarek/qubes-core-agent-linux/blob/c6fa6c9b19425770e093a085da697d3c28d974c2/debian/qubes-core-agent.postinst#L104-L106
https://github.com/marmarek/qubes-builder-debian/blob/56cd946068129185f69b703b9e5e450b8cfa698a/template_debian/02_install_groups_jessie.sh#L32-L36