Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upunduplicate / refactor umount_kill.sh #1157
Comments
marmarek
added
C: builder
P: minor
task
labels
Oct 8, 2015
marmarek
added this to the Release 3.1 milestone
Oct 8, 2015
marmarek
modified the milestones:
Release 3.2,
Release 3.1
Feb 8, 2016
marmarek
modified the milestones:
Release 3.2,
Release 3.2 updates
Nov 19, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
adrelanos commentedSep 1, 2015
There are 3 different versions in 3 different repositories.
Step one, sync them. That alone would be worthwhile. The following two have only a single lined diff.
diff ./qubes-builder-debian/scripts/umount_kill.sh ./qubes-builder/scripts/umount_kill.shStep two, is it possible to have only one of these files in the Qubes source?
I was also always wondering if such a script and other image mount/umount/chroot related code could be upstreamed somewhere instead of reinventing it in every project. libguestfs (slow) does not want kpartx based mount scripts.
@nrgaway