New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unduplicate / refactor umount_kill.sh #1157

Open
adrelanos opened this Issue Sep 1, 2015 · 0 comments

Comments

Projects
None yet
2 participants
@adrelanos
Member

adrelanos commented Sep 1, 2015

There are 3 different versions in 3 different repositories.

Step one, sync them. That alone would be worthwhile. The following two have only a single lined diff.

diff ./qubes-builder-debian/scripts/umount_kill.sh ./qubes-builder/scripts/umount_kill.sh

Step two, is it possible to have only one of these files in the Qubes source?

I was also always wondering if such a script and other image mount/umount/chroot related code could be upstreamed somewhere instead of reinventing it in every project. libguestfs (slow) does not want kpartx based mount scripts.

@nrgaway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment