App icon selection algorithm is incorrect, results in black-and-white Ubuntu icons

[qubesuser]

qubes.GetImageRGBA chooses application icons in a very suboptimal way.

It first looks in /usr/share/icons/hicolor and then in /usr/share/icons and takes the PNG icon with the biggest filesize.

This is wrong: it should instead prioritize default themes like gnome and Humanity for Ubuntu and then hicolor and then the rest, it should also support SVG and XPM files and it should pick the biggest icon by the directory name (16x16, 32x32, and so on) rather than by file size.

The correct algorithm is described at http://standards.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html

Should probably use an existing implementation like this one: https://pyxdg.readthedocs.org/en/latest/_modules/xdg/IconTheme.html

[marmarek]

Thanks for providing the fix.
According to our release schedule only critical fixes can be accepted now, so this will probably go as an update after final release.

[marmarek]

Thanks for providing the fix.
According to our release schedule only critical fixes can be accepted now, so this will probably go as an update after final release.

[qubesuser]

Sure, the impact of the issue is minimal and while the code is simple it's not a trivial fix and could cause regressions.

[qubesuser]

Sure, the impact of the issue is minimal and while the code is simple it's not a trivial fix and could cause regressions.

[marmarek]

https://groups.google.com/d/msg/qubes-users/CR5X4CqhwbI/1clqfabRAQAJ
Additionally "/usr/share/pixmap" is missing from search path.

[marmarek]

https://groups.google.com/d/msg/qubes-users/CR5X4CqhwbI/1clqfabRAQAJ
Additionally "/usr/share/pixmap" is missing from search path.

[marmarek]

Fixed since that pull request is merged.

[marmarek]

Fixed since that pull request is merged.