Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign uprename function chroot to chroot_cmd or similar #1174
Comments
marmarek
added
enhancement
C: builder
P: minor
labels
Jan 7, 2016
marmarek
added this to the Release 3.2 milestone
Jan 7, 2016
added a commit
to marmarek/qubes-template-whonix
that referenced
this issue
Apr 20, 2016
added a commit
to marmarek/qubes-builder-debian
that referenced
this issue
Apr 20, 2016
added a commit
to marmarek/qubes-builder-rpm
that referenced
this issue
Apr 20, 2016
marmarek
closed this
in
marmarek/qubes-linux-template-builder@b427341
Apr 20, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
marmarek
Apr 20, 2016
Member
This is API change, if using updated linux-template-builder, builder plugins also needs to be updated.
|
This is API change, if using updated linux-template-builder, builder plugins also needs to be updated. |
added a commit
to adrelanos/qubes-template-whonix
that referenced
this issue
Apr 20, 2016
added a commit
to adrelanos/qubes-template-whonix
that referenced
this issue
Apr 21, 2016
added a commit
to Whonix/qubes-template-whonix
that referenced
this issue
May 5, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
adrelanos commentedSep 6, 2015
Rename function
chroottochroot_cmdor similar.Code in question:
https://github.com/marmarek/qubes-linux-template-builder/blob/5897b1a88245bdcb8f0f2d454d1eb54098d0df4a/functions.sh#L67-L92
Then elsewhere (example) you are using
chroot. One would wonder which one it is. Functionchrootor binary/usr/sbin/chroot? [In this example, it's the latter.]This is very confusing. Generally, please don't assign the very same name to a function as an existing binary.