/qubes-issues

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not install non-free package firmware-linux by default #1177

Closed
adrelanos opened this Issue Sep 8, 2015 · 7 comments

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@adrelanos @marmarek
@adrelanos
Member

adrelanos commented Sep 8, 2015

firmware-linux is a non-free package:
https://packages.debian.org/stretch/firmware-linux

So is firmware-linux-nonfree.

It's part of default package lists and installed by default in Debian templates, example:
https://github.com/marmarek/qubes-builder-debian/blob/0dccecacdd74ec1b10866143e3956e5fb8ca2241/template_debian/packages_jessie.list#L16

I haven't found any rationale on qubes-devel, qubes-user or the source code why firmware-linux(-nonfree) gets installed by default.

I am wondering about this, because these are the only non-free packages installed in Qubes-Whonix templates. And that is unfortunate, because these two non-free packages make the whole image non-free.

For finding non-free packages on Debian, vrms is quite useful.
https://packages.debian.org/stretch/vrms
Easy to use also. sudo apt-get install vrms + vrms. That's all.

If there is a rationale behind having this installed by default, then please explain and then this ticket could be closed.
@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Sep 8, 2015

Member

Yes, there is rationale - to be able to use Debian template as NetVM.
Many wireless cards requires some non-free firmware, unfortunately.

It's probably safe (and good idea) to remove those packages from Whonix
templates. @nrgaway any idea how to do that nicely (i.e. without
installing the package first, then removing it)? Maybe include it only
in "standard" flavor and do not use this flavor in Whonix templates (as
already done in Whonix-gateway)?

Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
Member

marmarek commented Sep 8, 2015

Yes, there is rationale - to be able to use Debian template as NetVM.
Many wireless cards requires some non-free firmware, unfortunately.

It's probably safe (and good idea) to remove those packages from Whonix
templates. @nrgaway any idea how to do that nicely (i.e. without
installing the package first, then removing it)? Maybe include it only
in "standard" flavor and do not use this flavor in Whonix templates (as
already done in Whonix-gateway)?

Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
@adrelanos

This comment has been minimized.

Show comment
Hide comment
@adrelanos

adrelanos Sep 10, 2015

Member

Maybe include it only in "standard" flavor and do not use this flavor in Whonix templates (as already done in Whonix-gateway)?

Both, yes.
(Whonix templates are now build using flavors minimal + no-recommends.)
Member

adrelanos commented Sep 10, 2015

Maybe include it only in "standard" flavor and do not use this flavor in Whonix templates (as already done in Whonix-gateway)?

Both, yes.
(Whonix templates are now build using flavors minimal + no-recommends.)
@adrelanos

This comment has been minimized.

Show comment
Hide comment
@adrelanos

adrelanos Sep 12, 2015

Member

Testwise:

  • From template_debian/packages_jessie.list removed firmware-linux.
  • To template_debian/packages_jessie_standard.list added firmware-linux.

Then those package no longer get installed in Whonix. So this should work.
Member

adrelanos commented Sep 12, 2015

Testwise:

  • From template_debian/packages_jessie.list removed firmware-linux.
  • To template_debian/packages_jessie_standard.list added firmware-linux.

Then those package no longer get installed in Whonix. So this should work.
@adrelanos

This comment has been minimized.

Show comment
Hide comment
@adrelanos

adrelanos Sep 12, 2015

Member

Trying to come up with a pull request... Wondering...

What is the .missing file template_debian/packages_stretch.missing good for?
Member

adrelanos commented Sep 12, 2015

Trying to come up with a pull request... Wondering...

What is the .missing file template_debian/packages_stretch.missing good for?
@adrelanos

This comment has been minimized.

Show comment
Hide comment
@adrelanos

adrelanos Sep 28, 2015

Member

Wondering...

What is the .missing file template_debian/packages_stretch.missing good for?

Anyone any idea?
Member

adrelanos commented Sep 28, 2015

Wondering...

What is the .missing file template_debian/packages_stretch.missing good for?

Anyone any idea?
@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Sep 28, 2015

Member

On Mon, Sep 28, 2015 at 03:13:42AM -0700, Patrick Schleizer wrote:

Wondering...

What is the .missing file template_debian/packages_stretch.missing good for?

Anyone any idea?

No idea, just guessing: maybe some placeholder instead of real file to
be done (TODO)? @nrgaway

Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
Member

marmarek commented Sep 28, 2015

On Mon, Sep 28, 2015 at 03:13:42AM -0700, Patrick Schleizer wrote:

Wondering...

What is the .missing file template_debian/packages_stretch.missing good for?

Anyone any idea?

No idea, just guessing: maybe some placeholder instead of real file to
be done (TODO)? @nrgaway

Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
@adrelanos

This comment has been minimized.

Show comment
Hide comment
@adrelanos

adrelanos Oct 22, 2015

Member
  • linux-firmware depends on both linux-firmware-free and linux-firmware-nonfree.
  • Maybe linux-firmware was not available in Debian stretch at time of committing, so file template_debian/packages_stretch.missing was created as a reminder. Since this is no longer the case and the file seems unused, let's delete it.

Suggested solution:

  • remove linux-firmware* from template_debian/packages_jessie.list
  • add linux-firmware to template_debian/packages_qubes_standard.list
  • delete template_debian/packages_stretch.missing

What do you think?
Member

adrelanos commented Oct 22, 2015

  • linux-firmware depends on both linux-firmware-free and linux-firmware-nonfree.
  • Maybe linux-firmware was not available in Debian stretch at time of committing, so file template_debian/packages_stretch.missing was created as a reminder. Since this is no longer the case and the file seems unused, let's delete it.

Suggested solution:

  • remove linux-firmware* from template_debian/packages_jessie.list
  • add linux-firmware to template_debian/packages_qubes_standard.list
  • delete template_debian/packages_stretch.missing

What do you think?

adrelanos added a commit to adrelanos/qubes-builder-debian that referenced this issue Oct 22, 2015

@adrelanos
no longer install non-free package firmware-linux by default 
QubesOS/qubes-issues#1177
Verified
This commit was signed with a verified signature.
@adrelanos adrelanos Patrick Schleizer
GPG key ID: CB8D50BB77BB3C48 Learn about signing commits
be96e95

adrelanos added a commit to adrelanos/qubes-builder-debian that referenced this issue Nov 2, 2015

@adrelanos
no longer install non-free package firmware-linux by default 
QubesOS/qubes-issues#1177
Verified
This commit was signed with a verified signature.
@adrelanos adrelanos Patrick Schleizer
GPG key ID: CB8D50BB77BB3C48 Learn about signing commits
203ffb0

adrelanos added a commit to adrelanos/qubes-builder-debian that referenced this issue Nov 2, 2015

@adrelanos
no longer install non-free package firmware-linux by default 
Fixes QubesOS/qubes-issues#1177
Verified
This commit was signed with a verified signature.
@adrelanos adrelanos Patrick Schleizer
GPG key ID: CB8D50BB77BB3C48 Learn about signing commits
583b758

adrelanos added a commit to adrelanos/qubes-builder-debian that referenced this issue Nov 2, 2015

@adrelanos
Install linux-firmware in packages_qubes_standard rather than package… 
…s_jessie.

- removed linux-firmware* from template_debian/packages_jessie.list
- added linux-firmware to template_debian/packages_qubes_standard.list
- deleted unused template_debian/packages_stretch.missing

This allows building templates (such as Whonix) without having the non-free
package linux-firmware and linux-firmware-nonfree installed.

Fixes QubesOS/qubes-issues#1177
Verified
This commit was signed with a verified signature.
@adrelanos adrelanos Patrick Schleizer
GPG key ID: CB8D50BB77BB3C48 Learn about signing commits
50d1e10

@adrelanos adrelanos referenced this issue in marmarek/qubes-builder-debian Nov 2, 2015

Merged

do not install non-free package firmware-linux by default #21

@marmarek marmarek closed this in marmarek/qubes-builder-debian#21 Nov 3, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment