New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create management/pre-configuration stack #1258

Closed
marmarek opened this Issue Oct 1, 2015 · 11 comments

Comments

Projects
None yet
4 participants
@marmarek
Member

marmarek commented Oct 1, 2015

The purpose of this feature is to ease configuration of typical use cases. For example:

  • setting up Whonix (install templates, create ProxyVM, AppVMs etc)
  • configure SplitGpg (create (offline) VMs, setup RPC policy, adjust VM settings)

In the first stage (scheduled for R3.1) this is just about initial
configuration. Later we may want to use the same stack for maintaining system
configuration (aka management API).

@marmarek marmarek added this to the Release 3.1 milestone Oct 1, 2015

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Nov 20, 2015

Member

TODO:

  • configuration frontend in firstboot
  • disable "Whonix" option, when no Whonix templates selected during installation
  • add "Whonix" option to installer
  • extract appicons from templates
  • create DispVM template
Member

marmarek commented Nov 20, 2015

TODO:

  • configuration frontend in firstboot
  • disable "Whonix" option, when no Whonix templates selected during installation
  • add "Whonix" option to installer
  • extract appicons from templates
  • create DispVM template
@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Nov 20, 2015

Member

sys-whonix should be connected to sys-net or sys-firewall? @adrelanos
IMHO sys-net, as there is no sense in setting firewall for tor traffic itself.

Member

marmarek commented Nov 20, 2015

sys-whonix should be connected to sys-net or sys-firewall? @adrelanos
IMHO sys-net, as there is no sense in setting firewall for tor traffic itself.

@adrelanos

This comment has been minimized.

Show comment
Hide comment
@adrelanos

adrelanos Nov 20, 2015

Member

Marek Marczykowski-Górecki:

sys-whonix should be connected to sys-net or sys-firewall? @adrelanos
IMHO sys-net, as there is no sense in setting firewall for tor traffic itself.


Reply to this email directly or view it on GitHub:
#1258 (comment)

Hm. Good question.

I'd say sys-firewall. For consistency. Any VM should be connected to
sys-firewall, unless there is a good reason not to.

Then any Qubes specific traffic processing equally applies. [network
lockdown, VPN, ...?)

So would any user extra filtering (IDS) apply. I think that simplified
the setup.

I am wondering which instructions from
https://www.qubes-os.org/doc/qubes-firewall/ would still apply?

For advanced users,

  • Enabling networking between two AppVMs
  • Port forwarding to an AppVM from the outside world

is still interesting. (Networking between two whonix-ws based AppVMs for
whatever hidden service server setup.) (Or port forwarding from the
outside world to Whonix-Gateway to be able to use the pluggable
transport 'flashproxy' (wording comes from a proxy that 'flashes up',
unrelated to adobe flash).

Member

adrelanos commented Nov 20, 2015

Marek Marczykowski-Górecki:

sys-whonix should be connected to sys-net or sys-firewall? @adrelanos
IMHO sys-net, as there is no sense in setting firewall for tor traffic itself.


Reply to this email directly or view it on GitHub:
#1258 (comment)

Hm. Good question.

I'd say sys-firewall. For consistency. Any VM should be connected to
sys-firewall, unless there is a good reason not to.

Then any Qubes specific traffic processing equally applies. [network
lockdown, VPN, ...?)

So would any user extra filtering (IDS) apply. I think that simplified
the setup.

I am wondering which instructions from
https://www.qubes-os.org/doc/qubes-firewall/ would still apply?

For advanced users,

  • Enabling networking between two AppVMs
  • Port forwarding to an AppVM from the outside world

is still interesting. (Networking between two whonix-ws based AppVMs for
whatever hidden service server setup.) (Or port forwarding from the
outside world to Whonix-Gateway to be able to use the pluggable
transport 'flashproxy' (wording comes from a proxy that 'flashes up',
unrelated to adobe flash).

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Nov 20, 2015

Member

The only traffic from sys-whonix is Tor, so filtering on it would be pretty useless. But yes, having sys-firewall as a central place for all the VM simplifies some tasks - live moving all the traffic to sys-3g, so forcibly disabling network. In some cases it might make sense to have sys-whonix instead of sys-firewall - so all the traffic will be torified (but no way to set firewall rules).

Member

marmarek commented Nov 20, 2015

The only traffic from sys-whonix is Tor, so filtering on it would be pretty useless. But yes, having sys-firewall as a central place for all the VM simplifies some tasks - live moving all the traffic to sys-3g, so forcibly disabling network. In some cases it might make sense to have sys-whonix instead of sys-firewall - so all the traffic will be torified (but no way to set firewall rules).

@mfc

This comment has been minimized.

Show comment
Hide comment
@mfc

mfc Nov 20, 2015

Member

An extra VM is an extra memory burden. If firewallvm isn't used/useful as a firewall in this context, then it shouldn't be used by default.

On November 20, 2015 10:08:19 PM GMT+01:00, "Marek Marczykowski-Górecki" notifications@github.com wrote:

The only traffic from sys-whonix is Tor, so filtering on it would be
pretty useless. But yes, having sys-firewall as a central place for
all the VM simplifies some tasks - live moving all the traffic to
sys-3g, so forcibly disabling network. In some cases it might make
sense to have sys-whonix instead of sys-firewall - so all the
traffic will be torified (but no way to set firewall rules).


Reply to this email directly or view it on GitHub:
#1258 (comment)

Member

mfc commented Nov 20, 2015

An extra VM is an extra memory burden. If firewallvm isn't used/useful as a firewall in this context, then it shouldn't be used by default.

On November 20, 2015 10:08:19 PM GMT+01:00, "Marek Marczykowski-Górecki" notifications@github.com wrote:

The only traffic from sys-whonix is Tor, so filtering on it would be
pretty useless. But yes, having sys-firewall as a central place for
all the VM simplifies some tasks - live moving all the traffic to
sys-3g, so forcibly disabling network. In some cases it might make
sense to have sys-whonix instead of sys-firewall - so all the
traffic will be torified (but no way to set firewall rules).


Reply to this email directly or view it on GitHub:
#1258 (comment)

@adrelanos

This comment has been minimized.

Show comment
Hide comment
@adrelanos

adrelanos Nov 20, 2015

Member

Michael Carbone:

An extra VM is an extra memory burden. If firewallvm isn't used/useful as a firewall in this context, then it shouldn't be used by default.

At the moment sys-net and sys-firewall are automatically started at boot
by Qubes default.

Do you think this should be changed?

Or do you primarily have setups in mind where users disabled the
autostart of these VMs?

Do you think there are enough situations where users are (potentially)
exclusively using torified traffic for everything so they won't be
requiring sys-firewall?

Member

adrelanos commented Nov 20, 2015

Michael Carbone:

An extra VM is an extra memory burden. If firewallvm isn't used/useful as a firewall in this context, then it shouldn't be used by default.

At the moment sys-net and sys-firewall are automatically started at boot
by Qubes default.

Do you think this should be changed?

Or do you primarily have setups in mind where users disabled the
autostart of these VMs?

Do you think there are enough situations where users are (potentially)
exclusively using torified traffic for everything so they won't be
requiring sys-firewall?

@adrelanos

This comment has been minimized.

Show comment
Hide comment
@adrelanos

adrelanos Nov 20, 2015

Member

Marek Marczykowski-Górecki:

The only traffic from sys-whonix is Tor, so filtering on it would be pretty useless.

There are still some thing one can filter.

Okay, these are probably all minority use cases.

So either way, this shouldn't be a hard limitation. I mean, the user
should not be forced to use either or have its decision reverted to use
the other one. [To allow advanced filter combinations.] Hopefully this
is doable with the pre-configuration stack.

Member

adrelanos commented Nov 20, 2015

Marek Marczykowski-Górecki:

The only traffic from sys-whonix is Tor, so filtering on it would be pretty useless.

There are still some thing one can filter.

Okay, these are probably all minority use cases.

So either way, this shouldn't be a hard limitation. I mean, the user
should not be forced to use either or have its decision reverted to use
the other one. [To allow advanced filter combinations.] Hopefully this
is doable with the pre-configuration stack.

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Nov 20, 2015

Member

An extra VM is an extra memory burden. If firewallvm isn't used/useful as a firewall in this context, then it shouldn't be used by default.

This would be true only in case of all the VM connected to Whonix Gateway. Otherwise sys-firewall is still usable.
Anyway, we have two options for default settings (easily changeable later):

  • connect sys-whonix to sys-firewall - one step less for advanced configurations, more memory usage, even in all the VMs connected to Whonix-gw
  • connect sys-whonix to sys-net - less memory footprint for whonix-only setups, a little more steps for advanced configs

In case of sys-whonix->sys-net, autostarting sys-firewall may be disabled.

Member

marmarek commented Nov 20, 2015

An extra VM is an extra memory burden. If firewallvm isn't used/useful as a firewall in this context, then it shouldn't be used by default.

This would be true only in case of all the VM connected to Whonix Gateway. Otherwise sys-firewall is still usable.
Anyway, we have two options for default settings (easily changeable later):

  • connect sys-whonix to sys-firewall - one step less for advanced configurations, more memory usage, even in all the VMs connected to Whonix-gw
  • connect sys-whonix to sys-net - less memory footprint for whonix-only setups, a little more steps for advanced configs

In case of sys-whonix->sys-net, autostarting sys-firewall may be disabled.

@adrelanos

This comment has been minimized.

Show comment
Hide comment
@adrelanos

adrelanos Nov 21, 2015

Member

It's all minor advantages/disadvantages either way for minority use cases either way.

Another small reason for sys-firewall is people less concerned freaking out asking "Why sys-whonix is [no longer | not] connected to sys-firewall? Keeping the FUD level low.

Member

adrelanos commented Nov 21, 2015

It's all minor advantages/disadvantages either way for minority use cases either way.

Another small reason for sys-firewall is people less concerned freaking out asking "Why sys-whonix is [no longer | not] connected to sys-firewall? Keeping the FUD level low.

marmarek added a commit to QubesOS/qubes-mgmt-salt-dom0-virtual-machines that referenced this issue Nov 23, 2015

marmarek added a commit to QubesOS/qubes-mgmt-salt-dom0-virtual-machines that referenced this issue Nov 23, 2015

rpm: make spec file parsing independent of Makefile.install
Do not require `make get-...` during parsing spec file, since it may be
executed witout Makefile.install and Makefile.vars copied in.
Since Debian package metadata is already independent of this generator,
in practice it isn't a problem - FORMULA file simply will not be used
for package metadata at all.

This additionally fixes broken newlines in rpm package description.

QubesOS/qubes-issues#1258

marmarek added a commit to QubesOS/qubes-mgmt-salt-dom0-update that referenced this issue Nov 23, 2015

marmarek added a commit to QubesOS/qubes-mgmt-salt-dom0-update that referenced this issue Nov 23, 2015

rpm: make spec file parsing independent of Makefile.install
Do not require `make get-...` during parsing spec file, since it may be
executed witout Makefile.install and Makefile.vars copied in.
Since Debian package metadata is already independent of this generator,
in practice it isn't a problem - FORMULA file simply will not be used
for package metadata at all.

This additionally fixes broken newlines in rpm package description.

QubesOS/qubes-issues#1258

marmarek added a commit to QubesOS/qubes-mgmt-salt-base-topd that referenced this issue Nov 23, 2015

marmarek added a commit to QubesOS/qubes-mgmt-salt-base-topd that referenced this issue Nov 23, 2015

rpm: make spec file parsing independent of Makefile.install
Do not require `make get-...` during parsing spec file, since it may be
executed witout Makefile.install and Makefile.vars copied in.
Since Debian package metadata is already independent of this generator,
in practice it isn't a problem - FORMULA file simply will not be used
for package metadata at all.

This additionally fixes broken newlines in rpm package description.

QubesOS/qubes-issues#1258

marmarek added a commit to QubesOS/qubes-mgmt-salt-dom0-qvm that referenced this issue Nov 23, 2015

marmarek added a commit to QubesOS/qubes-mgmt-salt-dom0-qvm that referenced this issue Nov 23, 2015

rpm: make spec file parsing independent of Makefile.install
Do not require `make get-...` during parsing spec file, since it may be
executed witout Makefile.install and Makefile.vars copied in.
Since Debian package metadata is already independent of this generator,
in practice it isn't a problem - FORMULA file simply will not be used
for package metadata at all.

This additionally fixes broken newlines in rpm package description.

QubesOS/qubes-issues#1258

marmarek added a commit to QubesOS/qubes-mgmt-salt-base-config that referenced this issue Nov 23, 2015

marmarek added a commit to QubesOS/qubes-mgmt-salt-base-config that referenced this issue Nov 23, 2015

marmarek added a commit to QubesOS/qubes-mgmt-salt-base-config that referenced this issue Nov 23, 2015

rpm: make spec file parsing independent of Makefile.install
Do not require `make get-...` during parsing spec file, since it may be
executed witout Makefile.install and Makefile.vars copied in.
Since Debian package metadata is already independent of this generator,
in practice it isn't a problem - FORMULA file simply will not be used
for package metadata at all.

This additionally fixes broken newlines in rpm package description.

QubesOS/qubes-issues#1258

marmarek added a commit to QubesOS/qubes-mgmt-salt-base-config that referenced this issue Nov 23, 2015

Make qubesctl exit code meaningful
By default salt-call (and qubesctl) always exit with exit code 0, even
on some fatal error. Enable using some meaningful value as exit code for
better error reporting (for example in firstboot).

QubesOS/qubes-issues#1258

marmarek added a commit to QubesOS/qubes-mgmt-salt-base that referenced this issue Nov 23, 2015

marmarek added a commit to QubesOS/qubes-mgmt-salt-base that referenced this issue Nov 23, 2015

marmarek added a commit to QubesOS/qubes-mgmt-salt-base that referenced this issue Nov 23, 2015

rpm: make spec file parsing independent of Makefile.install
Do not require `make get-...` during parsing spec file, since it may be
executed witout Makefile.install and Makefile.vars copied in.
Since Debian package metadata is already independent of this generator,
in practice it isn't a problem - FORMULA file simply will not be used
for package metadata at all.

QubesOS/qubes-issues#1258

marmarek added a commit to QubesOS/qubes-mgmt-salt-base that referenced this issue Nov 23, 2015

marmarek added a commit to QubesOS/qubes-mgmt-salt-base-overrides that referenced this issue Nov 23, 2015

marmarek added a commit to QubesOS/qubes-mgmt-salt-base-overrides that referenced this issue Nov 23, 2015

rpm: make spec file parsing independent of Makefile.install
Do not require `make get-...` during parsing spec file, since it may be
executed witout Makefile.install and Makefile.vars copied in.
Since Debian package metadata is already independent of this generator,
in practice it isn't a problem - FORMULA file simply will not be used
for package metadata at all.

This additionally fixes broken newlines in rpm package description.

QubesOS/qubes-issues#1258

marmarek added a commit to QubesOS/qubes-mgmt-salt-base-overrides that referenced this issue Nov 23, 2015

marmarek added a commit to QubesOS/qubes-mgmt-salt that referenced this issue Nov 23, 2015

Simplify formula installation code
- do not automatically calculate target directory - require it
explicitly set in FORMULA file - makes the code (and its configuration) much easier to follow and understand
- do not reimplement `cp -r` in Makefile functions
- drop quotes from Makefile.vars, add them when necessary in
Makefile.install

QubesOS/qubes-issues#1258

marmarek added a commit to QubesOS/qubes-mgmt-salt that referenced this issue Nov 23, 2015

rpm: make spec file parsing independent of Makefile.install
Do not require `make get-...` during parsing spec file, since it may be
executed witout Makefile.install and Makefile.vars copied in.
Since Debian package metadata is already independent of this generator,
in practice it isn't a problem - FORMULA file simply will not be used
for package metadata at all.

This additionally fixes broken newlines in rpm package description.

QubesOS/qubes-issues#1258

marmarek added a commit to QubesOS/qubes-mgmt-salt that referenced this issue Nov 23, 2015

marmarek added a commit to QubesOS/qubes-mgmt-salt that referenced this issue Nov 23, 2015

marmarek added a commit to marmarek/qubes-installer-qubes-os that referenced this issue Nov 23, 2015

firstboot: force salt-minion configuration refresh
It should be done at package installation time (%post script), but
unfortunately it isn't. Probably because of wrong order of scripts calls
(missin Requires(post) dependencies).

QubesOS/qubes-issues#1258

marmarek added a commit to marmarek/qubes-installer-qubes-os that referenced this issue Nov 23, 2015

firstboot: restore appmenus retrieval code
This part isn't (and probably shouldn't be) handled by salt.

QubesOS/qubes-issues#1258

marmarek added a commit to marmarek/qubes-installer-qubes-os that referenced this issue Nov 23, 2015

marmarek added a commit to marmarek/qubes-installer-qubes-os that referenced this issue Nov 23, 2015

marmarek added a commit to marmarek/qubes-installer-qubes-os that referenced this issue Nov 23, 2015

marmarek added a commit to marmarek/qubes-installer-qubes-os that referenced this issue Nov 23, 2015

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Nov 23, 2015

Member

Implemented, mostly by @nrgaway.

Member

marmarek commented Nov 23, 2015

Implemented, mostly by @nrgaway.

@nrgaway

This comment has been minimized.

Show comment
Hide comment
@nrgaway

nrgaway Dec 1, 2015

I will have time to finish anything outstanding starting next week

On 23 November 2015 at 17:29, Marek Marczykowski-Górecki <
notifications@github.com> wrote:

Implemented, mostly by @nrgaway https://github.com/nrgaway.


Reply to this email directly or view it on GitHub
#1258 (comment)
.

nrgaway commented Dec 1, 2015

I will have time to finish anything outstanding starting next week

On 23 November 2015 at 17:29, Marek Marczykowski-Górecki <
notifications@github.com> wrote:

Implemented, mostly by @nrgaway https://github.com/nrgaway.


Reply to this email directly or view it on GitHub
#1258 (comment)
.

nrgaway added a commit to nrgaway/qubes-mgmt-salt-all-gnupg that referenced this issue Dec 13, 2015

nrgaway added a commit to nrgaway/qubes-mgmt-salt-all-gnupg that referenced this issue Dec 13, 2015

rpm: make spec file parsing independent of Makefile.install and set p…
…ackage release to static value

Do not require `make get-...` during parsing spec file, since it may be
executed witout Makefile.install and Makefile.vars copied in.
Since Debian package metadata is already independent of this generator,
in practice it isn't a problem - FORMULA file simply will not be used
for package metadata at all.

This additionally fixes broken newlines in rpm package description.

QubesOS/qubes-issues#1258

nrgaway added a commit to nrgaway/qubes-mgmt-salt-all-privacy that referenced this issue Dec 13, 2015

nrgaway added a commit to nrgaway/qubes-mgmt-salt-all-privacy that referenced this issue Dec 13, 2015

rpm: make spec file parsing independent of Makefile.install and set p…
…ackage release to static value

Do not require `make get-...` during parsing spec file, since it may be
executed witout Makefile.install and Makefile.vars copied in.
Since Debian package metadata is already independent of this generator,
in practice it isn't a problem - FORMULA file simply will not be used
for package metadata at all.

This additionally fixes broken newlines in rpm package description.

QubesOS/qubes-issues#1258

nrgaway added a commit to nrgaway/qubes-mgmt-salt-all-salt that referenced this issue Dec 13, 2015

nrgaway added a commit to nrgaway/qubes-mgmt-salt-all-salt that referenced this issue Dec 13, 2015

rpm: make spec file parsing independent of Makefile.install and set p…
…ackage release to static value

Do not require `make get-...` during parsing spec file, since it may be
executed witout Makefile.install and Makefile.vars copied in.
Since Debian package metadata is already independent of this generator,
in practice it isn't a problem - FORMULA file simply will not be used
for package metadata at all.

This additionally fixes broken newlines in rpm package description.

QubesOS/qubes-issues#1258

nrgaway added a commit to nrgaway/qubes-mgmt-salt-all-theme that referenced this issue Dec 13, 2015

nrgaway added a commit to nrgaway/qubes-mgmt-salt-all-theme that referenced this issue Dec 13, 2015

rpm: make spec file parsing independent of Makefile.install and set p…
…ackage release to static value

Do not require `make get-...` during parsing spec file, since it may be
executed witout Makefile.install and Makefile.vars copied in.
Since Debian package metadata is already independent of this generator,
in practice it isn't a problem - FORMULA file simply will not be used
for package metadata at all.

This additionally fixes broken newlines in rpm package description.

QubesOS/qubes-issues#1258

nrgaway added a commit to nrgaway/qubes-mgmt-salt-all-vim that referenced this issue Dec 13, 2015

nrgaway added a commit to nrgaway/qubes-mgmt-salt-all-vim that referenced this issue Dec 13, 2015

rpm: make spec file parsing independent of Makefile.install and set p…
…ackage release to static value

Do not require `make get-...` during parsing spec file, since it may be
executed witout Makefile.install and Makefile.vars copied in.
Since Debian package metadata is already independent of this generator,
in practice it isn't a problem - FORMULA file simply will not be used
for package metadata at all.

This additionally fixes broken newlines in rpm package description.

QubesOS/qubes-issues#1258

nrgaway added a commit to nrgaway/qubes-mgmt-salt-all-yamlscript-users that referenced this issue Dec 13, 2015

nrgaway added a commit to nrgaway/qubes-mgmt-salt-all-yamlscript-users that referenced this issue Dec 13, 2015

rpm: make spec file parsing independent of Makefile.install and set p…
…ackage release to static value

Do not require `make get-...` during parsing spec file, since it may be
executed witout Makefile.install and Makefile.vars copied in.
Since Debian package metadata is already independent of this generator,
in practice it isn't a problem - FORMULA file simply will not be used
for package metadata at all.

This additionally fixes broken newlines in rpm package description.

QubesOS/qubes-issues#1258

nrgaway added a commit to nrgaway/qubes-mgmt-salt-dev that referenced this issue Dec 13, 2015

nrgaway added a commit to nrgaway/qubes-mgmt-salt-dev that referenced this issue Dec 13, 2015

rpm: make spec file parsing independent of Makefile.install and set p…
…ackage release to static value

Do not require `make get-...` during parsing spec file, since it may be
executed witout Makefile.install and Makefile.vars copied in.
Since Debian package metadata is already independent of this generator,
in practice it isn't a problem - FORMULA file simply will not be used
for package metadata at all.

This additionally fixes broken newlines in rpm package description.

QubesOS/qubes-issues#1258

nrgaway added a commit to nrgaway/qubes-mgmt-salt-dom0-fix-permissions that referenced this issue Dec 13, 2015

nrgaway added a commit to nrgaway/qubes-mgmt-salt-dom0-fix-permissions that referenced this issue Dec 13, 2015

rpm: make spec file parsing independent of Makefile.install and set p…
…ackage release to static value

Do not require `make get-...` during parsing spec file, since it may be
executed witout Makefile.install and Makefile.vars copied in.
Since Debian package metadata is already independent of this generator,
in practice it isn't a problem - FORMULA file simply will not be used
for package metadata at all.

This additionally fixes broken newlines in rpm package description.

QubesOS/qubes-issues#1258

nrgaway added a commit to nrgaway/qubes-mgmt-salt-dom0-policy-qubesbuilder that referenced this issue Dec 13, 2015

nrgaway added a commit to nrgaway/qubes-mgmt-salt-dom0-policy-qubesbuilder that referenced this issue Dec 13, 2015

rpm: make spec file parsing independent of Makefile.install and set p…
…ackage release to static value

Do not require `make get-...` during parsing spec file, since it may be
executed witout Makefile.install and Makefile.vars copied in.
Since Debian package metadata is already independent of this generator,
in practice it isn't a problem - FORMULA file simply will not be used
for package metadata at all.

This additionally fixes broken newlines in rpm package description.

QubesOS/qubes-issues#1258

nrgaway added a commit to nrgaway/qubes-mgmt-salt-dom0-template-upgrade that referenced this issue Dec 13, 2015

nrgaway added a commit to nrgaway/qubes-mgmt-salt-dom0-template-upgrade that referenced this issue Dec 13, 2015

rpm: make spec file parsing independent of Makefile.install and set p…
…ackage release to static value

Do not require `make get-...` during parsing spec file, since it may be
executed witout Makefile.install and Makefile.vars copied in.
Since Debian package metadata is already independent of this generator,
in practice it isn't a problem - FORMULA file simply will not be used
for package metadata at all.

This additionally fixes broken newlines in rpm package description.

QubesOS/qubes-issues#1258

nrgaway added a commit to nrgaway/qubes-mgmt-salt-template that referenced this issue Dec 13, 2015

nrgaway added a commit to nrgaway/qubes-mgmt-salt-template that referenced this issue Dec 13, 2015

rpm: make spec file parsing independent of Makefile.install and set p…
…ackage release to static value

Do not require `make get-...` during parsing spec file, since it may be
executed witout Makefile.install and Makefile.vars copied in.
Since Debian package metadata is already independent of this generator,
in practice it isn't a problem - FORMULA file simply will not be used
for package metadata at all.

This additionally fixes broken newlines in rpm package description.

QubesOS/qubes-issues#1258

nrgaway added a commit to nrgaway/qubes-mgmt-salt-user-nrgaway that referenced this issue Dec 13, 2015

nrgaway added a commit to nrgaway/qubes-mgmt-salt-user-nrgaway that referenced this issue Dec 13, 2015

rpm: make spec file parsing independent of Makefile.install and set p…
…ackage release to static value

Do not require `make get-...` during parsing spec file, since it may be
executed witout Makefile.install and Makefile.vars copied in.
Since Debian package metadata is already independent of this generator,
in practice it isn't a problem - FORMULA file simply will not be used
for package metadata at all.

This additionally fixes broken newlines in rpm package description.

QubesOS/qubes-issues#1258

nrgaway added a commit to nrgaway/qubes-mgmt-salt-vm-python-pip that referenced this issue Dec 13, 2015

nrgaway added a commit to nrgaway/qubes-mgmt-salt-vm-python-pip that referenced this issue Dec 13, 2015

rpm: make spec file parsing independent of Makefile.install and set p…
…ackage release to static value

Do not require `make get-...` during parsing spec file, since it may be
executed witout Makefile.install and Makefile.vars copied in.
Since Debian package metadata is already independent of this generator,
in practice it isn't a problem - FORMULA file simply will not be used
for package metadata at all.

This additionally fixes broken newlines in rpm package description.

QubesOS/qubes-issues#1258

nrgaway added a commit to nrgaway/qubes-mgmt-salt-all-yamlscript-renderer that referenced this issue Dec 14, 2015

nrgaway added a commit to nrgaway/qubes-mgmt-salt-all-yamlscript-renderer that referenced this issue Dec 14, 2015

rpm: make spec file parsing independent of Makefile.install and set p…
…ackage release to static value

Do not require `make get-...` during parsing spec file, since it may be
executed witout Makefile.install and Makefile.vars copied in.
Since Debian package metadata is already independent of this generator,
in practice it isn't a problem - FORMULA file simply will not be used
for package metadata at all.

This additionally fixes broken newlines in rpm package description.

QubesOS/qubes-issues#1258

nrgaway added a commit to nrgaway/qubes-mgmt-salt-user-nrgaway that referenced this issue Dec 14, 2015

rpm: make spec file parsing independent of Makefile.install and set p…
…ackage release to static value

Do not require `make get-...` during parsing spec file, since it may be
executed witout Makefile.install and Makefile.vars copied in.
Since Debian package metadata is already independent of this generator,
in practice it isn't a problem - FORMULA file simply will not be used
for package metadata at all.

This additionally fixes broken newlines in rpm package description.

QubesOS/qubes-issues#1258
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment