New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more VM types in qvm-grow-root #1268

Closed
nhlfr opened this Issue Oct 4, 2015 · 5 comments

Comments

Projects
None yet
2 participants
@nhlfr

nhlfr commented Oct 4, 2015

Currently qvm-grow-root can resize root.img for:

  • template HVM-s
  • HVM-s with are not template-based

And it's done by truncating of root.img. [1]

It's possible to support more VM types:

  • template VM-s
  • standalone VM-s

by truncating (on Dom0) and running resize2fs (on template/standalone VM).

The things above are described in documentation, but it would be nice to do them automatically in qvm-grow-root.

[1] https://github.com/QubesOS/qubes-core-admin/blob/master/core-modules/01QubesHVm.py#L252

@nhlfr

This comment has been minimized.

Show comment
Hide comment
@nhlfr

nhlfr Oct 4, 2015

I cannot assign myself, but I would like to work on it.

nhlfr commented Oct 4, 2015

I cannot assign myself, but I would like to work on it.

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Oct 4, 2015

Member

On Sun, Oct 04, 2015 at 07:41:11AM -0700, Michal Rostecki wrote:

I cannot assign myself, but I would like to work on it.

Great! I'd be happy to accept a patch here :)

Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?

Member

marmarek commented Oct 4, 2015

On Sun, Oct 04, 2015 at 07:41:11AM -0700, Michal Rostecki wrote:

I cannot assign myself, but I would like to work on it.

Great! I'd be happy to accept a patch here :)

Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?

@marmarek marmarek added this to the Release 3.1 milestone Oct 8, 2015

@nhlfr nhlfr referenced this issue in QubesOS/qubes-core-admin Oct 24, 2015

Merged

Support more VM types in qvm-grow-root #8

marmarek added a commit to QubesOS/qubes-core-admin that referenced this issue Nov 7, 2015

Improve resize2fs call for root.img resize
1. Do not start GUI session - to reduce startup time
2. Use user="root" instead of sudo - not all templates have sudo
installed (for example fedora-21-minimal)
3. Add missing wait=True - otherwise VM may be shutdown during the
operation.

QubesOS/qubes-issues#1268

marmarek added a commit to QubesOS/qubes-core-admin that referenced this issue Nov 7, 2015

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Nov 7, 2015

Member

Additionally I think it worth making it clear that VM would be started - this may be unexpected. Something like qvm-grow-root --allow-start, and without that option, it would refuse operation when VM startup is required. Or some other interface, but I would rather avoid interactive prompt.

Member

marmarek commented Nov 7, 2015

Additionally I think it worth making it clear that VM would be started - this may be unexpected. Something like qvm-grow-root --allow-start, and without that option, it would refuse operation when VM startup is required. Or some other interface, but I would rather avoid interactive prompt.

@marmarek marmarek reopened this Nov 7, 2015

@marmarek marmarek referenced this issue in QubesOS/qubes-doc Nov 21, 2015

Merged

resize2fs not required for qvm-grow-private #57

marmarek added a commit to marmarek/old-qubes-core-admin that referenced this issue Dec 26, 2015

qvm-grow-root: wait for VM to shutdown at the end
Otherwise it could lead to some race conditions, for example when the
user tries to start some application there afterwards.

QubesOS/qubes-issues#1268
@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Dec 26, 2015

Member

Automated announcement from builder-github

The package qubes-core-dom0-3.1.8-1.fc20 has been pushed to the r3.1 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

Member

marmarek commented Dec 26, 2015

Automated announcement from builder-github

The package qubes-core-dom0-3.1.8-1.fc20 has been pushed to the r3.1 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Jan 12, 2016

Member

Automated announcement from builder-github

The package qubes-core-dom0-3.1.10-1.fc20 has been pushed to the r3.1 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

Member

marmarek commented Jan 12, 2016

Automated announcement from builder-github

The package qubes-core-dom0-3.1.10-1.fc20 has been pushed to the r3.1 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

marmarek added a commit to QubesOS/qubes-core-admin that referenced this issue Jan 15, 2016

tests: resize private.img/root.img
QubesOS/qubes-issues#1268

(cherry picked from commit 49141d4)

Excluding a part not present in R3.0 - resizing root.img of StandaloneVM
(PV).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment