Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upQubes Manager: Make it more difficult to delete VMs #1329
Comments
andrewdavidwong
added
enhancement
C: qubes-manager
P: minor
labels
Oct 13, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
DeltaHeavy
commented
Oct 31, 2015
|
Agree |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
adrelanos
Nov 2, 2015
Member
What about a more simple
Really delete VM <name of the VM>?
Yes | No [selected by default]
?
|
What about a more simple |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
andrewdavidwong
Nov 2, 2015
Member
A second Yes/Cancel prompt could work, but the message on the second should at least give some sort of additional warning to the user signifying the gravity of what's about to happen.
The first prompt already says:
Are you sure you want to remove the VM '<vm-name>'?
All data on this VM's private storage will be lost!
[Yes] [Cancel]
This is already how one would word the second prompt, so it's not clear how the actual second should be worded. Perhaps the second one could say something like:
**Warning:** This action is permanent and cannot be undone!
This is your final warning! Please confirm the permanent
deletion of the VM '<vm-name>'.
[Yes] [Cancel]
|
A second Yes/Cancel prompt could work, but the message on the second should at least give some sort of additional warning to the user signifying the gravity of what's about to happen. The first prompt already says:
This is already how one would word the second prompt, so it's not clear how the actual second should be worded. Perhaps the second one could say something like:
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
DeltaHeavy
Nov 2, 2015
Another solution is to have a check box in VM settings "Lock VM" or
"Protect VM" which enables secondary confirmation on deletion (or perhaps
just disables deletion until unchecked).
On Nov 2, 2015 11:39 AM, "Axon" notifications@github.com wrote:
A second Yes/Cancel prompt could work, but the message on the second
should at least give some sort of additional warning to the user signifying
the gravity of what's about to happen.The first prompt already says:
Are you sure you want to remove the VM ''?
All data on this VM's private storage will be lost!
[Yes] [Cancel]This is already how one would word the second prompt, so it's not clear
how the actual second should be worded. Perhaps the second one could say
something like:Warning: This action is permanent and cannot be undone!
This is your final warning! Please confirm the permanent
deletion of the VM ''.
[Yes] [Cancel]—
Reply to this email directly or view it on GitHub
#1329 (comment)
.
DeltaHeavy
commented
Nov 2, 2015
|
Another solution is to have a check box in VM settings "Lock VM" or
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marmarek
Nov 2, 2015
Member
I think the most efficient would be the initial idea - entering VM name
to confirm its removal.
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
|
I think the most efficient would be the initial idea - entering VM name Best Regards, |
marmarek
added this to the Release 3.2 milestone
Jan 7, 2016
marmarek
referenced this issue
Mar 29, 2016
Closed
Web page with list of wanted maintainers/developers/others #1700
marmarek
referenced this issue
Jul 20, 2016
Closed
When removing VM ask user to retype its name as a confirmation #2184
andrewdavidwong
added
the
UX
label
Jul 21, 2016
marmarek
modified the milestones:
Release 3.2,
Release 3.2 updates
Nov 19, 2016
marmarek
referenced this issue
in QubesOS/qubes-manager
Nov 23, 2016
Merged
Require typing name of VM to remove #10
marmarek
closed this
Nov 23, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
qubesos-bot
Dec 15, 2016
Automated announcement from builder-github
The package qubes-manager-3.2.5-1.fc23 has been pushed to the r3.2 testing repository for dom0.
To test this update, please install it with the following command:
sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing
qubesos-bot
commented
Dec 15, 2016
|
Automated announcement from builder-github The package
|
qubesos-bot
added
the
r3.2-dom0-cur-test
label
Dec 15, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
emdete
Jan 3, 2017
i don't like to force a user to manually retype some arbitrary word. instead i prefere transparency. if the user gets some inside to drive his decision "delete or not to delete" it would be helpful to show what she looses in case of delition. like "the rw/partition still contains 2GB of userdata with roughly 300 jpegs" (ok, just an example).
emdete
commented
Jan 3, 2017
|
i don't like to force a user to manually retype some arbitrary word. instead i prefere transparency. if the user gets some inside to drive his decision "delete or not to delete" it would be helpful to show what she looses in case of delition. like "the rw/partition still contains 2GB of userdata with roughly 300 jpegs" (ok, just an example). |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
andrewdavidwong
Jan 3, 2017
Member
i don't like to force a user to manually retype some arbitrary word.
But it's the opposite of arbitrary. It's the name that you, the user, specifically bestowed upon this VM.
But it's the opposite of arbitrary. It's the name that you, the user, specifically bestowed upon this VM. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
emdete
Jan 5, 2017
i meant "arbitrary" because it is choosen arbitrarily by qubes to use that word. any other would be fine. debian for example chooses "Yes, do as I say!" or the like if you do something potential dangerous. that's of no help but pesters the user. i like to get the information /why/ that operation is dangerous and /what/ can get wrong or lost. this is taking the use seriously and helps him to decide instead of a short stopper in the hope the user reconsiders his request.
emdete
commented
Jan 5, 2017
|
i meant "arbitrary" because it is choosen arbitrarily by qubes to use that word. any other would be fine. debian for example chooses "Yes, do as I say!" or the like if you do something potential dangerous. that's of no help but pesters the user. i like to get the information /why/ that operation is dangerous and /what/ can get wrong or lost. this is taking the use seriously and helps him to decide instead of a short stopper in the hope the user reconsiders his request. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
andrewdavidwong
Jan 6, 2017
Member
i meant "arbitrary" because it is choosen arbitrarily by qubes to use that word.
No, it's not. It's not arbitrary to choose the name of the VM that's being deleted. This is common functionality. For example, you have to enter the name of a GitHub repo when attempting to delete it.
any other would be fine. debian for example chooses "Yes, do as I say!" or the like if you do something potential dangerous. that's of no help but pesters the user.
Why would anything else be fine? Moreover, how is it fine if it's "of no help but pesters the user"?
i like to get the information /why/ that operation is dangerous and /what/ can get wrong or lost. this is taking the use seriously and helps him to decide instead of a short stopper in the hope the user reconsiders his request.
Is it not obvious in this case? If you click "Remove VM," then what you risk losing is precisely that VM.
No, it's not. It's not arbitrary to choose the name of the VM that's being deleted. This is common functionality. For example, you have to enter the name of a GitHub repo when attempting to delete it.
Why would anything else be fine? Moreover, how is it fine if it's "of no help but pesters the user"?
Is it not obvious in this case? If you click "Remove VM," then what you risk losing is precisely that VM. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
emdete
Jan 6, 2017
pfew... gui design is tricky. and discussions around even more. ;)
you got me wrong when i said "would be fine" - this meant instead of your suggestion to type in the name of the VM. i dont like that the user has to type in something whatever it is. the cause for asking him to type in something is to stop him a bit and to force some time for rethinking. but the user does not gain any new information to reconsider his request.
"that VM" is clear for you, the developer, technician, whatsoever. we talk about GUI for endusers and for an enduser additional information what "that VM" is would be helpful. what files will be lost after deletion. this is in qubes mainly the rw partition. my oppinion: if you want to help the user with his decision show him what he looses, don't torture him by asking to type in words.
emdete
commented
Jan 6, 2017
|
pfew... gui design is tricky. and discussions around even more. ;) you got me wrong when i said "would be fine" - this meant instead of your suggestion to type in the name of the VM. i dont like that the user has to type in something whatever it is. the cause for asking him to type in something is to stop him a bit and to force some time for rethinking. but the user does not gain any new information to reconsider his request. "that VM" is clear for you, the developer, technician, whatsoever. we talk about GUI for endusers and for an enduser additional information what "that VM" is would be helpful. what files will be lost after deletion. this is in qubes mainly the rw partition. my oppinion: if you want to help the user with his decision show him what he looses, don't torture him by asking to type in words. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
andrewdavidwong
Jan 7, 2017
Member
you got me wrong when i said "would be fine" - this meant instead of your suggestion to type in the name of the VM. i dont like that the user has to type in something whatever it is. the cause for asking him to type in something is to stop him a bit and to force some time for rethinking. but the user does not gain any new information to reconsider his request.
Apologies for the misunderstanding. I do think that there should be a "never warn me again" option, but prompting is a better default.
"that VM" is clear for you, the developer, technician, whatsoever. we talk about GUI for endusers and for an enduser additional information what "that VM" is would be helpful. what files will be lost after deletion. this is in qubes mainly the rw partition. my oppinion: if you want to help the user with his decision show him what he looses, don't torture him by asking to type in words.
We're considering this from very different perspectives. From our perspective, the main point of this feature is to prevent misclicks (without this feature, you can easily double-click away a VM if you have a momentary finger spasm). From your perspective, the main point of the feature you're proposing would be to aid the user in deciding whether the user wants to delete the VM. These our two very different things.
Apologies for the misunderstanding. I do think that there should be a "never warn me again" option, but prompting is a better default.
We're considering this from very different perspectives. From our perspective, the main point of this feature is to prevent misclicks (without this feature, you can easily double-click away a VM if you have a momentary finger spasm). From your perspective, the main point of the feature you're proposing would be to aid the user in deciding whether the user wants to delete the VM. These our two very different things. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
emdete
Jan 7, 2017
wasn't there a solution on a voting computer for - or better against wrong clicks? ;)
but you are right, i did not considere a wrong click as i assumed the dialog opens somewhere else and the 'yes' button won't be clicked when accidentally double clicking.
emdete
commented
Jan 7, 2017
|
wasn't there a solution on a voting computer for - or better against wrong clicks? ;) but you are right, i did not considere a wrong click as i assumed the dialog opens somewhere else and the 'yes' button won't be clicked when accidentally double clicking. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
qubesos-bot
Jan 8, 2017
Automated announcement from builder-github
The package qubes-manager-3.2.5-1.fc23 has been pushed to the r3.2 stable repository for dom0.
To install this update, please use the standard update command:
sudo qubes-dom0-update
Or update dom0 via Qubes Manager.
qubesos-bot
commented
Jan 8, 2017
|
Automated announcement from builder-github The package
Or update dom0 via Qubes Manager. |
andrewdavidwong commentedOct 12, 2015
Idea for a newbie-friendly enhancement:
When clicking
Remove AppVMin Qubes Manager, require the user to type the name of the VM to be deleted, then click OK before deleting the VM (instead of just clicking OK).