have DispVMs inherit launcher shortcuts like other TemplateBasedVMs

[adrelanos]

Currently as of Qubes R3:

• Qubes Launcher (blue/green 'Q') -> DisposableVM misses the 'add more shortcuts' button.
• Qubes Launcher (blue/green 'Q') -> DisposableVM lists only Firefox by default. Nothing else.

Proposal:
I suggest to change this, make the DispVM Qubes Launcher menu work like the menu for other TemplateBasedVMs.

Use cases:

• There are various applications that one might use in an amnesic manner (in future thanks to #904). For example: if one created a DispVM based on whonix-ws, it would show the same shortcuts as a whonix-ws template based AppVM. Then the menu would not show Firefox, but for example Tor Browser and XChat. And starting up such an torified XChat whonix-ws template based DispVM would be done thing Qubes Launcher.
• For a Debian based DispVM it would be nice to start either Firefox or Chromium using Qubes Launcher. Not being limited to launching Firefox.

[marmarek]

Good idea. But technically not easy, because DispVMs are started totally
different from other VMs (at least from dom0). This will improve in
R4.0, not sure if possible to do it also in R3.1...

So setting milestone R4.0 for now.

Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?

[marmarek]

Good idea. But technically not easy, because DispVMs are started totally
different from other VMs (at least from dom0). This will improve in
R4.0, not sure if possible to do it also in R3.1...

So setting milestone R4.0 for now.

Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?

[marmarek]

This is done. When an AppVM being a template for DispVM (template_for_dispvms=True) have additionally feature appmenus-dispvm set (qvm-features vmname appmenus-dispvm 1), its menu directory will be named Disposable: vmname (instead of Domain: vmname) and entries there launch new DispVM with that application (same as "DispVM: Firefox" entry in Qubes 3.x).

[marmarek]

This is done. When an AppVM being a template for DispVM (template_for_dispvms=True) have additionally feature appmenus-dispvm set (qvm-features vmname appmenus-dispvm 1), its menu directory will be named Disposable: vmname (instead of Domain: vmname) and entries there launch new DispVM with that application (same as "DispVM: Firefox" entry in Qubes 3.x).

[maertsen]

For the release-notes: an additional qvm-sync-appmenus --regenerate-only vmname is needed after setting the feature before the change actually appears in the menu.

[maertsen]

For the release-notes: an additional qvm-sync-appmenus --regenerate-only vmname is needed after setting the feature before the change actually appears in the menu.