New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submodule breaks page source links #1357

Closed
andrewdavidwong opened this Issue Oct 25, 2015 · 2 comments

Comments

Projects
None yet
1 participant
@andrewdavidwong
Member

andrewdavidwong commented Oct 25, 2015

I've created links to view and edit the source of every page using the "doc" layout. These links work beautifully for pages which reside in the primary qubesos.github.io repo, but they fail for all pages which reside in submodules (e.g., qubes-doc).

Current working examples:

Current broken examples:

(Look in the upper right-hand corner for the "Source" and "Edit" links.)

@andrewdavidwong

This comment has been minimized.

Show comment
Hide comment
@andrewdavidwong

andrewdavidwong Oct 25, 2015

Member

Options:

  1. Create separate layouts for the pages in qubesos.github.io and the pages in submodules, and have the submodule layout use page.relative_path instead of page.path. But we'd still need a way to grab the correct repository_url.
  2. Move the pages in qubesos.github.io to qubes-doc, and continue to use one layout (the "doc" layout) for everything, then make the other changes stated in 1.
  3. Stop using submodules, and instead have all pages in qubesos.github.io (least likely option).
Member

andrewdavidwong commented Oct 25, 2015

Options:

  1. Create separate layouts for the pages in qubesos.github.io and the pages in submodules, and have the submodule layout use page.relative_path instead of page.path. But we'd still need a way to grab the correct repository_url.
  2. Move the pages in qubesos.github.io to qubes-doc, and continue to use one layout (the "doc" layout) for everything, then make the other changes stated in 1.
  3. Stop using submodules, and instead have all pages in qubesos.github.io (least likely option).
@andrewdavidwong

This comment has been minimized.

Show comment
Hide comment
@andrewdavidwong

andrewdavidwong Oct 25, 2015

Member

Duplicate of #1307.

Member

andrewdavidwong commented Oct 25, 2015

Duplicate of #1307.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment