/qubes-issues

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backup should notice write errors in the AppVM #1359

Closed
marmarek opened this Issue Oct 26, 2015 · 3 comments

Comments

Assignees
No one assigned
Labels
Projects
None yet
Milestone
  Release 3.0 updates
2 participants
@marmarek @unixninja92
@marmarek
Member

marmarek commented Oct 26, 2015

I assumed the backup process would do an auto-split for usability on FAT filesystems; whichever process was actually writing the file didn't notice that write() was returning EFBIG. The backup process should do an initial sanity check for disk space and file-size limits, and of course it should notice all write errors.

@marmarek marmarek added bug C: core labels Oct 26, 2015

@marmarek marmarek added this to the Release 3.0 updates milestone Oct 26, 2015

@marmarek marmarek closed this in QubesOS/qubes-core-admin@0c476f0 Nov 25, 2015

marmarek added a commit to QubesOS/qubes-core-admin that referenced this issue Nov 25, 2015

@marmarek
tests: backup to VM tests 
Regression tests for QubesOS/qubes-issues#1371 and
QubesOS/qubes-issues#1359

Fixes QubesOS/qubes-issues#1435
Verified
This commit was signed with a verified signature.
@marmarek marmarek Marek Marczykowski-Górecki
GPG key ID: 063938BA42CFA724 Learn about signing commits
db35e03

marmarek added a commit to QubesOS/qubes-core-admin that referenced this issue Jan 15, 2016

@marmarek
backup: avoid deadlock when VM process fails 
If SendWorker queue is full, check if that thread is still alive.
Otherwise it would deadlock on putting an entry to that queue.
This also requires that SendWorker must ensure that the main thread
isn't currently waiting for queue space when it fails. We can do this by
simply removing an entry from a queue - so on the next iteration
SendWorker would be already dead and main thread would notice it.
Getting an entry from queue in such (error) situation is harmless,
because other checks will notice it's an error condition.

Fixes QubesOS/qubes-issues#1359

(cherry picked from commit 0c476f0)
Verified
This commit was signed with a verified signature.
@marmarek marmarek Marek Marczykowski-Górecki
GPG key ID: 063938BA42CFA724 Learn about signing commits
3e388c7

marmarek added a commit to QubesOS/qubes-core-admin that referenced this issue Jan 15, 2016

@marmarek
tests: backup to VM tests 
Regression tests for QubesOS/qubes-issues#1371 and
QubesOS/qubes-issues#1359

Fixes QubesOS/qubes-issues#1435

(cherry picked from commit db35e03)
Verified
This commit was signed with a verified signature.
@marmarek marmarek Marek Marczykowski-Górecki
GPG key ID: 063938BA42CFA724 Learn about signing commits
163f9b1
@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Jan 15, 2016

Member

Automated announcement from builder-github

The package qubes-core-dom0-3.0.27-1.fc20 has been pushed to the r3.0 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update
Member

marmarek commented Jan 15, 2016

Automated announcement from builder-github

The package qubes-core-dom0-3.0.27-1.fc20 has been pushed to the r3.0 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

@marmarek marmarek added the r3.0-dom0-testing label Jan 15, 2016

@unixninja92

This comment has been minimized.

Show comment
Hide comment
@unixninja92

unixninja92 Mar 13, 2016

Still had issues with this in 3.0.

unixninja92 commented Mar 13, 2016

Still had issues with this in 3.0.
@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 13, 2016

Member

Automated announcement from builder-github

The package qubes-core-dom0-3.0.28-1.fc20 has been pushed to the r3.0 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update
Member

marmarek commented Mar 13, 2016

Automated announcement from builder-github

The package qubes-core-dom0-3.0.28-1.fc20 has been pushed to the r3.0 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

@marmarek marmarek added r3.0-dom0-stable and removed r3.0-dom0-testing labels Mar 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment