New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange directory layout after restoring a VM to preexisting directory #1386

Closed
marmarek opened this Issue Nov 6, 2015 · 2 comments

Comments

Projects
None yet
1 participant
@marmarek
Member

marmarek commented Nov 6, 2015

https://groups.google.com/d/msgid/qubes-users/084d6750-bd02-426c-a966-60096ca53f17%40googlegroups.com

I backed up and restored on the same version -- R3.0 to R3.0. No
encryption options were selected for this as it wasn't for archival
purposes, only transitioning to a new system. The restore system said that
there were errors and root.img could not be restored, but as you say, there
should not have been a root.img file; however, the restore process thought
that there was one. All the AppVMs that had the root.img error in the
restore did not restore and had to be recreated with qvm-create and then
files were copied into the new VM, because they did not exist.

The fedora-21 template image also had restore issues and the actual files
for the template ended up in
/var/lib/qubes/vm-templates/fedora-21/fedora-21 and had to be relocated one
folder up, so there is a definite restore problem somewhere.

I think this was because directory /var/lib/qubes/vm-templates/fedora-21
already was there. If you'd remove/move it before restoring (or not
exclude 'fedora-21' from restoring), it would just work. Anyway this is
clearly a bug.

@marmarek marmarek added this to the Release 3.0 updates milestone Nov 6, 2015

@marmarek marmarek self-assigned this Nov 7, 2015

marmarek added a commit to QubesOS/qubes-core-admin that referenced this issue Nov 7, 2015

marmarek added a commit to QubesOS/qubes-core-admin that referenced this issue Nov 15, 2015

backup: move existing directories out of the way during restore
In most cases it would be some leftover after failed restore, or even
the reason why the user is restoring a VM in the first place. Move it to
nearby directory, but do not remove - backup tool should _never_ remove
any data.

When the pre-existing directory would not be moved, restore utility
(`shutil.move`) would place the data inside of that directory, with
additional directory level (for example `/var/lib/qubes/appvms/work/work`),
which would be wrong and would later fail on `vm.verify_files`. And more
importantly - such VM would not work.

Fixes QubesOS/qubes-issues#1386

(cherry picked from commit 8275e82)

marmarek added a commit to QubesOS/qubes-core-admin that referenced this issue Nov 15, 2015

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Nov 15, 2015

Member

Automated announcement from builder-github

The package qubes-core-dom0-3.0.26-1.fc20 has been pushed to the r3.0 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

Member

marmarek commented Nov 15, 2015

Automated announcement from builder-github

The package qubes-core-dom0-3.0.26-1.fc20 has been pushed to the r3.0 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Nov 29, 2015

Member

Automated announcement from builder-github

The package qubes-core-dom0-3.0.26-1.fc20 has been pushed to the r3.0 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

Member

marmarek commented Nov 29, 2015

Automated announcement from builder-github

The package qubes-core-dom0-3.0.26-1.fc20 has been pushed to the r3.0 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment