New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI daemon spin in endless loop, holding appviewer.lock when VM died (sometimes) #1406

Closed
marmarek opened this Issue Nov 11, 2015 · 3 comments

Comments

Projects
None yet
2 participants
@marmarek
Member

marmarek commented Nov 11, 2015

It happens only sometimes, but is pretty bad then - all the windows are frozen.
Actually I can reproduce it only using our automated tests, never happened on
real usage.

Backtrace:

#0  0x00007fc83c0b7fb0 in _XReply () from /lib64/libX11.so.6
#1  0x00007fc83c0b3a2d in XSync () from /lib64/libX11.so.6
#2  0x000056364e3b66a2 in release_mapped_mfns.part.1.constprop ()
#3  0x000056364e3b672f in release_all_mapped_mfns ()
#4  0x00007fc83a5890e9 in __run_exit_handlers (status=1, listp=0x7fc83a9076c8 <__exit_funcs>, run_list_atexit=run_list_atexit@entry=true) at exit.c:82
#5  0x00007fc83a589135 in __GI_exit (status=<optimized out>) at exit.c:104
#6  0x000056364e3b5403 in x11_error_handler ()
#7  0x00007fc83c0ba0bb in _XError () from /lib64/libX11.so.6
#8  0x00007fc83c0b70b7 in handle_error () from /lib64/libX11.so.6
#9  0x00007fc83c0b7175 in handle_response () from /lib64/libX11.so.6
#10 0x00007fc83c0b8100 in _XReply () from /lib64/libX11.so.6
#11 0x00007fc83c0b3a2d in XSync () from /lib64/libX11.so.6
#12 0x000056364e3b7d28 in handle_mfndump.constprop ()
#13 0x000056364e3b3ecc in main ()

guid log:

ErrorHandler: BadAccess (attempt to access private resource denied)
                 Major opcode: 130 (MIT-SHM)
                 Minor opcode: 1 (X_ShmAttach)
                 ResourceID:   0x1a000d0
                 Failed serial number:  117
                 Current serial number: 118
@adrelanos

This comment has been minimized.

Show comment
Hide comment
@adrelanos

adrelanos Nov 11, 2015

Member

I had some "all windows freeze" issues some times after boot. Didn't
investigate. Perhaps it was this issue. So I would say this is critical
and very much worth fixing.

Member

adrelanos commented Nov 11, 2015

I had some "all windows freeze" issues some times after boot. Didn't
investigate. Perhaps it was this issue. So I would say this is critical
and very much worth fixing.

marmarek added a commit to QubesOS/qubes-gui-daemon that referenced this issue Nov 13, 2015

Do not make X11 requests in X11 error handler
Call graph:
x11_error_handler
  exit(1)
    release_all_mapped_mfns (registerd with atexit)
      release_mapped_mfns
        inter_appviewer_lock(g, 1)
        XShmDetach
        XSync -> boom (endless loop)

Since GUI daemon is just terminating, only release SHM id in such case
and let X server clean the rest.

Fixes QubesOS/qubes-issues#1406

(cherry picked from commit 2148a00)
@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Nov 14, 2015

Member

Automated announcement from builder-github

The package qubes-gui-dom0-3.0.9-1.fc20 has been pushed to the r3.0 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

Member

marmarek commented Nov 14, 2015

Automated announcement from builder-github

The package qubes-gui-dom0-3.0.9-1.fc20 has been pushed to the r3.0 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Nov 29, 2015

Member

Automated announcement from builder-github

The package qubes-gui-dom0-3.0.9-1.fc20 has been pushed to the r3.0 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

Member

marmarek commented Nov 29, 2015

Automated announcement from builder-github

The package qubes-gui-dom0-3.0.9-1.fc20 has been pushed to the r3.0 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment