New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove appmenus of uninstalled applications #1411

Closed
marmarek opened this Issue Nov 12, 2015 · 5 comments

Comments

Projects
None yet
2 participants
@marmarek
Member

marmarek commented Nov 12, 2015

Follow up from #1397

As far I know, Qubes doesn't remove default whitelisted Qubes menu entries if those are removed in a newer template. If you want such a feature (could be difficult), please report a bug [or feature request?] against Qubes.

@adrelanos

@marmarek marmarek added this to the Release 3.1 milestone Nov 12, 2015

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Nov 12, 2015

Member

Doesn't look to be hard. It will not clean whitelisted-appmenus.list file, but will clean actual desktop files.

Member

marmarek commented Nov 12, 2015

Doesn't look to be hard. It will not clean whitelisted-appmenus.list file, but will clean actual desktop files.

@adrelanos

This comment has been minimized.

Show comment
Hide comment
@adrelanos

adrelanos Nov 12, 2015

Member

Remove appmenus of uninstalled applications

Perhaps the title is wrong.

Remove appmenus of uninstalled applications

Dunno if this is implemented. But what I meant, if whitelisted-appmenus.list appmenus changed in a later version [of the template], these changes are not reflected.

I think this is because by default template packages in dom0 aren't upgraded. (This would undo any user changes.)

"Only" the "inner" of a template is upgraded by installing newer packages.

I think it would require quite some work to "not update template packages" + "yet update whitelisted-appmenus.list appmenus".

Member

adrelanos commented Nov 12, 2015

Remove appmenus of uninstalled applications

Perhaps the title is wrong.

Remove appmenus of uninstalled applications

Dunno if this is implemented. But what I meant, if whitelisted-appmenus.list appmenus changed in a later version [of the template], these changes are not reflected.

I think this is because by default template packages in dom0 aren't upgraded. (This would undo any user changes.)

"Only" the "inner" of a template is upgraded by installing newer packages.

I think it would require quite some work to "not update template packages" + "yet update whitelisted-appmenus.list appmenus".

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Nov 12, 2015

Member

On Thu, Nov 12, 2015 at 11:02:13AM -0800, Patrick Schleizer wrote:

Remove appmenus of uninstalled applications

Dunno if this is implemented.

It is not, actually (so this ticket still stands).

But what I meant, if whitelisted-appmenus.list appmenus changed in a later version [of the template], these changes are not reflected.

I see, I misunderstood. And probably in-pace Whonix upgrade will not
remove any application (#1397), right? Maybe some apt-get autoremove
will do the trick?

I think this is because by default template packages in dom0 aren't upgraded. (This would undo any user changes.)

"Only" the "inner" of a template is upgraded by installing newer packages.

I think it would require quite some work to "not update template packages" + "yet update whitelisted-appmenus.list appmenus".

Yes, whitelisted-appmenus.list will not be updated. You're right -
this is difficult.

Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?

Member

marmarek commented Nov 12, 2015

On Thu, Nov 12, 2015 at 11:02:13AM -0800, Patrick Schleizer wrote:

Remove appmenus of uninstalled applications

Dunno if this is implemented.

It is not, actually (so this ticket still stands).

But what I meant, if whitelisted-appmenus.list appmenus changed in a later version [of the template], these changes are not reflected.

I see, I misunderstood. And probably in-pace Whonix upgrade will not
remove any application (#1397), right? Maybe some apt-get autoremove
will do the trick?

I think this is because by default template packages in dom0 aren't upgraded. (This would undo any user changes.)

"Only" the "inner" of a template is upgraded by installing newer packages.

I think it would require quite some work to "not update template packages" + "yet update whitelisted-appmenus.list appmenus".

Yes, whitelisted-appmenus.list will not be updated. You're right -
this is difficult.

Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?

@adrelanos

This comment has been minimized.

Show comment
Hide comment
@adrelanos

adrelanos Nov 12, 2015

Member

Marek Marczykowski-Górecki:

On Thu, Nov 12, 2015 at 11:02:13AM -0800, Patrick Schleizer wrote:

Remove appmenus of uninstalled applications

Dunno if this is implemented.

It is not, actually (so this ticket still stands).

Ok.

But what I meant, if whitelisted-appmenus.list appmenus changed in a later version [of the template], these changes are not reflected.

I see, I misunderstood.

And probably in-pace Whonix upgrade will not
remove any application (#1397), right? Maybe some apt-get autoremove
will do the trick?

Answered here:
#1397 (comment)

I think this is because by default template packages in dom0 aren't upgraded. (This would undo any user changes.)

"Only" the "inner" of a template is upgraded by installing newer packages.

I think it would require quite some work to "not update template packages" + "yet update whitelisted-appmenus.list appmenus".

Yes, whitelisted-appmenus.list will not be updated. You're right -
this is difficult.

I dunno if you want a separate ticket for this. I hope not. :) Seems
like a lot work. You'd have to split the template packages then.

  • qubes-template-x (depending on qubes-template-x-image and
    qubes-template-x-meta) (what gets installed by most users)
  • qubes-template-x-image (the raw image) (blocked from updating as of now)
  • qubes-template-x-meta (whitelisted appmenus and other similar small
    configuration files) (upgraded more often)

Not that bad an idea imho, but I wonder if things would get too complex
for this to be worth it. Maybe some day far in the future.

Another option might be to ship whitelisted-appmenus.list and alike
files within the raw image. Would be less secure?

Member

adrelanos commented Nov 12, 2015

Marek Marczykowski-Górecki:

On Thu, Nov 12, 2015 at 11:02:13AM -0800, Patrick Schleizer wrote:

Remove appmenus of uninstalled applications

Dunno if this is implemented.

It is not, actually (so this ticket still stands).

Ok.

But what I meant, if whitelisted-appmenus.list appmenus changed in a later version [of the template], these changes are not reflected.

I see, I misunderstood.

And probably in-pace Whonix upgrade will not
remove any application (#1397), right? Maybe some apt-get autoremove
will do the trick?

Answered here:
#1397 (comment)

I think this is because by default template packages in dom0 aren't upgraded. (This would undo any user changes.)

"Only" the "inner" of a template is upgraded by installing newer packages.

I think it would require quite some work to "not update template packages" + "yet update whitelisted-appmenus.list appmenus".

Yes, whitelisted-appmenus.list will not be updated. You're right -
this is difficult.

I dunno if you want a separate ticket for this. I hope not. :) Seems
like a lot work. You'd have to split the template packages then.

  • qubes-template-x (depending on qubes-template-x-image and
    qubes-template-x-meta) (what gets installed by most users)
  • qubes-template-x-image (the raw image) (blocked from updating as of now)
  • qubes-template-x-meta (whitelisted appmenus and other similar small
    configuration files) (upgraded more often)

Not that bad an idea imho, but I wonder if things would get too complex
for this to be worth it. Maybe some day far in the future.

Another option might be to ship whitelisted-appmenus.list and alike
files within the raw image. Would be less secure?

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Nov 12, 2015

Member

On Thu, Nov 12, 2015 at 11:32:45AM -0800, Patrick Schleizer wrote:

Another option might be to ship whitelisted-appmenus.list and alike
files within the raw image. Would be less secure?

Ideally we would ship templates as the (integrity protected) raw image
and nothing more, and treat it in dom0 as a black box. This is why we
don't ship pre-generated appmenus and start the template to retrieve
them during template installation (not mount it's root.img in dom0!).
Maybe similar approach can be used for default appmenus list (somewhere
in the future)? Anyway this still doesn't update
whitelisted-appmenus.list of already created TemplateBasedVMs - which
is still difficult because of user changes.

Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?

Member

marmarek commented Nov 12, 2015

On Thu, Nov 12, 2015 at 11:32:45AM -0800, Patrick Schleizer wrote:

Another option might be to ship whitelisted-appmenus.list and alike
files within the raw image. Would be less secure?

Ideally we would ship templates as the (integrity protected) raw image
and nothing more, and treat it in dom0 as a black box. This is why we
don't ship pre-generated appmenus and start the template to retrieve
them during template installation (not mount it's root.img in dom0!).
Maybe similar approach can be used for default appmenus list (somewhere
in the future)? Anyway this still doesn't update
whitelisted-appmenus.list of already created TemplateBasedVMs - which
is still difficult because of user changes.

Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment