New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgmt: qvm.start() should not start guid unconditionally #1464

Closed
marmarek opened this Issue Nov 29, 2015 · 1 comment

Comments

Projects
None yet
1 participant
@marmarek
Member

marmarek commented Nov 29, 2015

Currently it does. Which of course fails when called from firstboot.
https://github.com/QubesOS/qubes-mgmt-salt-dom0-qvm/blob/master/_modules/ext_module_qvm.py#L1330-L1347

    def is_transient():
        '''
        Start guid if VM is `transient`.
        '''
        transient_status = state(args.vmname, *['transient'])
        if transient_status.passed():
            if __opts__['test']:
                message = '\'guid\' will be started since in \'transient\' state!'
                qvm.save_status(transient_status, message=message)
                return qvm.status()

            # 'start_guid' then confirm 'running' power state
            start_guid()
            return not is_running(
                qvm,
                error_message='\'guid\' failed to start!'
            )
        return False

@marmarek marmarek added this to the Release 3.1 milestone Nov 29, 2015

@marmarek marmarek added the C: mgmt label Nov 29, 2015

@marmarek marmarek modified the milestones: Release 4.0, Release 3.1 Feb 8, 2016

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Jul 13, 2017

Member

Done.

Member

marmarek commented Jul 13, 2017

Done.

@marmarek marmarek closed this Jul 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment