New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qubes-dom0-update: report when there are no updates available #1475

Closed
andrewdavidwong opened this Issue Dec 1, 2015 · 30 comments

Comments

@andrewdavidwong
Member

andrewdavidwong commented Dec 1, 2015

Currently, when sys-firewall is based on fedora-23-minimal, there is no feedback indicating whether qubes-dom0-updates simply found no updates or whether it completely failed for some other reason:

[user@dom0 ~]$ sudo qubes-dom0-update
Using sys-firewall as UpdateVM to download updates for Dom0; this may take some time...
Running command on VM: 'sys-firewall'...
Checking for dom0 updates...
Yum command has been deprecated, use dnf instead.
See 'man dnf' and 'man yum2dnf' for more information.

[user@dom0 ~]$

(Or maybe qubes-dom0-update really is failing here because it's trying to use yum instead of dnf, in which case this ticket is really about that.)

@v6ak

This comment has been minimized.

Show comment
Hide comment
@v6ak

v6ak Dec 4, 2015

My experience suggests that the update script works, although it complains about this. But I agree that this is somewhat more than just a cosmetic issue, as it makes some confusion.

v6ak commented Dec 4, 2015

My experience suggests that the update script works, although it complains about this. But I agree that this is somewhat more than just a cosmetic issue, as it makes some confusion.

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Dec 4, 2015

Member

This (text about deprecated yum) is quite hard to solve, because yum in F23 unconditionally prints that text, but dnf have some missing features/bugs making it hardly useful for dom0 updates:
https://bugzilla.redhat.com/show_bug.cgi?id=1279001
https://bugzilla.redhat.com/show_bug.cgi?id=1227014

Member

marmarek commented Dec 4, 2015

This (text about deprecated yum) is quite hard to solve, because yum in F23 unconditionally prints that text, but dnf have some missing features/bugs making it hardly useful for dom0 updates:
https://bugzilla.redhat.com/show_bug.cgi?id=1279001
https://bugzilla.redhat.com/show_bug.cgi?id=1227014

@andrewdavidwong

This comment has been minimized.

Show comment
Hide comment
@andrewdavidwong

andrewdavidwong Dec 4, 2015

Member

IMHO, the text about yum/dnf is not the problem. You can just leave it there. The problem, rather, is that there is no text after that to tell the user "No updates found." Instead, the user is just left to wonder whether there was some error preventing the system from even checking for updates in the first place (or downloading them, or installing them, etc.).

Member

andrewdavidwong commented Dec 4, 2015

IMHO, the text about yum/dnf is not the problem. You can just leave it there. The problem, rather, is that there is no text after that to tell the user "No updates found." Instead, the user is just left to wonder whether there was some error preventing the system from even checking for updates in the first place (or downloading them, or installing them, etc.).

@marmarek marmarek added this to the Release 3.0 updates milestone Dec 4, 2015

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Dec 4, 2015

Member

Ah, I see. Will look into that.

Member

marmarek commented Dec 4, 2015

Ah, I see. Will look into that.

@v6ak

This comment has been minimized.

Show comment
Hide comment
@v6ak

v6ak Dec 5, 2015

Maybe some hack like the following would be good enough:

… | grep -vE '^(Yum command has been deprecated, use dnf instead\.|See \'man dnf\' and \'man yum2dnf\' for more information\.)$'

v6ak commented Dec 5, 2015

Maybe some hack like the following would be good enough:

… | grep -vE '^(Yum command has been deprecated, use dnf instead\.|See \'man dnf\' and \'man yum2dnf\' for more information\.)$'
@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Dec 5, 2015

Member

On Sat, Dec 05, 2015 at 03:16:01AM -0800, Vít Šesták wrote:

Maybe some hack like the following would be good enough:

… | grep -vE '^(Yum command has been deprecated, use dnf instead\.|See \'man dnf\' and \'man yum2dnf\' for more information\.)$'

Do you know how to do it, without merging stdout and stderr?

Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?

Member

marmarek commented Dec 5, 2015

On Sat, Dec 05, 2015 at 03:16:01AM -0800, Vít Šesták wrote:

Maybe some hack like the following would be good enough:

… | grep -vE '^(Yum command has been deprecated, use dnf instead\.|See \'man dnf\' and \'man yum2dnf\' for more information\.)$'

Do you know how to do it, without merging stdout and stderr?

Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?

@v6ak

This comment has been minimized.

Show comment
Hide comment
@v6ak

v6ak Dec 5, 2015

Hmm, without merging stderr+stdout, it is not so easy, but still doable: https://gist.github.com/v6ak/58097ef190157d573646

But I understand it is not so simple hack now.

v6ak commented Dec 5, 2015

Hmm, without merging stderr+stdout, it is not so easy, but still doable: https://gist.github.com/v6ak/58097ef190157d573646

But I understand it is not so simple hack now.

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Dec 26, 2015

Member

Automated announcement from builder-github

The package python2-dnf-plugins-qubes-hooks-3.1.9-1.fc21 has been pushed to the r3.1 testing repository for the Fedora fc21 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r3.1-current-testing

Changes included in this update

Member

marmarek commented Dec 26, 2015

Automated announcement from builder-github

The package python2-dnf-plugins-qubes-hooks-3.1.9-1.fc21 has been pushed to the r3.1 testing repository for the Fedora fc21 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r3.1-current-testing

Changes included in this update

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Dec 26, 2015

Member

Automated announcement from builder-github

The package python2-dnf-plugins-qubes-hooks-3.1.9-1.fc22 has been pushed to the r3.1 testing repository for the Fedora fc22 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r3.1-current-testing

Changes included in this update

Member

marmarek commented Dec 26, 2015

Automated announcement from builder-github

The package python2-dnf-plugins-qubes-hooks-3.1.9-1.fc22 has been pushed to the r3.1 testing repository for the Fedora fc22 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r3.1-current-testing

Changes included in this update

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Dec 26, 2015

Member

Automated announcement from builder-github

The package python2-dnf-plugins-qubes-hooks-3.1.9-1.fc23 has been pushed to the r3.1 testing repository for the Fedora fc23 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r3.1-current-testing

Changes included in this update

Member

marmarek commented Dec 26, 2015

Automated announcement from builder-github

The package python2-dnf-plugins-qubes-hooks-3.1.9-1.fc23 has been pushed to the r3.1 testing repository for the Fedora fc23 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r3.1-current-testing

Changes included in this update

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Dec 26, 2015

Member

Automated announcement from builder-github

The package qubes-core-agent_3.1.9-1+deb8u1 has been pushed to the r3.1 testing repository for the Debian jessie template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing jessie-testing, then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

Member

marmarek commented Dec 26, 2015

Automated announcement from builder-github

The package qubes-core-agent_3.1.9-1+deb8u1 has been pushed to the r3.1 testing repository for the Debian jessie template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing jessie-testing, then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Dec 26, 2015

Member

Automated announcement from builder-github

The package qubes-core-agent_3.1.9-1+deb9u1 has been pushed to the r3.1 testing repository for the Debian stretch template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing stretch-testing, then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

Member

marmarek commented Dec 26, 2015

Automated announcement from builder-github

The package qubes-core-agent_3.1.9-1+deb9u1 has been pushed to the r3.1 testing repository for the Debian stretch template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing stretch-testing, then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Dec 26, 2015

Member

Automated announcement from builder-github

The package qubes-core-agent_3.1.9-1+deb7u1 has been pushed to the r3.1 testing repository for the Debian wheezy template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing wheezy-testing, then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

Member

marmarek commented Dec 26, 2015

Automated announcement from builder-github

The package qubes-core-agent_3.1.9-1+deb7u1 has been pushed to the r3.1 testing repository for the Debian wheezy template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing wheezy-testing, then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Jan 12, 2016

Member

Automated announcement from builder-github

The package python2-dnf-plugins-qubes-hooks-3.1.12-1.fc21 has been pushed to the r3.1 stable repository for the Fedora fc21 template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

Member

marmarek commented Jan 12, 2016

Automated announcement from builder-github

The package python2-dnf-plugins-qubes-hooks-3.1.12-1.fc21 has been pushed to the r3.1 stable repository for the Fedora fc21 template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Jan 12, 2016

Member

Automated announcement from builder-github

The package python2-dnf-plugins-qubes-hooks-3.1.12-1.fc22 has been pushed to the r3.1 stable repository for the Fedora fc22 template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

Member

marmarek commented Jan 12, 2016

Automated announcement from builder-github

The package python2-dnf-plugins-qubes-hooks-3.1.12-1.fc22 has been pushed to the r3.1 stable repository for the Fedora fc22 template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Jan 12, 2016

Member

Automated announcement from builder-github

The package python2-dnf-plugins-qubes-hooks-3.1.12-1.fc23 has been pushed to the r3.1 stable repository for the Fedora fc23 template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

Member

marmarek commented Jan 12, 2016

Automated announcement from builder-github

The package python2-dnf-plugins-qubes-hooks-3.1.12-1.fc23 has been pushed to the r3.1 stable repository for the Fedora fc23 template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Jan 13, 2016

Member

Automated announcement from builder-github

The package qubes-core-agent_3.1.12-1+deb8u1 has been pushed to the r3.1 stable repository for the Debian jessie template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

Member

marmarek commented Jan 13, 2016

Automated announcement from builder-github

The package qubes-core-agent_3.1.12-1+deb8u1 has been pushed to the r3.1 stable repository for the Debian jessie template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Jan 13, 2016

Member

Automated announcement from builder-github

The package qubes-core-agent_3.1.12-1+deb7u1 has been pushed to the r3.1 stable repository for the Debian wheezy template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

Member

marmarek commented Jan 13, 2016

Automated announcement from builder-github

The package qubes-core-agent_3.1.12-1+deb7u1 has been pushed to the r3.1 stable repository for the Debian wheezy template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

marmarek added a commit to QubesOS/qubes-core-agent-linux that referenced this issue Feb 29, 2016

dom0-updates: fix reporting when no updates are available
Check `yum check-update` exit code, instead of `grep` - when there are
multiple commands on the single line, $? contains exit code of the last
executed.

Fixes QubesOS/qubes-issues#1475

(cherry picked from commit c46c1e4)
@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Feb 29, 2016

Member

Automated announcement from builder-github

The package qubes-core-agent_3.0.25-1+deb8u1 has been pushed to the r3.0 testing repository for the Debian jessie template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing jessie-testing, then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

Member

marmarek commented Feb 29, 2016

Automated announcement from builder-github

The package qubes-core-agent_3.0.25-1+deb8u1 has been pushed to the r3.0 testing repository for the Debian jessie template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing jessie-testing, then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Feb 29, 2016

Member

Automated announcement from builder-github

The package qubes-core-agent_3.0.25-1+deb7u1 has been pushed to the r3.0 testing repository for the Debian wheezy template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing wheezy-testing, then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

Member

marmarek commented Feb 29, 2016

Automated announcement from builder-github

The package qubes-core-agent_3.0.25-1+deb7u1 has been pushed to the r3.0 testing repository for the Debian wheezy template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing wheezy-testing, then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Feb 29, 2016

Member

Automated announcement from builder-github

The package python2-dnf-plugins-qubes-hooks-3.0.25-1.fc20 has been pushed to the r3.0 testing repository for the Fedora fc20 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r3.0-current-testing

Changes included in this update

Member

marmarek commented Feb 29, 2016

Automated announcement from builder-github

The package python2-dnf-plugins-qubes-hooks-3.0.25-1.fc20 has been pushed to the r3.0 testing repository for the Fedora fc20 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r3.0-current-testing

Changes included in this update

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Feb 29, 2016

Member

Automated announcement from builder-github

The package python2-dnf-plugins-qubes-hooks-3.0.25-1.fc21 has been pushed to the r3.0 testing repository for the Fedora fc21 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r3.0-current-testing

Changes included in this update

Member

marmarek commented Feb 29, 2016

Automated announcement from builder-github

The package python2-dnf-plugins-qubes-hooks-3.0.25-1.fc21 has been pushed to the r3.0 testing repository for the Fedora fc21 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r3.0-current-testing

Changes included in this update

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Feb 29, 2016

Member

Automated announcement from builder-github

The package python2-dnf-plugins-qubes-hooks-3.0.25-1.fc22 has been pushed to the r3.0 testing repository for the Fedora fc22 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r3.0-current-testing

Changes included in this update

Member

marmarek commented Feb 29, 2016

Automated announcement from builder-github

The package python2-dnf-plugins-qubes-hooks-3.0.25-1.fc22 has been pushed to the r3.0 testing repository for the Fedora fc22 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r3.0-current-testing

Changes included in this update

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Feb 29, 2016

Member

Automated announcement from builder-github

The package python2-dnf-plugins-qubes-hooks-3.0.25-1.fc23 has been pushed to the r3.0 testing repository for the Fedora fc23 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r3.0-current-testing

Changes included in this update

Member

marmarek commented Feb 29, 2016

Automated announcement from builder-github

The package python2-dnf-plugins-qubes-hooks-3.0.25-1.fc23 has been pushed to the r3.0 testing repository for the Fedora fc23 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r3.0-current-testing

Changes included in this update

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 10, 2016

Member

Automated announcement from builder-github

The package python2-dnf-plugins-qubes-hooks-3.0.25-1.fc20 has been pushed to the r3.0 stable repository for the Fedora fc20 template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

Member

marmarek commented Mar 10, 2016

Automated announcement from builder-github

The package python2-dnf-plugins-qubes-hooks-3.0.25-1.fc20 has been pushed to the r3.0 stable repository for the Fedora fc20 template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 10, 2016

Member

Automated announcement from builder-github

The package python2-dnf-plugins-qubes-hooks-3.0.25-1.fc21 has been pushed to the r3.0 stable repository for the Fedora fc21 template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

Member

marmarek commented Mar 10, 2016

Automated announcement from builder-github

The package python2-dnf-plugins-qubes-hooks-3.0.25-1.fc21 has been pushed to the r3.0 stable repository for the Fedora fc21 template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 10, 2016

Member

Automated announcement from builder-github

The package python2-dnf-plugins-qubes-hooks-3.0.25-1.fc22 has been pushed to the r3.0 stable repository for the Fedora fc22 template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

Member

marmarek commented Mar 10, 2016

Automated announcement from builder-github

The package python2-dnf-plugins-qubes-hooks-3.0.25-1.fc22 has been pushed to the r3.0 stable repository for the Fedora fc22 template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 10, 2016

Member

Automated announcement from builder-github

The package python2-dnf-plugins-qubes-hooks-3.0.25-1.fc23 has been pushed to the r3.0 stable repository for the Fedora fc23 template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

Member

marmarek commented Mar 10, 2016

Automated announcement from builder-github

The package python2-dnf-plugins-qubes-hooks-3.0.25-1.fc23 has been pushed to the r3.0 stable repository for the Fedora fc23 template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 13, 2016

Member

Automated announcement from builder-github

The package qubes-core-agent_3.0.25-1+deb8u1 has been pushed to the r3.0 stable repository for the Debian jessie template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

Member

marmarek commented Mar 13, 2016

Automated announcement from builder-github

The package qubes-core-agent_3.0.25-1+deb8u1 has been pushed to the r3.0 stable repository for the Debian jessie template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 13, 2016

Member

Automated announcement from builder-github

The package qubes-core-agent_3.0.25-1+deb7u1 has been pushed to the r3.0 stable repository for the Debian wheezy template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

Member

marmarek commented Mar 13, 2016

Automated announcement from builder-github

The package qubes-core-agent_3.0.25-1+deb7u1 has been pushed to the r3.0 stable repository for the Debian wheezy template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment