New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically show icon next to all external links #1478

Open
andrewdavidwong opened this Issue Dec 2, 2015 · 8 comments

Comments

Projects
None yet
5 participants
@andrewdavidwong
Member

andrewdavidwong commented Dec 2, 2015

Should our website clearly distinguish external links (e.g., the way Wikipedia does)? If so, does anyone know the best way to do that given the way the site is set up?

@adrelanos

This comment has been minimized.

Show comment
Hide comment
@adrelanos

adrelanos Dec 2, 2015

Member

Axon:

Should our website clearly distinguish external links (e.g., the way Wikipedia does)?

Yes.

Member

adrelanos commented Dec 2, 2015

Axon:

Should our website clearly distinguish external links (e.g., the way Wikipedia does)?

Yes.

@andrewdavidwong

This comment has been minimized.

Show comment
Hide comment
@andrewdavidwong

andrewdavidwong Dec 3, 2015

Member

@bnvk, any ideas about how best to do this?

Member

andrewdavidwong commented Dec 3, 2015

@bnvk, any ideas about how best to do this?

@bnvk

This comment has been minimized.

Show comment
Hide comment
@bnvk

bnvk Dec 3, 2015

I like this idea a lot. I suggest adding the external-link icon that's in FontAwesome, which we're using!

bnvk commented Dec 3, 2015

I like this idea a lot. I suggest adding the external-link icon that's in FontAwesome, which we're using!

@andrewdavidwong

This comment has been minimized.

Show comment
Hide comment
@andrewdavidwong

andrewdavidwong Dec 3, 2015

Member

Right, but is there any way to make that icon appear automatically next to external links? I think that's the only way it's going to happen in a useful way. I don't think we can rely on anyone marking up their URLs in source to distinguish external links. Even if we tried to, I have a feeling the results would be very inconsistent (lots of links which are actually external but failed to be manually marked-up that way, resulting in many users being misled, which would arguably be worse than not distinguishing links at all).

Member

andrewdavidwong commented Dec 3, 2015

Right, but is there any way to make that icon appear automatically next to external links? I think that's the only way it's going to happen in a useful way. I don't think we can rely on anyone marking up their URLs in source to distinguish external links. Even if we tried to, I have a feeling the results would be very inconsistent (lots of links which are actually external but failed to be manually marked-up that way, resulting in many users being misled, which would arguably be worse than not distinguishing links at all).

@bnvk

This comment has been minimized.

Show comment
Hide comment
@bnvk

bnvk Dec 3, 2015

is there any way to make that icon appear automatically next to external links?

Yes, I hear your point about consistency and not requiring people to tag it. This is ideal, for sure. The easiest way would be to use javascript- i'm not sure if that is "OK" with the team, as a lot of security projects are anti JS. A non-JS way might be with some custom Jekyll module written in Ruby or perhaps a flag in the Jekyll interpreter?

bnvk commented Dec 3, 2015

is there any way to make that icon appear automatically next to external links?

Yes, I hear your point about consistency and not requiring people to tag it. This is ideal, for sure. The easiest way would be to use javascript- i'm not sure if that is "OK" with the team, as a lot of security projects are anti JS. A non-JS way might be with some custom Jekyll module written in Ruby or perhaps a flag in the Jekyll interpreter?

@andrewdavidwong

This comment has been minimized.

Show comment
Hide comment
@andrewdavidwong

andrewdavidwong Dec 3, 2015

Member

Yeah, I think a non-JS way would be preferable. Good ideas.

Member

andrewdavidwong commented Dec 3, 2015

Yeah, I think a non-JS way would be preferable. Good ideas.

@marmarek marmarek added this to the Documentation/website milestone Jan 6, 2016

@Jeeppler

This comment has been minimized.

Show comment
Hide comment
@Jeeppler

Jeeppler May 10, 2016

Was there any progress on this issue till now? Any solution considered?

Was there any progress on this issue till now? Any solution considered?

@andrewdavidwong

This comment has been minimized.

Show comment
Hide comment
@andrewdavidwong

andrewdavidwong May 10, 2016

Member

As far as I know, there has been no additional progress on this. Help is still wanted.

Member

andrewdavidwong commented May 10, 2016

As far as I know, there has been no additional progress on this. Help is still wanted.

@andrewdavidwong andrewdavidwong changed the title from Consider clearly distinguishing external links to Automatically show icon next to all external links Oct 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment