Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAutomatically show icon next to all external links #1478
Comments
andrewdavidwong
added
the
C: website
label
Dec 2, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
adrelanos
Dec 2, 2015
Member
Axon:
Should our website clearly distinguish external links (e.g., the way Wikipedia does)?
Yes.
|
Axon:
Yes. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
@bnvk, any ideas about how best to do this? |
andrewdavidwong
added
the
help wanted
label
Dec 3, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
bnvk
Dec 3, 2015
I like this idea a lot. I suggest adding the external-link icon that's in FontAwesome, which we're using!
bnvk
commented
Dec 3, 2015
|
I like this idea a lot. I suggest adding the external-link icon that's in FontAwesome, which we're using! |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
andrewdavidwong
Dec 3, 2015
Member
Right, but is there any way to make that icon appear automatically next to external links? I think that's the only way it's going to happen in a useful way. I don't think we can rely on anyone marking up their URLs in source to distinguish external links. Even if we tried to, I have a feeling the results would be very inconsistent (lots of links which are actually external but failed to be manually marked-up that way, resulting in many users being misled, which would arguably be worse than not distinguishing links at all).
|
Right, but is there any way to make that icon appear automatically next to external links? I think that's the only way it's going to happen in a useful way. I don't think we can rely on anyone marking up their URLs in source to distinguish external links. Even if we tried to, I have a feeling the results would be very inconsistent (lots of links which are actually external but failed to be manually marked-up that way, resulting in many users being misled, which would arguably be worse than not distinguishing links at all). |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
bnvk
Dec 3, 2015
is there any way to make that icon appear automatically next to external links?
Yes, I hear your point about consistency and not requiring people to tag it. This is ideal, for sure. The easiest way would be to use javascript- i'm not sure if that is "OK" with the team, as a lot of security projects are anti JS. A non-JS way might be with some custom Jekyll module written in Ruby or perhaps a flag in the Jekyll interpreter?
bnvk
commented
Dec 3, 2015
Yes, I hear your point about consistency and not requiring people to tag it. This is ideal, for sure. The easiest way would be to use javascript- i'm not sure if that is "OK" with the team, as a lot of security projects are anti JS. A non-JS way might be with some custom Jekyll module written in Ruby or perhaps a flag in the Jekyll interpreter? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Yeah, I think a non-JS way would be preferable. Good ideas. |
marmarek
added this to the
Documentation/website milestone
Jan 6, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Jeeppler
commented
May 10, 2016
|
Was there any progress on this issue till now? Any solution considered? |
andrewdavidwong
added
enhancement
P: major
UX
labels
May 10, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
andrewdavidwong
May 10, 2016
Member
As far as I know, there has been no additional progress on this. Help is still wanted.
|
As far as I know, there has been no additional progress on this. Help is still wanted. |
andrewdavidwong commentedDec 2, 2015
Should our website clearly distinguish external links (e.g., the way Wikipedia does)? If so, does anyone know the best way to do that given the way the site is set up?