New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qvm-open-in-vm opens URLs in non-default browser #1487

Closed
andrewdavidwong opened this Issue Dec 4, 2015 · 10 comments

Comments

Projects
None yet
4 participants
@andrewdavidwong
Member

andrewdavidwong commented Dec 4, 2015

  1. Set Thunderbird in emailvm to open links using this script:

    #!/bin/bash
    /bin/qvm-open-in-vm linkvm $1
    
  2. The default browser in linkvm is Firefox. Clicking an email link in emailvm results in Firefox opening in linkvm and going to that URL, as expected.

  3. Change the default browser in linkvm from Firefox to Google Chrome.

  4. Restart linkvm.

  5. Open another email link in emailvm. Unexpected result: link opens in Firefox again, not Chrome.

@v6ak

This comment has been minimized.

Show comment
Hide comment
@v6ak

v6ak Dec 4, 2015

This seems to be caused by wrapping HTTP links to HTML. As a result, the links are opened by default browser for HTML, not for HTTP/HTTPS/whatever.

Some details are in #1462.

v6ak commented Dec 4, 2015

This seems to be caused by wrapping HTTP links to HTML. As a result, the links are opened by default browser for HTML, not for HTTP/HTTPS/whatever.

Some details are in #1462.

@adrelanos

This comment has been minimized.

Show comment
Hide comment
@adrelanos

adrelanos Dec 4, 2015

Member

Sure this is a Qubes issue or linkvm operating system configuration issue? Configuration of the default browser is very difficult, because there are so many different places to configure this.

See, The Default Browser on Linux Debacle:
http://blog.codef00.com/2011/02/18/the-default-browser-on-linux-debacle/

There is a configuration package, that can set Tor Browser as default browser:
https://github.com/Whonix/tb-default-browser

It may be useful for reference.

Member

adrelanos commented Dec 4, 2015

Sure this is a Qubes issue or linkvm operating system configuration issue? Configuration of the default browser is very difficult, because there are so many different places to configure this.

See, The Default Browser on Linux Debacle:
http://blog.codef00.com/2011/02/18/the-default-browser-on-linux-debacle/

There is a configuration package, that can set Tor Browser as default browser:
https://github.com/Whonix/tb-default-browser

It may be useful for reference.

@andrewdavidwong

This comment has been minimized.

Show comment
Hide comment
@andrewdavidwong

andrewdavidwong Dec 5, 2015

Member

Sure this is a Qubes issue or linkvm operating system configuration issue? Configuration of the default browser is very difficult, because there are so many different places to configure this.

Indeed, it could be. But the "default browser" issue is something of a red herring. The idea is that it would constitute a good feature to let the user cause the link to open in the linkvm browser of choice (regardless of whether that browser is the default).

There is a configuration package, that can set Tor Browser as default browser

Very useful; thank you.

Member

andrewdavidwong commented Dec 5, 2015

Sure this is a Qubes issue or linkvm operating system configuration issue? Configuration of the default browser is very difficult, because there are so many different places to configure this.

Indeed, it could be. But the "default browser" issue is something of a red herring. The idea is that it would constitute a good feature to let the user cause the link to open in the linkvm browser of choice (regardless of whether that browser is the default).

There is a configuration package, that can set Tor Browser as default browser

Very useful; thank you.

@adrelanos

This comment has been minimized.

Show comment
Hide comment
@adrelanos

adrelanos Dec 5, 2015

Member

Axon:

Indeed, it could be. But the "default browser" issue is something of
a red herring. The idea is that it would constitute a good feature to
let the user cause the link to open in the linkvm browser of choice
(regardless of whether that browser is the default).

Okay. Didn't know that. That is one okay choice to implement this
feature. How is the linkvm browser setting currently configured?

Member

adrelanos commented Dec 5, 2015

Axon:

Indeed, it could be. But the "default browser" issue is something of
a red herring. The idea is that it would constitute a good feature to
let the user cause the link to open in the linkvm browser of choice
(regardless of whether that browser is the default).

Okay. Didn't know that. That is one okay choice to implement this
feature. How is the linkvm browser setting currently configured?

@andrewdavidwong

This comment has been minimized.

Show comment
Hide comment
@andrewdavidwong

andrewdavidwong Dec 5, 2015

Member

Not sure, but @v6ak said above:

This seems to be caused by wrapping HTTP links to HTML. As a result, the links are opened by default browser for HTML, not for HTTP/HTTPS/whatever.

Some details are in #1462.

Member

andrewdavidwong commented Dec 5, 2015

Not sure, but @v6ak said above:

This seems to be caused by wrapping HTTP links to HTML. As a result, the links are opened by default browser for HTML, not for HTTP/HTTPS/whatever.

Some details are in #1462.

@marmarek marmarek added this to the Release 3.1 milestone Dec 11, 2015

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Dec 11, 2015

Member

I think the solution would be to create qubes.OpenURL service and call it for URLs instead of wrapping them in HTML file.

Member

marmarek commented Dec 11, 2015

I think the solution would be to create qubes.OpenURL service and call it for URLs instead of wrapping them in HTML file.

@marmarek marmarek modified the milestones: Release 3.2, Release 3.1 Feb 8, 2016

@andrewdavidwong

This comment has been minimized.

Show comment
Hide comment
@andrewdavidwong

andrewdavidwong Apr 7, 2016

Member

Is it just me, or has this problem already been fixed in R3.1?

Member

andrewdavidwong commented Apr 7, 2016

Is it just me, or has this problem already been fixed in R3.1?

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Apr 7, 2016

Member

Maybe some side effect. But qubes.OpenURL is not yet implemented. But that can be treated as duplicate of #1462

Member

marmarek commented Apr 7, 2016

Maybe some side effect. But qubes.OpenURL is not yet implemented. But that can be treated as duplicate of #1462

marmarek added a commit to marmarek/old-qubes-core-admin that referenced this issue May 18, 2016

tests: check opening URL
While at it, fix policy preparation for qvm-open-in-vm tests.

QubesOS/qubes-issues#1487

marmarek added a commit to marmarek/old-qubes-core-admin that referenced this issue May 18, 2016

Add policy for qubes.OpenURL service
For now the same as for qubes.OpenInVM.

Fixes QubesOS/qubes-issues#1487
@adrelanos

This comment has been minimized.

Show comment
Hide comment
@adrelanos

adrelanos Jun 16, 2016

Member

qubes.OpenURL will land in Qubes Q3.2?

Member

adrelanos commented Jun 16, 2016

qubes.OpenURL will land in Qubes Q3.2?

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Jun 16, 2016

Member

On Thu, Jun 16, 2016 at 06:26:44AM -0700, Patrick Schleizer wrote:

qubes.OpenURL will land in Qubes Q3.2?

Yes.

Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?

Member

marmarek commented Jun 16, 2016

On Thu, Jun 16, 2016 at 06:26:44AM -0700, Patrick Schleizer wrote:

qubes.OpenURL will land in Qubes Q3.2?

Yes.

Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment