qvm-copy-to-vm incorrect progress report

[kirill9000]

It copies file fully, but reports in a manner like: sent 10004/10005 KB or even sent 0/1 KB for small files and that may confuse some users.

[Rudd-O]

Round up? That might be the correct answer.

[Rudd-O]

Round up? That might be the correct answer.

[bnvk]

Agree. This discrepancy has made me question if the copying was completed correctly of if some file failed to finish!

[bnvk]

Agree. This discrepancy has made me question if the copying was completed correctly of if some file failed to finish!

[unman]

@marmarek There are cases where the report is correct, so Rudd-O's proposed solution wont work.
I think the problem arises because the target figure comes from du operation on the sender, and the "progress" figure comes from the recipient, using a division in C (x/1024) to get Kb value. Division in C always truncates to zero so there will always be the possibility of discrepancy.
The only way I can think of guaranteeing there would be no discrepancy would be to write after a successfull copy , duplicating the target figure (sent TARGET of TARGET ), which is pretty monstrous.

[unman]

@marmarek There are cases where the report is correct, so Rudd-O's proposed solution wont work.
I think the problem arises because the target figure comes from du operation on the sender, and the "progress" figure comes from the recipient, using a division in C (x/1024) to get Kb value. Division in C always truncates to zero so there will always be the possibility of discrepancy.
The only way I can think of guaranteeing there would be no discrepancy would be to write after a successfull copy , duplicating the target figure (sent TARGET of TARGET ), which is pretty monstrous.