Dispvm create should _not_ create appmenus

[marmarek]

Reported by joanna on 28 Mar 2011 21:41 UTC
And currently the appmenus are created in /usr/local/share/applications and they only pollute the Start menu.

Migrated-From: https://wiki.qubes-os.org/ticket/155

[marmarek]

Comment by joanna on 29 Mar 2011 14:35 UTC
Can we remove the %{template}-dvm VM after we create the savefile?

It would be ideal, so that we would not need to display this (otherwise useless) VM in the manager (which only confuses the user).

[marmarek]

Comment by joanna on 29 Mar 2011 14:35 UTC
Can we remove the %{template}-dvm VM after we create the savefile?

It would be ideal, so that we would not need to display this (otherwise useless) VM in the manager (which only confuses the user).

[marmarek]

Comment by rafal on 30 Mar 2011 11:46 UTC
The current code expects to store certain files in template-dvm directory. So, the quick answer is no.
We could probably remove template-dvm from qubes.xml only. We would have to re-add it before each savefile regeneration (so that qvm-start would work); it is not particularly nice.
The clean solution is to mark template-dvm as special (passing e.g. --dvm-template to qvm-create), and act properly - do not create appmenus for it, and do not show it in the manager. I guess automatically recognizing all VMs whose name end in -dvm is not particularly aesthetic. So, we need another property in qubes.xml ? New class perhaps ? Not sure if it is worth the effort.

[marmarek]

Comment by rafal on 30 Mar 2011 11:46 UTC
The current code expects to store certain files in template-dvm directory. So, the quick answer is no.
We could probably remove template-dvm from qubes.xml only. We would have to re-add it before each savefile regeneration (so that qvm-start would work); it is not particularly nice.
The clean solution is to mark template-dvm as special (passing e.g. --dvm-template to qvm-create), and act properly - do not create appmenus for it, and do not show it in the manager. I guess automatically recognizing all VMs whose name end in -dvm is not particularly aesthetic. So, we need another property in qubes.xml ? New class perhaps ? Not sure if it is worth the effort.

[marmarek]

Comment by joanna on 30 Mar 2011 13:13 UTC
Leaving it as it is now is only asking for troubles -- user will click on the appmenus for *-dvm, and some will perhaps even try to remove such VM from the gui-manager (I would probably do it myself!).

So, I think we should implement it now. Leaving this for the next week though.

[marmarek]

Comment by joanna on 30 Mar 2011 13:13 UTC
Leaving it as it is now is only asking for troubles -- user will click on the appmenus for *-dvm, and some will perhaps even try to remove such VM from the gui-manager (I would probably do it myself!).

So, I think we should implement it now. Leaving this for the next week though.

[marmarek]

Modified by joanna on 30 Mar 2011 13:55 UTC

[marmarek]

Modified by joanna on 30 Mar 2011 13:55 UTC

[marmarek]

Modified by joanna on 3 Apr 2011 09:24 UTC

[marmarek]

Modified by joanna on 3 Apr 2011 09:24 UTC

[marmarek]

Modified by marmarek on 3 Apr 2011 15:40 UTC

[marmarek]

Modified by marmarek on 3 Apr 2011 15:40 UTC

[marmarek]

Comment by marmarek on 3 Apr 2011 15:53 UTC
http://git.qubes-os.org/gitweb/?p=marmarek/core.git;a=commit;h=398734dad224f5fa99859ecf9f8fc030cf9cc43f
http://git.qubes-os.org/gitweb/?p=marmarek/qubes-manager.git;a=commit;h=74a4fcd10ee9e5a3df9eb02cbb09970e9e28a0eb

[marmarek]

Comment by marmarek on 3 Apr 2011 15:53 UTC
http://git.qubes-os.org/gitweb/?p=marmarek/core.git;a=commit;h=398734dad224f5fa99859ecf9f8fc030cf9cc43f
http://git.qubes-os.org/gitweb/?p=marmarek/qubes-manager.git;a=commit;h=74a4fcd10ee9e5a3df9eb02cbb09970e9e28a0eb