/qubes-issues

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qvm-revert-template-changes fails for HVM template. #1573

Closed
marmarek opened this Issue Jan 3, 2016 · 3 comments

Comments

Assignees

@marmarek marmarek

Labels
Projects
None yet
Milestone
  Release 3.1
1 participant
@marmarek
@marmarek
Member

marmarek commented Jan 3, 2016

https://groups.google.com/d/msgid/qubes-users/3e9bd2ab-aab8-407e-9e03-27bd48aa6c7a%40googlegroups.com

Trying to revert a HVM template in Qubes R3.1 RC1 I get this error message:

[user@dom0 ~]$ sudo qvm-revert-template-changes winxp
Traceback (most recent call last):
  File "/bin/qvm-revert-template-changes", line 142, in <module>
    main()
  File "/bin/qvm-revert-template-changes", line 66, in main
    oldcow_img = vm.rootcow_img + '.old'
TypeError: unsupported operand type(s) for +: 'instancemethod' and 'str'


'vm.rootcow_image' is not a string but: <bound method QubesTemplateHVm.rootcow_img of
<QubesTemplateHVm at 0x181edd0 qid=36 name='winxp'>>, so string concatenation fails.

I don't get this error if the vm is a normal PV template.

@marmarek marmarek added bug C: core P: major labels Jan 3, 2016

@marmarek marmarek added this to the Release 3.1 milestone Jan 3, 2016

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Jan 3, 2016

Member

/cc @kalkin one more thing to take care of, when reworking storage. Will add a test for it.
Member

marmarek commented Jan 3, 2016

/cc @kalkin one more thing to take care of, when reworking storage. Will add a test for it.

@marmarek marmarek self-assigned this Jan 6, 2016

marmarek added a commit to marmarek/old-qubes-core-admin that referenced this issue Jan 7, 2016

@marmarek
core: mark QubesTemplateHVm.rootcow_img as property 
Add missing '@Property'.

QubesOS/qubes-issues#1573
Verified
This commit was signed with a verified signature.
@marmarek marmarek Marek Marczykowski-Górecki
GPG key ID: 063938BA42CFA724 Learn about signing commits
b26f2a7

@marmarek marmarek closed this in marmarek/old-qubes-core-admin@35cb82c Jan 7, 2016

marmarek added a commit to marmarek/old-qubes-core-admin that referenced this issue Jan 7, 2016

@marmarek
tests: qvm-revert-template-changes 
Regression test for:
QubesOS/qubes-issues#1573
Verified
This commit was signed with a verified signature.
@marmarek marmarek Marek Marczykowski-Górecki
GPG key ID: 063938BA42CFA724 Learn about signing commits
4af5a05
@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Jan 7, 2016

Member

Automated announcement from builder-github

The package qubes-core-dom0-3.1.9-1.fc20 has been pushed to the r3.1 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update
Member

marmarek commented Jan 7, 2016

Automated announcement from builder-github

The package qubes-core-dom0-3.1.9-1.fc20 has been pushed to the r3.1 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

@marmarek marmarek added the r3.1-dom0-cur-test label Jan 7, 2016

@marmarek marmarek referenced this issue Jan 10, 2016

Closed

`root-cow.img` of HVM template isn't created on update #1602

marmarek added a commit to marmarek/old-qubes-core-admin that referenced this issue Jan 12, 2016

@marmarek
core/hvm: create `root-cow.img` if it's missing 
It should be created at VM creation time (or template changes commit).
But for example for HVM templates created before implementing
QubesOS/qubes-issues#1573, there would be no such image. So create it
when needed, just before VM startup

Fixes QubesOS/qubes-issues#1602
Verified
This commit was signed with a verified signature.
@marmarek marmarek Marek Marczykowski-Górecki
GPG key ID: 063938BA42CFA724 Learn about signing commits
8b9049d
@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Jan 12, 2016

Member

Automated announcement from builder-github

The package qubes-core-dom0-3.1.10-1.fc20 has been pushed to the r3.1 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update
Member

marmarek commented Jan 12, 2016

Automated announcement from builder-github

The package qubes-core-dom0-3.1.10-1.fc20 has been pushed to the r3.1 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

@marmarek marmarek added r3.1-dom0-stable and removed r3.1-dom0-cur-test labels Jan 12, 2016

marmarek added a commit to QubesOS/qubes-core-admin that referenced this issue Jan 15, 2016

@marmarek
tests: qvm-revert-template-changes 
Regression test for:
QubesOS/qubes-issues#1573

(cherry picked from commit 4af5a05)

Only the part present in R3.0 - PV templates only
Verified
This commit was signed with a verified signature.
@marmarek marmarek Marek Marczykowski-Górecki
GPG key ID: 063938BA42CFA724 Learn about signing commits
dd05317

marmarek added a commit to QubesOS/qubes-core-admin that referenced this issue Feb 29, 2016

@marmarek
core: mark QubesTemplateHVm.rootcow_img as property 
Add missing '@Property'.

QubesOS/qubes-issues#1573

(cherry picked from commit b26f2a7)
Verified
This commit was signed with a verified signature.
@marmarek marmarek Marek Marczykowski-Górecki
GPG key ID: 063938BA42CFA724 Learn about signing commits
8abdeb8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment