New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

color of icons in apps.icons/ isn't updated when changing vm label #1606

Closed
taradiddles opened this Issue Jan 12, 2016 · 4 comments

Comments

Projects
None yet
3 participants
@taradiddles

Minor issue: in R3.1rc, when changing a vm label (say, "banking" from green to yellow), the icons in /var/lib/qubes/appvms/banking/apps.icons/ aren't updated to the new color (confirmed by opening them in an image viewer, they're still green, so it's not a caching issue).
Consequence: anything that uses the apps' .desktop definitions still show the old label/color. For instance sub-entries of "Domain: banking" in xfce's menu are still green (firefox, files, ...) (the "root" entry in the menu properly displays a yellow padlock though).

@andrewdavidwong

This comment has been minimized.

Show comment
Hide comment
@andrewdavidwong

andrewdavidwong Mar 13, 2016

Member

Is this a dupe of #751?

Anyway, confirmed on R3.1 stable. Steps to reproduce (same as past stable Qubes releases):

  1. Create a green AppVM.
  2. Change it to gray.
  3. qvm-sync-appmenus, host reboot, etc.
  4. Color of "menu" lock icon changed to gray, but all specific application icons in the menu are still green.
Member

andrewdavidwong commented Mar 13, 2016

Is this a dupe of #751?

Anyway, confirmed on R3.1 stable. Steps to reproduce (same as past stable Qubes releases):

  1. Create a green AppVM.
  2. Change it to gray.
  3. qvm-sync-appmenus, host reboot, etc.
  4. Color of "menu" lock icon changed to gray, but all specific application icons in the menu are still green.

marmarek added a commit to marmarek/qubes-core-admin-linux that referenced this issue Apr 19, 2016

marmarek added a commit to QubesOS/qubes-core-admin-linux that referenced this issue May 17, 2016

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek May 17, 2016

Member

Automated announcement from builder-github

The package qubes-core-dom0-linux-3.1.11-1.fc20 has been pushed to the r3.1 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

Member

marmarek commented May 17, 2016

Automated announcement from builder-github

The package qubes-core-dom0-linux-3.1.11-1.fc20 has been pushed to the r3.1 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

marmarek added a commit to marmarek/qubes-core-admin-linux that referenced this issue May 25, 2016

@taradiddles

This comment has been minimized.

Show comment
Hide comment
@taradiddles

taradiddles Jun 10, 2016

Sorry to write on a closed issue, I should have tested the rpm while it was in the testing repo...
Maybe I'm doing something wrong, but it looks like the issue isn't fully solved:

  • create an orange vm ; /var/lib/qubes/appsvm/vmname/apps.icons/firefox.jpg is orange
  • then change it to gray ; /var/lib/qubes/appsvm/vmname/apps.icons/firefox.jpg is still orange (same file/modification time as before).

but - running "add more shortcuts" from the menu, modifying a shortcut to have something changed and clicking OK, and the icons' color is then updated to gray.

Sorry to write on a closed issue, I should have tested the rpm while it was in the testing repo...
Maybe I'm doing something wrong, but it looks like the issue isn't fully solved:

  • create an orange vm ; /var/lib/qubes/appsvm/vmname/apps.icons/firefox.jpg is orange
  • then change it to gray ; /var/lib/qubes/appsvm/vmname/apps.icons/firefox.jpg is still orange (same file/modification time as before).

but - running "add more shortcuts" from the menu, modifying a shortcut to have something changed and clicking OK, and the icons' color is then updated to gray.

woju added a commit to woju/qubes-core-admin-linux that referenced this issue Jun 13, 2016

marmarek added a commit to marmarek/qubes-core-admin-linux that referenced this issue Jul 17, 2016

appmenus: fix detection of desktop environment
In Fedora 23-based dom0, DESKTOP_SESSION environment contains full path
to session file, instead of just basename.

QubesOS/qubes-issues#1606
@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Jul 25, 2016

Member

Automated announcement from builder-github

The package qubes-core-dom0-linux-3.1.12-1.fc20 has been pushed to the r3.1 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

Member

marmarek commented Jul 25, 2016

Automated announcement from builder-github

The package qubes-core-dom0-linux-3.1.12-1.fc20 has been pushed to the r3.1 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

marmarek added a commit to marmarek/qubes-core-admin-linux that referenced this issue Aug 7, 2016

@qubesos-bot qubesos-bot referenced this issue in QubesOS/updates-status May 26, 2017

Closed

core-admin-linux v4.0.0 (r4.0) #57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment