/qubes-issues

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DispVM firewall settings are neither independent nor volatile. #1608

Closed
marmarek opened this Issue Jan 13, 2016 · 5 comments

Comments

Assignees

@marmarek marmarek

Labels
Projects
None yet
Milestone
  Release 3.1
1 participant
@marmarek
@marmarek
Member

marmarek commented Jan 13, 2016

https://groups.google.com/d/msgid/qubes-users/d7ba0ec8-2e08-4f37-a0b6-a9a7d0330e2b%40googlegroups.com

When I have multiple DispVMs running and change the firewall settings of one, then it affects
ALL of them plus the settings of fedora-23-dvm. This makes the changes also persistent.

I guess VM settings should only apply to exactly one VM. And especially for DispVMs they should
be as volatile as the DispVM.

Does some config file get symlinked instead of copied when creating a new DVM? I didn't do
further research.

@marmarek marmarek added bug C: core P: major labels Jan 13, 2016

@marmarek marmarek added this to the Release 3.1 milestone Jan 13, 2016

marmarek added a commit to marmarek/old-qubes-core-admin that referenced this issue Jan 14, 2016

@marmarek
tests: add a test for proper saving of DispVM firewall rules 
Test if DispVM firewall rules are:
 - inherited from a calling VM
 - saved properly (so will be effective after firewall reload)
 - saved only for that DispVM (#1608)

QubesOS/qubes-issues#1608
Verified
This commit was signed with a verified signature.
@marmarek marmarek Marek Marczykowski-Górecki
GPG key ID: 063938BA42CFA724 Learn about signing commits
f4d46c7

marmarek added a commit to QubesOS/qubes-core-admin that referenced this issue Jan 15, 2016

@marmarek
tests: add a test for proper saving of DispVM firewall rules 
Test if DispVM firewall rules are:
 - inherited from a calling VM
 - saved properly (so will be effective after firewall reload)
 - saved only for that DispVM (#1608)

QubesOS/qubes-issues#1608

(cherry picked from commit f4d46c7)

Conflicts:
	tests/basic.py
Verified
This commit was signed with a verified signature.
@marmarek marmarek Marek Marczykowski-Górecki
GPG key ID: 063938BA42CFA724 Learn about signing commits
69f7fdf
@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Jan 18, 2016

Member

Important condition - fedora-23-dvm needs to have customized firewall rules for this bug to happen.
Member

marmarek commented Jan 18, 2016

Important condition - fedora-23-dvm needs to have customized firewall rules for this bug to happen.

@marmarek marmarek self-assigned this Jan 18, 2016

marmarek added a commit to marmarek/old-qubes-core-admin that referenced this issue Jan 20, 2016

@marmarek
tests: "empty" firewall propagation 
Check if "empty" firewall is also properly propagated.

QubesOS/qubes-issues#1608
Verified
This commit was signed with a verified signature.
@marmarek marmarek Marek Marczykowski-Górecki
GPG key ID: 063938BA42CFA724 Learn about signing commits
ce75ba4

@marmarek marmarek closed this in marmarek/old-qubes-core-admin@8737064 Jan 20, 2016

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Feb 8, 2016

Member

Automated announcement from builder-github

The package qubes-core-dom0-3.1.12-1.fc20 has been pushed to the r3.1 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update
Member

marmarek commented Feb 8, 2016

Automated announcement from builder-github

The package qubes-core-dom0-3.1.12-1.fc20 has been pushed to the r3.1 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

@marmarek marmarek added the r3.1-dom0-cur-test label Feb 8, 2016

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Feb 22, 2016

Member

Automated announcement from builder-github

The package qubes-core-dom0-3.1.12-1.fc20 has been pushed to the r3.1 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update
Member

marmarek commented Feb 22, 2016

Automated announcement from builder-github

The package qubes-core-dom0-3.1.12-1.fc20 has been pushed to the r3.1 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

@marmarek marmarek added r3.1-dom0-stable and removed r3.1-dom0-cur-test labels Feb 22, 2016

marmarek added a commit to QubesOS/qubes-core-admin that referenced this issue Feb 29, 2016

@marmarek
tests: add a test for proper saving of DispVM firewall rules 
Test if DispVM firewall rules are:
 - inherited from a calling VM
 - saved properly (so will be effective after firewall reload)
 - saved only for that DispVM (#1608)

QubesOS/qubes-issues#1608

(cherry picked from commit f4d46c7)
Verified
This commit was signed with a verified signature.
@marmarek marmarek Marek Marczykowski-Górecki
GPG key ID: 063938BA42CFA724 Learn about signing commits
c442ff5

marmarek added a commit to QubesOS/qubes-core-admin that referenced this issue Feb 29, 2016

@marmarek
tests: "empty" firewall propagation 
Check if "empty" firewall is also properly propagated.

QubesOS/qubes-issues#1608

(cherry picked from commit ce75ba4)
Verified
This commit was signed with a verified signature.
@marmarek marmarek Marek Marczykowski-Górecki
GPG key ID: 063938BA42CFA724 Learn about signing commits
4adcfe1

marmarek added a commit to QubesOS/qubes-core-admin that referenced this issue Feb 29, 2016

@marmarek
dispvm: fix firewall propagation when the calling VM has no rules set 
Fixes QubesOS/qubes-issues#1608

(cherry picked from commit 8737064)
Verified
This commit was signed with a verified signature.
@marmarek marmarek Marek Marczykowski-Górecki
GPG key ID: 063938BA42CFA724 Learn about signing commits
e49698b
@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Feb 29, 2016

Member

Automated announcement from builder-github

The package qubes-core-dom0-3.0.28-1.fc20 has been pushed to the r3.0 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update
Member

marmarek commented Feb 29, 2016

Automated announcement from builder-github

The package qubes-core-dom0-3.0.28-1.fc20 has been pushed to the r3.0 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

@marmarek marmarek added the r3.0-dom0-testing label Feb 29, 2016

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 13, 2016

Member

Automated announcement from builder-github

The package qubes-core-dom0-3.0.28-1.fc20 has been pushed to the r3.0 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update
Member

marmarek commented Mar 13, 2016

Automated announcement from builder-github

The package qubes-core-dom0-3.0.28-1.fc20 has been pushed to the r3.0 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

@marmarek marmarek added r3.0-dom0-stable and removed r3.0-dom0-testing labels Mar 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment