/qubes-issues

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add better support for test class-wide setup/teardown #1691

Closed
marmarek opened this Issue Jan 25, 2016 · 7 comments

Comments

Assignees

@marmarek marmarek

Labels
Projects
None yet
Milestone
  Release 3.1
2 participants
@marmarek @kalkin
@marmarek
Member

marmarek commented Jan 25, 2016

It would be useful when setup is time consuming (for example template clone), but tests in such class do not alter its state.

/cc @kalkin

@marmarek marmarek added enhancement P: major C: tests labels Jan 25, 2016

@marmarek marmarek added this to the Release 3.1 milestone Jan 25, 2016

@marmarek marmarek self-assigned this Jan 25, 2016

@kalkin

This comment has been minimized.

Show comment
Hide comment
@kalkin

kalkin Jan 28, 2016

Member

Will take care of it when I'm back from XMPP Summit & Fosdem (around 2-nd 5-th February)
Member

kalkin commented Jan 28, 2016

Will take care of it when I'm back from XMPP Summit & Fosdem (around 2-nd 5-th February)
@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Jan 28, 2016

Member

Actually it's already done :) I think I'll push it today/tomorrow.
Member

marmarek commented Jan 28, 2016

Actually it's already done :) I think I'll push it today/tomorrow.
@kalkin

This comment has been minimized.

Show comment
Hide comment
@kalkin

kalkin Jan 28, 2016

Member

@marmarek Awesome 😄
Member

kalkin commented Jan 28, 2016

@marmarek Awesome 😄

@marmarek marmarek closed this in marmarek/old-qubes-core-admin@84af738 Jan 29, 2016

marmarek added a commit to marmarek/old-qubes-core-admin that referenced this issue Jan 29, 2016

@marmarek
tests: do not crash when trying to log class setup/teardown fail 
QubesOS/qubes-issues#1691
Verified
This commit was signed with a verified signature.
@marmarek marmarek Marek Marczykowski-Górecki
GPG key ID: 063938BA42CFA724 Learn about signing commits
be00d15
@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Feb 8, 2016

Member

Automated announcement from builder-github

The package qubes-core-dom0-3.1.12-1.fc20 has been pushed to the r3.1 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update
Member

marmarek commented Feb 8, 2016

Automated announcement from builder-github

The package qubes-core-dom0-3.1.12-1.fc20 has been pushed to the r3.1 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

@marmarek marmarek added the r3.1-dom0-cur-test label Feb 8, 2016

marmarek added a commit to marmarek/old-qubes-core-admin that referenced this issue Feb 10, 2016

@marmarek
tests: redo "84af738 tests: support VMs cleaned up in tearDownClass..." 
Usage: VMs with name created by self.make_vm_name(name,
class_teardown=True) will be cleaned up in tearDownClass. It
should be used only in setUpClass.

Fixes QubesOS/qubes-issues#1691
Verified
This commit was signed with a verified signature.
@marmarek marmarek Marek Marczykowski-Górecki
GPG key ID: 063938BA42CFA724 Learn about signing commits
4133ae2
@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Feb 22, 2016

Member

Automated announcement from builder-github

The package qubes-core-dom0-3.1.12-1.fc20 has been pushed to the r3.1 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update
Member

marmarek commented Feb 22, 2016

Automated announcement from builder-github

The package qubes-core-dom0-3.1.12-1.fc20 has been pushed to the r3.1 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

@marmarek marmarek added r3.1-dom0-stable and removed r3.1-dom0-cur-test labels Feb 22, 2016

woju added a commit to woju/qubes-core-admin that referenced this issue Feb 29, 2016

@marmarek @woju
tests: redo "84af738 tests: support VMs cleaned up in tearDownClass..." 
Usage: VMs with name created by self.make_vm_name(name,
class_teardown=True) will be cleaned up in tearDownClass. It
should be used only in setUpClass.

Fixes QubesOS/qubes-issues#1691
ee08e5f

marmarek added a commit to QubesOS/qubes-core-admin that referenced this issue Feb 29, 2016

@marmarek
tests: support VMs cleaned up in tearDownClass, instead of tearDown 
Usage: VMs with name created by self.make_vm_name(name,
class_teardown=True) will be cleaned up in tearDownClass. It should be
used only in setUpClass.

Fixes QubesOS/qubes-issues#1691

(cherry picked from commit 84af738)
Verified
This commit was signed with a verified signature.
@marmarek marmarek Marek Marczykowski-Górecki
GPG key ID: 063938BA42CFA724 Learn about signing commits
3189ef9

marmarek added a commit to QubesOS/qubes-core-admin that referenced this issue Feb 29, 2016

@marmarek
tests: do not crash when trying to log class setup/teardown fail 
QubesOS/qubes-issues#1691

(cherry picked from commit be00d15)
Verified
This commit was signed with a verified signature.
@marmarek marmarek Marek Marczykowski-Górecki
GPG key ID: 063938BA42CFA724 Learn about signing commits
4782dd8
@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Feb 29, 2016

Member

Automated announcement from builder-github

The package qubes-core-dom0-3.0.28-1.fc20 has been pushed to the r3.0 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update
Member

marmarek commented Feb 29, 2016

Automated announcement from builder-github

The package qubes-core-dom0-3.0.28-1.fc20 has been pushed to the r3.0 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

@marmarek marmarek added the r3.0-dom0-testing label Feb 29, 2016

woju added a commit to woju/qubes-core-admin that referenced this issue Mar 3, 2016

@marmarek @woju
tests: redo "84af738 tests: support VMs cleaned up in tearDownClass..." 
Usage: VMs with name created by self.make_vm_name(name,
class_teardown=True) will be cleaned up in tearDownClass. It
should be used only in setUpClass.

Fixes QubesOS/qubes-issues#1691
65bd2c8

woju added a commit to woju/qubes-core-admin that referenced this issue Mar 3, 2016

@marmarek @woju
tests: redo "84af738 tests: support VMs cleaned up in tearDownClass..." 
Usage: VMs with name created by self.make_vm_name(name,
class_teardown=True) will be cleaned up in tearDownClass. It
should be used only in setUpClass.

Fixes QubesOS/qubes-issues#1691
bc82643
@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 13, 2016

Member

Automated announcement from builder-github

The package qubes-core-dom0-3.0.28-1.fc20 has been pushed to the r3.0 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update
Member

marmarek commented Mar 13, 2016

Automated announcement from builder-github

The package qubes-core-dom0-3.0.28-1.fc20 has been pushed to the r3.0 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

@marmarek marmarek added r3.0-dom0-stable and removed r3.0-dom0-testing labels Mar 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment