/qubes-issues

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rework qubesdb restarting on VM start #1694

Closed
marmarek opened this Issue Jan 26, 2016 · 10 comments

Comments

Assignees
No one assigned
Labels
Projects
None yet
Milestone
  Release 4.0
2 participants
@marmarek @qubesos-bot
@marmarek
Member

marmarek commented Jan 26, 2016

Basically think of some better solution for #1241. We don't like os.kill in start_qubesdb.

@marmarek marmarek added bug C: core P: major labels Jan 26, 2016

@marmarek marmarek added this to the Release 4.0 milestone Jan 26, 2016

marmarek added a commit to marmarek/qubes-core-qubesdb that referenced this issue Sep 7, 2016

@marmarek
daemon: remove pidfile and socket only when created by this instance 
It may happen that dom0 QubesDB instance was started again for the same
domain - for example when restarting domain. Old instance will
eventually notice its domain disappearance, but with noticeable delay -
10s in worst case.
Do not remove pidfile and socket in such a case - now those belongs to
the new instance.

There is still slight race condition - between stat and unlink call. But
this is very unlikely to cause problems.

Fixes QubesOS/qubes-issues#1694
Verified
This commit was signed with a verified signature.
@marmarek marmarek Marek Marczykowski-Górecki
GPG key ID: 063938BA42CFA724 Learn about signing commits
19d0618

woju added a commit to woju/qubes-core-qubesdb that referenced this issue Oct 5, 2016

@marmarek @woju
daemon: remove pidfile and socket only when created by this instance 
It may happen that dom0 QubesDB instance was started again for the same
domain - for example when restarting domain. Old instance will
eventually notice its domain disappearance, but with noticeable delay -
10s in worst case.
Do not remove pidfile and socket in such a case - now those belongs to
the new instance.

There is still slight race condition - between stat and unlink call. But
this is very unlikely to cause problems.

Fixes QubesOS/qubes-issues#1694
dc006a0

@marmarek marmarek closed this in marmarek/qubes-core-qubesdb@73f112a Oct 5, 2016

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Oct 5, 2016

Member

Automated announcement from builder-github

The package qubes-db-3.2.2-1.fc23 has been pushed to the r3.2 testing repository for the Fedora fc23 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r3.2-current-testing

Changes included in this update
Member

marmarek commented Oct 5, 2016

Automated announcement from builder-github

The package qubes-db-3.2.2-1.fc23 has been pushed to the r3.2 testing repository for the Fedora fc23 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r3.2-current-testing

Changes included in this update

@marmarek marmarek added the r3.2-fc23-cur-test label Oct 5, 2016

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Oct 5, 2016

Member

Automated announcement from builder-github

The package qubes-db-3.2.2-1.fc24 has been pushed to the r3.2 testing repository for the Fedora fc24 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r3.2-current-testing

Changes included in this update
Member

marmarek commented Oct 5, 2016

Automated announcement from builder-github

The package qubes-db-3.2.2-1.fc24 has been pushed to the r3.2 testing repository for the Fedora fc24 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r3.2-current-testing

Changes included in this update

@marmarek marmarek added the r3.2-fc24-cur-test label Oct 5, 2016

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Oct 5, 2016

Member

Automated announcement from builder-github

The package qubes-db-3.2.2-1.fc23 has been pushed to the r3.2 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update
Member

marmarek commented Oct 5, 2016

Automated announcement from builder-github

The package qubes-db-3.2.2-1.fc23 has been pushed to the r3.2 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

@marmarek marmarek added the r3.2-dom0-cur-test label Oct 5, 2016

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Oct 5, 2016

Member

Automated announcement from builder-github

The package qubesdb_3.2.2-1+deb8u1 has been pushed to the r3.2 testing repository for the Debian jessie template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing jessie-testing, then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update
Member

marmarek commented Oct 5, 2016

Automated announcement from builder-github

The package qubesdb_3.2.2-1+deb8u1 has been pushed to the r3.2 testing repository for the Debian jessie template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing jessie-testing, then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@marmarek marmarek added the r3.2-jessie-cur-test label Oct 5, 2016

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Oct 5, 2016

Member

Automated announcement from builder-github

The package qubesdb_3.2.2-1+deb9u1 has been pushed to the r3.2 testing repository for the Debian stretch template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing stretch-testing, then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update
Member

marmarek commented Oct 5, 2016

Automated announcement from builder-github

The package qubesdb_3.2.2-1+deb9u1 has been pushed to the r3.2 testing repository for the Debian stretch template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing stretch-testing, then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@marmarek marmarek added the r3.2-stretch-cur-test label Oct 5, 2016

marmarek added a commit to marmarek/qubes-core-admin that referenced this issue Nov 4, 2016

@marmarek
qubes/vm: disconnect from old QubesDB when going to start new instance 
QubesDB daemon no longer remove socket created by new instance, so one
part of VM restart race condition is solved. The only remaining part is
to ensure that we really connect to the new instance, instead of talking
to the old one (soon to be terminated).

Fixes QubesOS/qubes-issues#1694
Verified
This commit was signed with a verified signature.
@marmarek marmarek Marek Marczykowski-Górecki
GPG key ID: 063938BA42CFA724 Learn about signing commits
5ffe082

marmarek added a commit to marmarek/qubes-core-admin that referenced this issue Nov 4, 2016

@marmarek
qubes/vm: disconnect from old QubesDB when going to start new instance 
QubesDB daemon no longer remove socket created by new instance, so one
part of VM restart race condition is solved. The only remaining part is
to ensure that we really connect to the new instance, instead of talking
to the old one (soon to be terminated).

Fixes QubesOS/qubes-issues#1694
Verified
This commit was signed with a verified signature.
@marmarek marmarek Marek Marczykowski-Górecki
GPG key ID: 063938BA42CFA724 Learn about signing commits
4aea148

marmarek added a commit to marmarek/qubes-core-admin that referenced this issue Nov 4, 2016

@marmarek
qubes/vm: disconnect from old QubesDB when going to start new instance 
QubesDB daemon no longer remove socket created by new instance, so one
part of VM restart race condition is solved. The only remaining part is
to ensure that we really connect to the new instance, instead of talking
to the old one (soon to be terminated).

Fixes QubesOS/qubes-issues#1694
Verified
This commit was signed with a verified signature.
@marmarek marmarek Marek Marczykowski-Górecki
GPG key ID: 063938BA42CFA724 Learn about signing commits
4cd6f59
@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Nov 17, 2016

Member

Automated announcement from builder-github

The package qubes-db-3.2.3-1.fc23 has been pushed to the r3.2 stable repository for the Fedora fc23 template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update
Member

marmarek commented Nov 17, 2016

Automated announcement from builder-github

The package qubes-db-3.2.3-1.fc23 has been pushed to the r3.2 stable repository for the Fedora fc23 template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

@marmarek marmarek added r3.2-fc23-stable and removed r3.2-fc23-cur-test labels Nov 17, 2016

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Nov 17, 2016

Member

Automated announcement from builder-github

The package qubes-db-3.2.3-1.fc24 has been pushed to the r3.2 stable repository for the Fedora fc24 template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update
Member

marmarek commented Nov 17, 2016

Automated announcement from builder-github

The package qubes-db-3.2.3-1.fc24 has been pushed to the r3.2 stable repository for the Fedora fc24 template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

@marmarek marmarek added r3.2-fc24-stable and removed r3.2-fc24-cur-test labels Nov 17, 2016

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Nov 17, 2016

Member

Automated announcement from builder-github

The package qubes-db-3.2.3-1.fc23 has been pushed to the r3.2 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update
Member

marmarek commented Nov 17, 2016

Automated announcement from builder-github

The package qubes-db-3.2.3-1.fc23 has been pushed to the r3.2 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

@marmarek marmarek added r3.2-dom0-stable and removed r3.2-dom0-cur-test labels Nov 17, 2016

marmarek added a commit to marmarek/qubes-core-admin that referenced this issue Nov 28, 2016

@marmarek
qubes/vm: disconnect from old QubesDB when going to start new instance 
QubesDB daemon no longer remove socket created by new instance, so one
part of VM restart race condition is solved. The only remaining part is
to ensure that we really connect to the new instance, instead of talking
to the old one (soon to be terminated).

Fixes QubesOS/qubes-issues#1694
Verified
This commit was signed with a verified signature.
@marmarek marmarek Marek Marczykowski-Górecki
GPG key ID: 063938BA42CFA724 Learn about signing commits
8f44354
@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Dec 4, 2016

Member

Automated announcement from builder-github

The package qubesdb_3.2.3-1+deb8u1 has been pushed to the r3.2 stable repository for the Debian jessie template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update
Member

marmarek commented Dec 4, 2016

Automated announcement from builder-github

The package qubesdb_3.2.3-1+deb8u1 has been pushed to the r3.2 stable repository for the Debian jessie template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@marmarek marmarek added r3.2-jessie-stable and removed r3.2-jessie-cur-test labels Dec 4, 2016

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Dec 19, 2016

Automated announcement from builder-github

The package qubesdb_3.2.3-1+deb9u1 has been pushed to the r3.2 stable repository for the Debian stretch template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

qubesos-bot commented Dec 19, 2016

Automated announcement from builder-github

The package qubesdb_3.2.3-1+deb9u1 has been pushed to the r3.2 stable repository for the Debian stretch template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot qubesos-bot added r3.2-stretch-stable and removed r3.2-stretch-cur-test labels Dec 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment