New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement vm.shutdown(wait=True) #1696

Open
marmarek opened this Issue Jan 26, 2016 · 3 comments

Comments

Projects
None yet
3 participants
@marmarek
Member

marmarek commented Jan 26, 2016

And replace all loops waiting for VM shutdown with it.

@marmarek marmarek added this to the Release 4.0 milestone Jan 26, 2016

@kalkin kalkin referenced this issue in QubesOS/qubes-core-admin Aug 1, 2016

Merged

Add vm.shutdown(wait) #48

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Aug 4, 2016

Member

Additionally there should be some timeout, after which VM gets killed.

Member

marmarek commented Aug 4, 2016

Additionally there should be some timeout, after which VM gets killed.

@tasket

This comment has been minimized.

Show comment
Hide comment
@tasket

tasket Mar 5, 2017

This would really be nice. Putting 'sleep' timers after vm.shutdown == :(

Maybe Qubes API could be more mindful of whether methods are/aren't synchronous and provide parameters to make them sync/async. Actually.... Qubes API could use ref doc, too.

tasket commented Mar 5, 2017

This would really be nice. Putting 'sleep' timers after vm.shutdown == :(

Maybe Qubes API could be more mindful of whether methods are/aren't synchronous and provide parameters to make them sync/async. Actually.... Qubes API could use ref doc, too.

@marmarek

This comment has been minimized.

Show comment
Hide comment
@marmarek

marmarek Mar 5, 2017

Member

As for API docs, it exists for Qubes 4.0: http://qubes-core-admin.readthedocs.io/en/latest/
wait parameter is exactly for this sync/async distinction here. In Qubes 4.0 most (all?) actions results in an event, so it can be used for async calls - initiate a call and instead of waiting for it to finish, react later on an event.

Member

marmarek commented Mar 5, 2017

As for API docs, it exists for Qubes 4.0: http://qubes-core-admin.readthedocs.io/en/latest/
wait parameter is exactly for this sync/async distinction here. In Qubes 4.0 most (all?) actions results in an event, so it can be used for async calls - initiate a call and instead of waiting for it to finish, react later on an event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment